From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07816C54E94 for ; Tue, 24 Jan 2023 13:41:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234106AbjAXNl5 (ORCPT ); Tue, 24 Jan 2023 08:41:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60876 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234136AbjAXNlw (ORCPT ); Tue, 24 Jan 2023 08:41:52 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F285A4523E; Tue, 24 Jan 2023 05:41:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 8FDEB611E6; Tue, 24 Jan 2023 13:41:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66FC1C4339B; Tue, 24 Jan 2023 13:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674567709; bh=plVLPqyNKrCgUkP+vGqlaiEfLLVEMW02/8pVeTqqtSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S23rUbA8EZrNUno3iAy21PHDbyTnpxJArMK07I8fLyW8hqBichU2k7eyPV7AGcrKt EJzzd7biR+fRRc4xzdOrXa7cfXe6Fa8uStsa6uLVsCPhiydrKEY75S+kmJl7IjcExY I2R73wc+cxAhJvbiTVlqA9M02Fj9HiqXkvOurOtjtsIxD/Q81Q1e2xyT3+ZUDz+P/3 D8xItA+FFKX+jt7rbliDCbpMIHdE1VmPfwPrdZD7p/jp+Bvryw2uVC+V+YagOJhJmq noWxA1NEaKPZ3KQ703FLgb/U184msWmc6s9foSickyaY6lNyENCxJyO2cfVmwRKxdD rkElaTc6tqLmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Marussi , Sudeep Holla , Sasha Levin , linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 05/35] firmware: arm_scmi: Clear stale xfer->hdr.status Date: Tue, 24 Jan 2023 08:41:01 -0500 Message-Id: <20230124134131.637036-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230124134131.637036-1-sashal@kernel.org> References: <20230124134131.637036-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cristian Marussi [ Upstream commit f6ca5059dc0d6608dc46070f48e396d611f240d6 ] Stale error status reported from a previous message transaction must be cleared before starting a new transaction to avoid being confusingly reported in the following SCMI message dump traces. Signed-off-by: Cristian Marussi Link: https://lore.kernel.org/r/20221222183823.518856-2-cristian.marussi@arm.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index f818d00bb2c6..ffdad59ec81f 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -910,6 +910,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, xfer->hdr.protocol_id, xfer->hdr.seq, xfer->hdr.poll_completion); + /* Clear any stale status */ + xfer->hdr.status = SCMI_SUCCESS; xfer->state = SCMI_XFER_SENT_OK; /* * Even though spinlocking is not needed here since no race is possible -- 2.39.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D351AC38142 for ; Tue, 24 Jan 2023 13:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=y/LovRMMwKjV4pCS8i4bEAC8CMnwnQLqmcg2f1KxRRY=; b=qwdU1FpLJVeFzq b1c8OncZC1qJeY79cAhrN136R4rYJyZTNfqoZqNlQz0q8z+SAmud3EFYFlLk//XjF2d+fqnpnFgry 3Ab2TkKZip0k0rFZuyUCUXRH+hguoQUbH+5adMMOgArqbdWRQv8ZO7VoCPzDhXcarY8+xpKxLYL0J Kiw+W28NvFCBx+ylIwNpDLg84ZvwCQXYtHDsN6ot1dWKy4Oygw5PfZ6hiabTlOxJXeI6OkimD3qZ6 kwzS/1wh9UJ6GeIPqvcXSRZkfmGJtFC2YSLDquSicjvnJA7zT8/UJwwAdOQ80EqRZQCiGFM9Jwni0 5nYmcXIDSN251lseZjlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKJdj-0043b2-V3; Tue, 24 Jan 2023 13:47:08 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKJYc-0040o3-LB for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 13:41:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 529B5B811D5; Tue, 24 Jan 2023 13:41:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66FC1C4339B; Tue, 24 Jan 2023 13:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674567709; bh=plVLPqyNKrCgUkP+vGqlaiEfLLVEMW02/8pVeTqqtSI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S23rUbA8EZrNUno3iAy21PHDbyTnpxJArMK07I8fLyW8hqBichU2k7eyPV7AGcrKt EJzzd7biR+fRRc4xzdOrXa7cfXe6Fa8uStsa6uLVsCPhiydrKEY75S+kmJl7IjcExY I2R73wc+cxAhJvbiTVlqA9M02Fj9HiqXkvOurOtjtsIxD/Q81Q1e2xyT3+ZUDz+P/3 D8xItA+FFKX+jt7rbliDCbpMIHdE1VmPfwPrdZD7p/jp+Bvryw2uVC+V+YagOJhJmq noWxA1NEaKPZ3KQ703FLgb/U184msWmc6s9foSickyaY6lNyENCxJyO2cfVmwRKxdD rkElaTc6tqLmg== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Marussi , Sudeep Holla , Sasha Levin , linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.1 05/35] firmware: arm_scmi: Clear stale xfer->hdr.status Date: Tue, 24 Jan 2023 08:41:01 -0500 Message-Id: <20230124134131.637036-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230124134131.637036-1-sashal@kernel.org> References: <20230124134131.637036-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_054150_877514_E34DB67C X-CRM114-Status: GOOD ( 11.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Cristian Marussi [ Upstream commit f6ca5059dc0d6608dc46070f48e396d611f240d6 ] Stale error status reported from a previous message transaction must be cleared before starting a new transaction to avoid being confusingly reported in the following SCMI message dump traces. Signed-off-by: Cristian Marussi Link: https://lore.kernel.org/r/20221222183823.518856-2-cristian.marussi@arm.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index f818d00bb2c6..ffdad59ec81f 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -910,6 +910,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, xfer->hdr.protocol_id, xfer->hdr.seq, xfer->hdr.poll_completion); + /* Clear any stale status */ + xfer->hdr.status = SCMI_SUCCESS; xfer->state = SCMI_XFER_SENT_OK; /* * Even though spinlocking is not needed here since no race is possible -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel