From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Paulo Alcantara <pc@cjr.nz>, kernel test robot <lkp@intel.com>,
Steve French <stfrench@microsoft.com>,
Sasha Levin <sashal@kernel.org>,
sfrench@samba.org, linux-cifs@vger.kernel.org,
samba-technical@lists.samba.org
Subject: [PATCH AUTOSEL 5.15 13/14] cifs: fix return of uninitialized rc in dfs_cache_update_tgthint()
Date: Tue, 24 Jan 2023 08:42:56 -0500 [thread overview]
Message-ID: <20230124134257.637523-13-sashal@kernel.org> (raw)
In-Reply-To: <20230124134257.637523-1-sashal@kernel.org>
From: Paulo Alcantara <pc@cjr.nz>
[ Upstream commit d6a49e8c4ca4d399ed65ac219585187fc8c2e2b1 ]
Fix this by initializing rc to 0 as cache_refresh_path() would not set
it in case of success.
Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/all/202301190004.bEHvbKG6-lkp@intel.com/
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
fs/cifs/dfs_cache.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c
index 1f3efa7821a0..935c5781d878 100644
--- a/fs/cifs/dfs_cache.c
+++ b/fs/cifs/dfs_cache.c
@@ -1046,10 +1046,10 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
const struct nls_table *cp, int remap, const char *path,
const struct dfs_cache_tgt_iterator *it)
{
- int rc;
- const char *npath;
- struct cache_entry *ce;
struct cache_dfs_tgt *t;
+ struct cache_entry *ce;
+ const char *npath;
+ int rc = 0;
npath = dfs_cache_canonical_path(path, cp, remap);
if (IS_ERR(npath))
--
2.39.0
next prev parent reply other threads:[~2023-01-24 13:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 13:42 [PATCH AUTOSEL 5.15 01/14] ARM: dts: imx: Fix pca9547 i2c-mux node name Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 02/14] ARM: dts: vf610: Fix pca9548 i2c-mux node names Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 03/14] arm64: dts: freescale: Fix pca954x " Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 04/14] arm64: dts: imx8mq-thor96: fix no-mmc property for SDHCI Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 05/14] firmware: arm_scmi: Clear stale xfer->hdr.status Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 06/14] bpf: Skip task with pid=1 in send_signal_common() Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 07/14] erofs/zmap.c: Fix incorrect offset calculation Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 08/14] init/Kconfig: fix LOCALVERSION_AUTO help text Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 09/14] btrfs: factor out scratching of one regular super block Sasha Levin
2023-01-24 13:44 ` Christoph Hellwig
[not found] ` <20230124134257.637523-1-sashal-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 10/14] blk-cgroup: fix missing pd_online_fn() while activating policy Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 11/14] HID: playstation: sanity check DualSense calibration data Sasha Levin
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 12/14] dmaengine: imx-sdma: Fix a possible memory leak in sdma_transfer_init Sasha Levin
2023-01-24 13:42 ` Sasha Levin
2023-01-24 13:42 ` Sasha Levin [this message]
2023-01-24 13:42 ` [PATCH AUTOSEL 5.15 14/14] ext4: deal with legacy signed xattr name hash values Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124134257.637523-13-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pc@cjr.nz \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--cc=stable@vger.kernel.org \
--cc=stfrench@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.