From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B223C25B4E for ; Tue, 24 Jan 2023 13:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234463AbjAXNot (ORCPT ); Tue, 24 Jan 2023 08:44:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234374AbjAXNoU (ORCPT ); Tue, 24 Jan 2023 08:44:20 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DB4A45BC2; Tue, 24 Jan 2023 05:43:15 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AEDDAB811E1; Tue, 24 Jan 2023 13:43:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2ABBC433B4; Tue, 24 Jan 2023 13:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674567793; bh=Fr8ngUSDZFbNweZe4Xpvn5UQljHV0Y4OKofXPoxRvOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WqYUKWCdBVY8caoz5m/GmQvr6hNnUxAxg2oIFDrsIOhJFSHgFsoh0fQ/kWrDrEfJz dxZCWIBfaMaIstL7oo+BJ+cG5wC2LjKNlf4bAqxTQrF9hOfBGJPNzxE0Bv9kgnsx97 OAS4NaFi3Y90UNm3shbsWFWFOTK4lDWZwoTIfea6mS9XQ/kCbZluMYD5/tjLI4XDUk UsjY7OSTEvfw3Vap5DnhqjJzYrhpwwHu5/Cc79k6j5Tn+4Cz6qkFGGsLztAUZhQ0k8 u4GLWMkrDVh0CV8uD8vy5LKQF1Ort3+IJvuCE5eVd+/FhaVWkckiIIUvvznJZAUmmU uy9M8mt263uzA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Marussi , Sudeep Holla , Sasha Levin , linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 05/14] firmware: arm_scmi: Clear stale xfer->hdr.status Date: Tue, 24 Jan 2023 08:42:48 -0500 Message-Id: <20230124134257.637523-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230124134257.637523-1-sashal@kernel.org> References: <20230124134257.637523-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Cristian Marussi [ Upstream commit f6ca5059dc0d6608dc46070f48e396d611f240d6 ] Stale error status reported from a previous message transaction must be cleared before starting a new transaction to avoid being confusingly reported in the following SCMI message dump traces. Signed-off-by: Cristian Marussi Link: https://lore.kernel.org/r/20221222183823.518856-2-cristian.marussi@arm.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index a8ff4c9508b7..11842497b226 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -783,6 +783,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, xfer->hdr.protocol_id, xfer->hdr.seq, xfer->hdr.poll_completion); + /* Clear any stale status */ + xfer->hdr.status = SCMI_SUCCESS; xfer->state = SCMI_XFER_SENT_OK; /* * Even though spinlocking is not needed here since no race is possible -- 2.39.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 43386C38142 for ; Tue, 24 Jan 2023 13:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7motcQXANeKGFGfGZhnYc4LgDMZnG9+W/P3Dh627Crk=; b=mbrX5sIaT8pFZ2 ynait/RAA4YN1o2F13wUbhY4NYbHOiyzziH9yt+QD2WKuMzpw1d8w448h2FUaUZaFxnjh7Ig1tXNY aMvCOuM4c8Pm2s/r33nxaSN+4oHzUoyNAr0hxXKoeXL3rpx5rT49AcViMxJ7CeNjgz/O6d6U0PZ0a 8E5lHDvmGQUFLZvYKSZfxFEX9R5E2fRnx/q4yDoEKvrYu+3jf0otmSD0lxuQVCWzRmjECPTRjVOEW XcC3KNyfAU+MZKKzz9beUCtuV8pZ1vqv/2ByoXmDrs8JLx6hY4VxOKLuk4LvOEW0q5GoqN2uEFvm+ inEbCHTfrDbQasBxURLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKJjk-004691-Ns; Tue, 24 Jan 2023 13:53:22 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKJZy-0041XF-BY for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 13:43:15 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 993AC6117D; Tue, 24 Jan 2023 13:43:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2ABBC433B4; Tue, 24 Jan 2023 13:43:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674567793; bh=Fr8ngUSDZFbNweZe4Xpvn5UQljHV0Y4OKofXPoxRvOc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WqYUKWCdBVY8caoz5m/GmQvr6hNnUxAxg2oIFDrsIOhJFSHgFsoh0fQ/kWrDrEfJz dxZCWIBfaMaIstL7oo+BJ+cG5wC2LjKNlf4bAqxTQrF9hOfBGJPNzxE0Bv9kgnsx97 OAS4NaFi3Y90UNm3shbsWFWFOTK4lDWZwoTIfea6mS9XQ/kCbZluMYD5/tjLI4XDUk UsjY7OSTEvfw3Vap5DnhqjJzYrhpwwHu5/Cc79k6j5Tn+4Cz6qkFGGsLztAUZhQ0k8 u4GLWMkrDVh0CV8uD8vy5LKQF1Ort3+IJvuCE5eVd+/FhaVWkckiIIUvvznJZAUmmU uy9M8mt263uzA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Cristian Marussi , Sudeep Holla , Sasha Levin , linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 5.15 05/14] firmware: arm_scmi: Clear stale xfer->hdr.status Date: Tue, 24 Jan 2023 08:42:48 -0500 Message-Id: <20230124134257.637523-5-sashal@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230124134257.637523-1-sashal@kernel.org> References: <20230124134257.637523-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_054314_501387_C543797A X-CRM114-Status: GOOD ( 11.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Cristian Marussi [ Upstream commit f6ca5059dc0d6608dc46070f48e396d611f240d6 ] Stale error status reported from a previous message transaction must be cleared before starting a new transaction to avoid being confusingly reported in the following SCMI message dump traces. Signed-off-by: Cristian Marussi Link: https://lore.kernel.org/r/20221222183823.518856-2-cristian.marussi@arm.com Signed-off-by: Sudeep Holla Signed-off-by: Sasha Levin --- drivers/firmware/arm_scmi/driver.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c index a8ff4c9508b7..11842497b226 100644 --- a/drivers/firmware/arm_scmi/driver.c +++ b/drivers/firmware/arm_scmi/driver.c @@ -783,6 +783,8 @@ static int do_xfer(const struct scmi_protocol_handle *ph, xfer->hdr.protocol_id, xfer->hdr.seq, xfer->hdr.poll_completion); + /* Clear any stale status */ + xfer->hdr.status = SCMI_SUCCESS; xfer->state = SCMI_XFER_SENT_OK; /* * Even though spinlocking is not needed here since no race is possible -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel