From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A816C54EAA for ; Tue, 24 Jan 2023 14:16:27 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A369A4F; Tue, 24 Jan 2023 15:15:34 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A369A4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1674569784; bh=wncoAzyXG5qsMcp0PRhq+OyH4q+2zPPWC1JALwXFRUY=; h=Date:From:To:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=h6q8Np+OXuGza4f26cD6HhC6P3UEk5joU6o44uTDPTFFAsvJztAJSGJUwzF6rb7cn x8OLD2CSrzhL8r5GyWdpnan/ABn6TRcAVrxehiCvA9XB6N+UHo/DIHl1TLo166YdHb 5431hUYuWquuup12d2W/MfWbB+s2ggGw4L+dGjcU= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 802DCF8025D; Tue, 24 Jan 2023 15:15:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 98E9AF800FB; Tue, 24 Jan 2023 15:15:30 +0100 (CET) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 4C856F800FB for ; Tue, 24 Jan 2023 15:15:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 4C856F800FB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=l286gH4z Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 42D451BF207; Tue, 24 Jan 2023 14:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674569720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIw7NLrNROmQKNYPnuHqk2CqEst9nY4HbXU+KKl/pwM=; b=l286gH4zaStuaORA777qpXwbAcZhj+YncUk7uAzqZWieWArt4tThJzZODVGh3YOrFbJHtU m8cKCADL7W5gTqH9C4sVG9v10R83cBxOoitdOMZmEMoIL3wjgzIRy0QYHkbhsJWb0M0q99 DSGZNYvWKavYM1d3HCPODu3BTzKd25pk8CS3NSrusau5hMrD7nXly7YbUmg2k2VKrKmcnT SSI1M6d7PAkbbHtw+r41Jpo+T68ejoqYgqa4ScFyV9VHcOP2NXTAOmbhMvzAeJyPxkVLqr xgz62FwAENgzCQVsiux7WoHiKL3FWptBkgnR5k1Toe7gRkcSgk14Mdyqzkmbsw== Date: Tue, 24 Jan 2023 15:15:14 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124151514.58d77765@bootlin.com> In-Reply-To: <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> <20230124122347.1a531d0f@bootlin.com> <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Michael Ellerman , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Christophe Leroy , Krzysztof Kozlowski , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Tue, 24 Jan 2023 13:24:48 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 12:23, Herve Codina wrote: > > On Tue, 24 Jan 2023 11:02:52 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 24/01/2023 10:42, Herve Codina wrote: =20 > >>> Hi Krzysztof, > >>> > >>> On Tue, 17 Jan 2023 12:31:09 +0100 > >>> Krzysztof Kozlowski wrote: > >>> =20 > >>>> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>>>> Add support for the QMC (QUICC Multichannel Controller) > >>>>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>>>> > >>>>> Signed-off-by: Herve Codina > >>>>> --- > >>>>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++= ++++ > >>>>> 1 file changed, 164 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_q= e/fsl,qmc.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,q= mc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..3ec52f1635c8 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> @@ -0,0 +1,164 @@ > >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>> +%YAML 1.2 > >>>>> +--- > >>>>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>> + > >>>>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>>>> + > >>>>> +maintainers: > >>>>> + - Herve Codina > >>>>> + > >>>>> +description: | > >>>>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channe= ls within > >>>>> + one serial controller using the same TDM physical interface rout= ed from > >>>>> + TSA. > >>>>> + > >>>>> +properties: > >>>>> + compatible: > >>>>> + items: > >>>>> + - enum: > >>>>> + - fsl,mpc885-scc-qmc > >>>>> + - fsl,mpc866-scc-qmc > >>>>> + - const: fsl,cpm1-scc-qmc > >>>>> + > >>>>> + reg: > >>>>> + items: > >>>>> + - description: SCC (Serial communication controller) registe= r base > >>>>> + - description: SCC parameter ram base > >>>>> + - description: Dual port ram base > >>>>> + > >>>>> + reg-names: > >>>>> + items: > >>>>> + - const: scc_regs > >>>>> + - const: scc_pram > >>>>> + - const: dpram > >>>>> + > >>>>> + interrupts: > >>>>> + maxItems: 1 > >>>>> + description: SCC interrupt line in the CPM interrupt controller > >>>>> + > >>>>> + fsl,tsa: > >>>>> + $ref: /schemas/types.yaml#/definitions/phandle > >>>>> + description: phandle to the TSA > >>>>> + > >>>>> + fsl,tsa-cell-id: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + enum: [1, 2, 3] > >>>>> + description: | > >>>>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>>>> + - 1: SCC2 > >>>>> + - 2: SCC3 > >>>>> + - 3: SCC4 =20 > >>>> > >>>> Is this used as argument to tsa? If so, this should be part of fsl,t= sa > >>>> property, just like we do for all syscon-like phandles. =20 > >>> > >>> Yes, indeed. > >>> I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle= /number > >>> pair (the phandle to TSA node and the TSA cell id to use) =20 > >> > >> Move to fsl,tsa, not from. =20 > >=20 > > Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: > > fsl,tsa-cell: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > items: > > - items: > > - description: phandle to TSA node > > - enum: [1, 2, 3] > > description: | > > TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these valu= es) > > - 1: SCC2 > > - 2: SCC3 > > - 3: SCC4 > > description: > > Should be a phandle/number pair. The phandle to TSA node and the = TSA > > cell ID to use. > >=20 > > Is that what you were thinking about ? =20 >=20 > Yes, except again, so third time, why calling this "cell"? Move it to > fsl,tsa. >=20 Why calling this "cell" ? Just because we reference a "cell" using the TSA cell ID inside TSA and not the TSA itself. Maybe the problem is the term "cell" as it is not the DT definition of "cell" but the source/destination of the TSA routing. TSA can route data from/to some "serial controller". These serial controllers are : - SCC (Serial Communication Controller) - SMC (Serial Management Controller) - UCC (Unified Communication Controller) Only SCCs are handled here. Maybe the term "serial" makes more sense which will lead to fsl,tsa-serial =3D <&tsa, SCC4>; Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 716A8C38142 for ; Tue, 24 Jan 2023 14:16:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P1TY46jM6z3cdQ for ; Wed, 25 Jan 2023 01:16:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=l286gH4z; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=bootlin.com (client-ip=2001:4b98:dc4:8::228; helo=relay8-d.mail.gandi.net; envelope-from=herve.codina@bootlin.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.a=rsa-sha256 header.s=gm1 header.b=l286gH4z; dkim-atps=neutral Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P1TX11frTz2yNX for ; Wed, 25 Jan 2023 01:15:27 +1100 (AEDT) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 42D451BF207; Tue, 24 Jan 2023 14:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674569720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIw7NLrNROmQKNYPnuHqk2CqEst9nY4HbXU+KKl/pwM=; b=l286gH4zaStuaORA777qpXwbAcZhj+YncUk7uAzqZWieWArt4tThJzZODVGh3YOrFbJHtU m8cKCADL7W5gTqH9C4sVG9v10R83cBxOoitdOMZmEMoIL3wjgzIRy0QYHkbhsJWb0M0q99 DSGZNYvWKavYM1d3HCPODu3BTzKd25pk8CS3NSrusau5hMrD7nXly7YbUmg2k2VKrKmcnT SSI1M6d7PAkbbHtw+r41Jpo+T68ejoqYgqa4ScFyV9VHcOP2NXTAOmbhMvzAeJyPxkVLqr xgz62FwAENgzCQVsiux7WoHiKL3FWptBkgnR5k1Toe7gRkcSgk14Mdyqzkmbsw== Date: Tue, 24 Jan 2023 15:15:14 +0100 From: Herve Codina To: Krzysztof Kozlowski Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124151514.58d77765@bootlin.com> In-Reply-To: <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> <20230124122347.1a531d0f@bootlin.com> <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Fabio Estevam , linux-kernel@vger.kernel.org, Thomas Petazzoni , Xiubo Li , Takashi Iwai , Nicholas Piggin , Liam Girdwood , Rob Herring , Li Yang , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, Mark Brown , Krzysztof Kozlowski , Jaroslav Kysela , Shengjiu Wang , linux-arm-kernel@lists.infradead.org, Qiang Zhao Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Tue, 24 Jan 2023 13:24:48 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 12:23, Herve Codina wrote: > > On Tue, 24 Jan 2023 11:02:52 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 24/01/2023 10:42, Herve Codina wrote: =20 > >>> Hi Krzysztof, > >>> > >>> On Tue, 17 Jan 2023 12:31:09 +0100 > >>> Krzysztof Kozlowski wrote: > >>> =20 > >>>> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>>>> Add support for the QMC (QUICC Multichannel Controller) > >>>>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>>>> > >>>>> Signed-off-by: Herve Codina > >>>>> --- > >>>>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++= ++++ > >>>>> 1 file changed, 164 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_q= e/fsl,qmc.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,q= mc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..3ec52f1635c8 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> @@ -0,0 +1,164 @@ > >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>> +%YAML 1.2 > >>>>> +--- > >>>>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>> + > >>>>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>>>> + > >>>>> +maintainers: > >>>>> + - Herve Codina > >>>>> + > >>>>> +description: | > >>>>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channe= ls within > >>>>> + one serial controller using the same TDM physical interface rout= ed from > >>>>> + TSA. > >>>>> + > >>>>> +properties: > >>>>> + compatible: > >>>>> + items: > >>>>> + - enum: > >>>>> + - fsl,mpc885-scc-qmc > >>>>> + - fsl,mpc866-scc-qmc > >>>>> + - const: fsl,cpm1-scc-qmc > >>>>> + > >>>>> + reg: > >>>>> + items: > >>>>> + - description: SCC (Serial communication controller) registe= r base > >>>>> + - description: SCC parameter ram base > >>>>> + - description: Dual port ram base > >>>>> + > >>>>> + reg-names: > >>>>> + items: > >>>>> + - const: scc_regs > >>>>> + - const: scc_pram > >>>>> + - const: dpram > >>>>> + > >>>>> + interrupts: > >>>>> + maxItems: 1 > >>>>> + description: SCC interrupt line in the CPM interrupt controller > >>>>> + > >>>>> + fsl,tsa: > >>>>> + $ref: /schemas/types.yaml#/definitions/phandle > >>>>> + description: phandle to the TSA > >>>>> + > >>>>> + fsl,tsa-cell-id: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + enum: [1, 2, 3] > >>>>> + description: | > >>>>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>>>> + - 1: SCC2 > >>>>> + - 2: SCC3 > >>>>> + - 3: SCC4 =20 > >>>> > >>>> Is this used as argument to tsa? If so, this should be part of fsl,t= sa > >>>> property, just like we do for all syscon-like phandles. =20 > >>> > >>> Yes, indeed. > >>> I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle= /number > >>> pair (the phandle to TSA node and the TSA cell id to use) =20 > >> > >> Move to fsl,tsa, not from. =20 > >=20 > > Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: > > fsl,tsa-cell: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > items: > > - items: > > - description: phandle to TSA node > > - enum: [1, 2, 3] > > description: | > > TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these valu= es) > > - 1: SCC2 > > - 2: SCC3 > > - 3: SCC4 > > description: > > Should be a phandle/number pair. The phandle to TSA node and the = TSA > > cell ID to use. > >=20 > > Is that what you were thinking about ? =20 >=20 > Yes, except again, so third time, why calling this "cell"? Move it to > fsl,tsa. >=20 Why calling this "cell" ? Just because we reference a "cell" using the TSA cell ID inside TSA and not the TSA itself. Maybe the problem is the term "cell" as it is not the DT definition of "cell" but the source/destination of the TSA routing. TSA can route data from/to some "serial controller". These serial controllers are : - SCC (Serial Communication Controller) - SMC (Serial Management Controller) - UCC (Unified Communication Controller) Only SCCs are handled here. Maybe the term "serial" makes more sense which will lead to fsl,tsa-serial =3D <&tsa, SCC4>; Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76E19C38142 for ; Tue, 24 Jan 2023 14:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0nKzR92YBvTavj1i6nFhbMKlBylHyMzLLKMMCGP9WUI=; b=qhBXGLUBHdSG31 av70n2D6P46XerD6W6zoIcUwYK8NUAkuG5DW4hFrNj/OezccE/DhhJH+05ed0CKMqVgsYYdP7AIvo RfpqZodjIZiNIa7MynobIxNQCcCJAz0VRLxfQVR8sPvaIJoR5djpThGVg4u9obQI3l3ILVm8jA+sG GXeF7cAKInAKUyOfT2x7372gA0C6viGqbViOifmvQ6+ewhkPNnMOVOJxJ7p28JXEez8XwRrqNc2ra 17Fyd+kOlrrMQpbl9RZCE29un2aHKXTH7Vr0buHDel2zib01kIX0QckEbsukjGgRhtG0Jmfw49jEj oiQQ/QlP9IX9Ug9x51ow==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKK5E-004G2l-KM; Tue, 24 Jan 2023 14:15:33 +0000 Received: from relay8-d.mail.gandi.net ([217.70.183.201]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKK57-004FzN-Up for linux-arm-kernel@lists.infradead.org; Tue, 24 Jan 2023 14:15:29 +0000 Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 42D451BF207; Tue, 24 Jan 2023 14:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674569720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIw7NLrNROmQKNYPnuHqk2CqEst9nY4HbXU+KKl/pwM=; b=l286gH4zaStuaORA777qpXwbAcZhj+YncUk7uAzqZWieWArt4tThJzZODVGh3YOrFbJHtU m8cKCADL7W5gTqH9C4sVG9v10R83cBxOoitdOMZmEMoIL3wjgzIRy0QYHkbhsJWb0M0q99 DSGZNYvWKavYM1d3HCPODu3BTzKd25pk8CS3NSrusau5hMrD7nXly7YbUmg2k2VKrKmcnT SSI1M6d7PAkbbHtw+r41Jpo+T68ejoqYgqa4ScFyV9VHcOP2NXTAOmbhMvzAeJyPxkVLqr xgz62FwAENgzCQVsiux7WoHiKL3FWptBkgnR5k1Toe7gRkcSgk14Mdyqzkmbsw== Date: Tue, 24 Jan 2023 15:15:14 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124151514.58d77765@bootlin.com> In-Reply-To: <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> <20230124122347.1a531d0f@bootlin.com> <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230124_061526_441420_40661C2D X-CRM114-Status: GOOD ( 26.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyNCBKYW4gMjAyMyAxMzoyNDo0OCArMDEwMApLcnp5c3p0b2YgS296bG93c2tpIDxr cnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgoKPiBPbiAyNC8wMS8yMDIzIDEy OjIzLCBIZXJ2ZSBDb2RpbmEgd3JvdGU6Cj4gPiBPbiBUdWUsIDI0IEphbiAyMDIzIDExOjAyOjUy ICswMTAwCj4gPiBLcnp5c3p0b2YgS296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFy by5vcmc+IHdyb3RlOgo+ID4gICAKPiA+PiBPbiAyNC8wMS8yMDIzIDEwOjQyLCBIZXJ2ZSBDb2Rp bmEgd3JvdGU6ICAKPiA+Pj4gSGkgS3J6eXN6dG9mLAo+ID4+Pgo+ID4+PiBPbiBUdWUsIDE3IEph biAyMDIzIDEyOjMxOjA5ICswMTAwCj4gPj4+IEtyenlzenRvZiBLb3psb3dza2kgPGtyenlzenRv Zi5rb3psb3dza2lAbGluYXJvLm9yZz4gd3JvdGU6Cj4gPj4+ICAgICAKPiA+Pj4+IE9uIDEzLzAx LzIwMjMgMTE6MzcsIEhlcnZlIENvZGluYSB3cm90ZTogICAgCj4gPj4+Pj4gQWRkIHN1cHBvcnQg Zm9yIHRoZSBRTUMgKFFVSUNDIE11bHRpY2hhbm5lbCBDb250cm9sbGVyKQo+ID4+Pj4+IGF2YWls YWJsZSBpbiBzb21lIFBvd2VyUVVJQ0MgU29DIHN1Y2ggYXMgTVBDODg1IG9yIE1QQzg2Ni4KPiA+ Pj4+Pgo+ID4+Pj4+IFNpZ25lZC1vZmYtYnk6IEhlcnZlIENvZGluYSA8aGVydmUuY29kaW5hQGJv b3RsaW4uY29tPgo+ID4+Pj4+IC0tLQo+ID4+Pj4+ICAuLi4vYmluZGluZ3Mvc29jL2ZzbC9jcG1f cWUvZnNsLHFtYy55YW1sICAgICAgfCAxNjQgKysrKysrKysrKysrKysrKysrCj4gPj4+Pj4gIDEg ZmlsZSBjaGFuZ2VkLCAxNjQgaW5zZXJ0aW9ucygrKQo+ID4+Pj4+ICBjcmVhdGUgbW9kZSAxMDA2 NDQgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3NvYy9mc2wvY3BtX3FlL2ZzbCxx bWMueWFtbAo+ID4+Pj4+Cj4gPj4+Pj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNl dHJlZS9iaW5kaW5ncy9zb2MvZnNsL2NwbV9xZS9mc2wscW1jLnlhbWwgYi9Eb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHFtYy55YW1sCj4gPj4+Pj4g bmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+Pj4+PiBpbmRleCAwMDAwMDAwMDAwMDAuLjNlYzUyZjE2 MzVjOAo+ID4+Pj4+IC0tLSAvZGV2L251bGwKPiA+Pj4+PiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3Mvc29jL2ZzbC9jcG1fcWUvZnNsLHFtYy55YW1sCj4gPj4+Pj4gQEAg LTAsMCArMSwxNjQgQEAKPiA+Pj4+PiArIyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogKEdQTC0y LjAtb25seSBPUiBCU0QtMi1DbGF1c2UpCj4gPj4+Pj4gKyVZQU1MIDEuMgo+ID4+Pj4+ICstLS0K PiA+Pj4+PiArJGlkOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvc2NoZW1hcy9zb2MvZnNsL2NwbV9x ZS9mc2wscW1jLnlhbWwjCj4gPj4+Pj4gKyRzY2hlbWE6IGh0dHA6Ly9kZXZpY2V0cmVlLm9yZy9t ZXRhLXNjaGVtYXMvY29yZS55YW1sIwo+ID4+Pj4+ICsKPiA+Pj4+PiArdGl0bGU6IFBvd2VyUVVJ Q0MgQ1BNIFFVSUNDIE11bHRpY2hhbm5lbCBDb250cm9sbGVyIChRTUMpCj4gPj4+Pj4gKwo+ID4+ Pj4+ICttYWludGFpbmVyczoKPiA+Pj4+PiArICAtIEhlcnZlIENvZGluYSA8aGVydmUuY29kaW5h QGJvb3RsaW4uY29tPgo+ID4+Pj4+ICsKPiA+Pj4+PiArZGVzY3JpcHRpb246IHwKPiA+Pj4+PiAr ICBUaGUgUU1DIChRVUlDQyBNdWx0aWNoYW5uZWwgQ29udHJvbGxlcikgZW11bGF0ZXMgdXAgdG8g NjQgY2hhbm5lbHMgd2l0aGluCj4gPj4+Pj4gKyAgb25lIHNlcmlhbCBjb250cm9sbGVyIHVzaW5n IHRoZSBzYW1lIFRETSBwaHlzaWNhbCBpbnRlcmZhY2Ugcm91dGVkIGZyb20KPiA+Pj4+PiArICBU U0EuCj4gPj4+Pj4gKwo+ID4+Pj4+ICtwcm9wZXJ0aWVzOgo+ID4+Pj4+ICsgIGNvbXBhdGlibGU6 Cj4gPj4+Pj4gKyAgICBpdGVtczoKPiA+Pj4+PiArICAgICAgLSBlbnVtOgo+ID4+Pj4+ICsgICAg ICAgICAgLSBmc2wsbXBjODg1LXNjYy1xbWMKPiA+Pj4+PiArICAgICAgICAgIC0gZnNsLG1wYzg2 Ni1zY2MtcW1jCj4gPj4+Pj4gKyAgICAgIC0gY29uc3Q6IGZzbCxjcG0xLXNjYy1xbWMKPiA+Pj4+ PiArCj4gPj4+Pj4gKyAgcmVnOgo+ID4+Pj4+ICsgICAgaXRlbXM6Cj4gPj4+Pj4gKyAgICAgIC0g ZGVzY3JpcHRpb246IFNDQyAoU2VyaWFsIGNvbW11bmljYXRpb24gY29udHJvbGxlcikgcmVnaXN0 ZXIgYmFzZQo+ID4+Pj4+ICsgICAgICAtIGRlc2NyaXB0aW9uOiBTQ0MgcGFyYW1ldGVyIHJhbSBi YXNlCj4gPj4+Pj4gKyAgICAgIC0gZGVzY3JpcHRpb246IER1YWwgcG9ydCByYW0gYmFzZQo+ID4+ Pj4+ICsKPiA+Pj4+PiArICByZWctbmFtZXM6Cj4gPj4+Pj4gKyAgICBpdGVtczoKPiA+Pj4+PiAr ICAgICAgLSBjb25zdDogc2NjX3JlZ3MKPiA+Pj4+PiArICAgICAgLSBjb25zdDogc2NjX3ByYW0K PiA+Pj4+PiArICAgICAgLSBjb25zdDogZHByYW0KPiA+Pj4+PiArCj4gPj4+Pj4gKyAgaW50ZXJy dXB0czoKPiA+Pj4+PiArICAgIG1heEl0ZW1zOiAxCj4gPj4+Pj4gKyAgICBkZXNjcmlwdGlvbjog U0NDIGludGVycnVwdCBsaW5lIGluIHRoZSBDUE0gaW50ZXJydXB0IGNvbnRyb2xsZXIKPiA+Pj4+ PiArCj4gPj4+Pj4gKyAgZnNsLHRzYToKPiA+Pj4+PiArICAgICRyZWY6IC9zY2hlbWFzL3R5cGVz LnlhbWwjL2RlZmluaXRpb25zL3BoYW5kbGUKPiA+Pj4+PiArICAgIGRlc2NyaXB0aW9uOiBwaGFu ZGxlIHRvIHRoZSBUU0EKPiA+Pj4+PiArCj4gPj4+Pj4gKyAgZnNsLHRzYS1jZWxsLWlkOgo+ID4+ Pj4+ICsgICAgJHJlZjogL3NjaGVtYXMvdHlwZXMueWFtbCMvZGVmaW5pdGlvbnMvdWludDMyCj4g Pj4+Pj4gKyAgICBlbnVtOiBbMSwgMiwgM10KPiA+Pj4+PiArICAgIGRlc2NyaXB0aW9uOiB8Cj4g Pj4+Pj4gKyAgICAgIFRTQSBjZWxsIElEIChkdC1iaW5kaW5ncy9zb2MvZnNsLHRzYS5oIGRlZmlu ZXMgdGhlc2UgdmFsdWVzKQo+ID4+Pj4+ICsgICAgICAgLSAxOiBTQ0MyCj4gPj4+Pj4gKyAgICAg ICAtIDI6IFNDQzMKPiA+Pj4+PiArICAgICAgIC0gMzogU0NDNCAgICAgIAo+ID4+Pj4KPiA+Pj4+ IElzIHRoaXMgdXNlZCBhcyBhcmd1bWVudCB0byB0c2E/IElmIHNvLCB0aGlzIHNob3VsZCBiZSBw YXJ0IG9mIGZzbCx0c2EKPiA+Pj4+IHByb3BlcnR5LCBqdXN0IGxpa2Ugd2UgZG8gZm9yIGFsbCBz eXNjb24tbGlrZSBwaGFuZGxlcy4gICAgCj4gPj4+Cj4gPj4+IFllcywgaW5kZWVkLgo+ID4+PiBJ IHdpbGwgbW92ZSAnZnNsLHRzYScgdG8gJ2ZzbCx0c2EtY2VsbCcgd2l0aCAnZnNsLHRzYS1jZWxs JyBhIHBoYW5kbGUvbnVtYmVyCj4gPj4+IHBhaXIgKHRoZSBwaGFuZGxlIHRvIFRTQSBub2RlIGFu ZCB0aGUgVFNBIGNlbGwgaWQgdG8gdXNlKSAgICAKPiA+Pgo+ID4+IE1vdmUgdG8gZnNsLHRzYSwg bm90IGZyb20uICAKPiA+IAo+ID4gV2VsbCwgSSBwbGFuIHRvIHJlbW92ZSBib3RoIGZzbCx0c2Eg YW5kIGZzbCx0c2EtY2VsbC1pZCBhbmQgdXNlIHRoaXM6Cj4gPiAgIGZzbCx0c2EtY2VsbDoKPiA+ ICAgICAkcmVmOiAvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlLWFycmF5 Cj4gPiAgICAgaXRlbXM6Cj4gPiAgICAgICAtIGl0ZW1zOgo+ID4gICAgICAgICAgIC0gZGVzY3Jp cHRpb246IHBoYW5kbGUgdG8gVFNBIG5vZGUKPiA+ICAgICAgICAgICAtIGVudW06IFsxLCAyLCAz XQo+ID4gICAgICAgICAgICAgZGVzY3JpcHRpb246IHwKPiA+ICAgICAgICAgICAgICAgVFNBIGNl bGwgSUQgKGR0LWJpbmRpbmdzL3NvYy9mc2wsdHNhLmggZGVmaW5lcyB0aGVzZSB2YWx1ZXMpCj4g PiAgICAgICAgICAgICAgICAtIDE6IFNDQzIKPiA+ICAgICAgICAgICAgICAgIC0gMjogU0NDMwo+ ID4gICAgICAgICAgICAgICAgLSAzOiBTQ0M0Cj4gPiAgICAgZGVzY3JpcHRpb246Cj4gPiAgICAg ICBTaG91bGQgYmUgYSBwaGFuZGxlL251bWJlciBwYWlyLiBUaGUgcGhhbmRsZSB0byBUU0Egbm9k ZSBhbmQgdGhlIFRTQQo+ID4gICAgICAgY2VsbCBJRCB0byB1c2UuCj4gPiAKPiA+IElzIHRoYXQg d2hhdCB5b3Ugd2VyZSB0aGlua2luZyBhYm91dCA/ICAKPiAKPiBZZXMsIGV4Y2VwdCBhZ2Fpbiwg c28gdGhpcmQgdGltZSwgd2h5IGNhbGxpbmcgdGhpcyAiY2VsbCI/IE1vdmUgaXQgdG8KPiBmc2ws dHNhLgo+IAoKV2h5IGNhbGxpbmcgdGhpcyAiY2VsbCIgPyBKdXN0IGJlY2F1c2Ugd2UgcmVmZXJl bmNlIGEgImNlbGwiIHVzaW5nIHRoZSBUU0EKY2VsbCBJRCBpbnNpZGUgVFNBIGFuZCBub3QgdGhl IFRTQSBpdHNlbGYuCgpNYXliZSB0aGUgcHJvYmxlbSBpcyB0aGUgdGVybSAiY2VsbCIgYXMgaXQg aXMgbm90IHRoZSBEVCBkZWZpbml0aW9uIG9mCiJjZWxsIiBidXQgdGhlIHNvdXJjZS9kZXN0aW5h dGlvbiBvZiB0aGUgVFNBIHJvdXRpbmcuCgpUU0EgY2FuIHJvdXRlIGRhdGEgZnJvbS90byBzb21l ICJzZXJpYWwgY29udHJvbGxlciIuClRoZXNlIHNlcmlhbCBjb250cm9sbGVycyBhcmUgOgotIFND QyAoU2VyaWFsIENvbW11bmljYXRpb24gQ29udHJvbGxlcikKLSBTTUMgKFNlcmlhbCBNYW5hZ2Vt ZW50IENvbnRyb2xsZXIpCi0gVUNDIChVbmlmaWVkIENvbW11bmljYXRpb24gQ29udHJvbGxlcikK Ck9ubHkgU0NDcyBhcmUgaGFuZGxlZCBoZXJlLgoKTWF5YmUgdGhlIHRlcm0gInNlcmlhbCIgbWFr ZXMgbW9yZSBzZW5zZSB3aGljaCB3aWxsIGxlYWQgdG8KICBmc2wsdHNhLXNlcmlhbCA9IDwmdHNh LCBTQ0M0PjsKCkJlc3QgcmVnYXJkcywKSGVydsOpCgotLSAKSGVydsOpIENvZGluYSwgQm9vdGxp bgpFbWJlZGRlZCBMaW51eCBhbmQgS2VybmVsIGVuZ2luZWVyaW5nCmh0dHBzOi8vYm9vdGxpbi5j b20KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFy bS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA3DCC25B4E for ; Tue, 24 Jan 2023 14:15:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234008AbjAXOPj (ORCPT ); Tue, 24 Jan 2023 09:15:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234791AbjAXOPh (ORCPT ); Tue, 24 Jan 2023 09:15:37 -0500 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CD18474FB; Tue, 24 Jan 2023 06:15:21 -0800 (PST) Received: (Authenticated sender: herve.codina@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id 42D451BF207; Tue, 24 Jan 2023 14:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1674569720; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nIw7NLrNROmQKNYPnuHqk2CqEst9nY4HbXU+KKl/pwM=; b=l286gH4zaStuaORA777qpXwbAcZhj+YncUk7uAzqZWieWArt4tThJzZODVGh3YOrFbJHtU m8cKCADL7W5gTqH9C4sVG9v10R83cBxOoitdOMZmEMoIL3wjgzIRy0QYHkbhsJWb0M0q99 DSGZNYvWKavYM1d3HCPODu3BTzKd25pk8CS3NSrusau5hMrD7nXly7YbUmg2k2VKrKmcnT SSI1M6d7PAkbbHtw+r41Jpo+T68ejoqYgqa4ScFyV9VHcOP2NXTAOmbhMvzAeJyPxkVLqr xgz62FwAENgzCQVsiux7WoHiKL3FWptBkgnR5k1Toe7gRkcSgk14Mdyqzkmbsw== Date: Tue, 24 Jan 2023 15:15:14 +0100 From: Herve Codina To: Krzysztof Kozlowski Cc: Li Yang , Rob Herring , Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Christophe Leroy , Michael Ellerman , Nicholas Piggin , Qiang Zhao , Jaroslav Kysela , Takashi Iwai , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Thomas Petazzoni Subject: Re: [PATCH v3 05/10] dt-bindings: soc: fsl: cpm_qe: Add QMC controller Message-ID: <20230124151514.58d77765@bootlin.com> In-Reply-To: <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> References: <20230113103759.327698-1-herve.codina@bootlin.com> <20230113103759.327698-6-herve.codina@bootlin.com> <316ddb81-8d13-71dd-3396-412e31cfb880@linaro.org> <20230124104232.183cc9ff@bootlin.com> <37a95380-ee68-5c3a-3b96-48cc8b525f19@linaro.org> <20230124122347.1a531d0f@bootlin.com> <81f80190-a05c-5d0d-11b2-a80573b86e1c@linaro.org> Organization: Bootlin X-Mailer: Claws Mail 4.1.1 (GTK 3.24.36; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 24 Jan 2023 13:24:48 +0100 Krzysztof Kozlowski wrote: > On 24/01/2023 12:23, Herve Codina wrote: > > On Tue, 24 Jan 2023 11:02:52 +0100 > > Krzysztof Kozlowski wrote: > > =20 > >> On 24/01/2023 10:42, Herve Codina wrote: =20 > >>> Hi Krzysztof, > >>> > >>> On Tue, 17 Jan 2023 12:31:09 +0100 > >>> Krzysztof Kozlowski wrote: > >>> =20 > >>>> On 13/01/2023 11:37, Herve Codina wrote: =20 > >>>>> Add support for the QMC (QUICC Multichannel Controller) > >>>>> available in some PowerQUICC SoC such as MPC885 or MPC866. > >>>>> > >>>>> Signed-off-by: Herve Codina > >>>>> --- > >>>>> .../bindings/soc/fsl/cpm_qe/fsl,qmc.yaml | 164 ++++++++++++++= ++++ > >>>>> 1 file changed, 164 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/soc/fsl/cpm_q= e/fsl,qmc.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,q= mc.yaml b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..3ec52f1635c8 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/soc/fsl/cpm_qe/fsl,qmc.yaml > >>>>> @@ -0,0 +1,164 @@ > >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>> +%YAML 1.2 > >>>>> +--- > >>>>> +$id: http://devicetree.org/schemas/soc/fsl/cpm_qe/fsl,qmc.yaml# > >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>> + > >>>>> +title: PowerQUICC CPM QUICC Multichannel Controller (QMC) > >>>>> + > >>>>> +maintainers: > >>>>> + - Herve Codina > >>>>> + > >>>>> +description: | > >>>>> + The QMC (QUICC Multichannel Controller) emulates up to 64 channe= ls within > >>>>> + one serial controller using the same TDM physical interface rout= ed from > >>>>> + TSA. > >>>>> + > >>>>> +properties: > >>>>> + compatible: > >>>>> + items: > >>>>> + - enum: > >>>>> + - fsl,mpc885-scc-qmc > >>>>> + - fsl,mpc866-scc-qmc > >>>>> + - const: fsl,cpm1-scc-qmc > >>>>> + > >>>>> + reg: > >>>>> + items: > >>>>> + - description: SCC (Serial communication controller) registe= r base > >>>>> + - description: SCC parameter ram base > >>>>> + - description: Dual port ram base > >>>>> + > >>>>> + reg-names: > >>>>> + items: > >>>>> + - const: scc_regs > >>>>> + - const: scc_pram > >>>>> + - const: dpram > >>>>> + > >>>>> + interrupts: > >>>>> + maxItems: 1 > >>>>> + description: SCC interrupt line in the CPM interrupt controller > >>>>> + > >>>>> + fsl,tsa: > >>>>> + $ref: /schemas/types.yaml#/definitions/phandle > >>>>> + description: phandle to the TSA > >>>>> + > >>>>> + fsl,tsa-cell-id: > >>>>> + $ref: /schemas/types.yaml#/definitions/uint32 > >>>>> + enum: [1, 2, 3] > >>>>> + description: | > >>>>> + TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these values) > >>>>> + - 1: SCC2 > >>>>> + - 2: SCC3 > >>>>> + - 3: SCC4 =20 > >>>> > >>>> Is this used as argument to tsa? If so, this should be part of fsl,t= sa > >>>> property, just like we do for all syscon-like phandles. =20 > >>> > >>> Yes, indeed. > >>> I will move 'fsl,tsa' to 'fsl,tsa-cell' with 'fsl,tsa-cell' a phandle= /number > >>> pair (the phandle to TSA node and the TSA cell id to use) =20 > >> > >> Move to fsl,tsa, not from. =20 > >=20 > > Well, I plan to remove both fsl,tsa and fsl,tsa-cell-id and use this: > > fsl,tsa-cell: > > $ref: /schemas/types.yaml#/definitions/phandle-array > > items: > > - items: > > - description: phandle to TSA node > > - enum: [1, 2, 3] > > description: | > > TSA cell ID (dt-bindings/soc/fsl,tsa.h defines these valu= es) > > - 1: SCC2 > > - 2: SCC3 > > - 3: SCC4 > > description: > > Should be a phandle/number pair. The phandle to TSA node and the = TSA > > cell ID to use. > >=20 > > Is that what you were thinking about ? =20 >=20 > Yes, except again, so third time, why calling this "cell"? Move it to > fsl,tsa. >=20 Why calling this "cell" ? Just because we reference a "cell" using the TSA cell ID inside TSA and not the TSA itself. Maybe the problem is the term "cell" as it is not the DT definition of "cell" but the source/destination of the TSA routing. TSA can route data from/to some "serial controller". These serial controllers are : - SCC (Serial Communication Controller) - SMC (Serial Management Controller) - UCC (Unified Communication Controller) Only SCCs are handled here. Maybe the term "serial" makes more sense which will lead to fsl,tsa-serial =3D <&tsa, SCC4>; Best regards, Herv=C3=A9 --=20 Herv=C3=A9 Codina, Bootlin Embedded Linux and Kernel engineering https://bootlin.com