From: Jakub Kicinski <kuba@kernel.org>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
edumazet@google.com, pabeni@redhat.com
Subject: Re: [PATCH net-next RFC] net: introduce skb_poison_list and use in kfree_skb_list
Date: Tue, 24 Jan 2023 18:11:00 -0800 [thread overview]
Message-ID: <20230124181100.6aa0c669@kernel.org> (raw)
In-Reply-To: <167421519986.1321434.5887198904455029318.stgit@firesoul>
On Fri, 20 Jan 2023 12:46:39 +0100 Jesper Dangaard Brouer wrote:
> First user of skb_poison_list is in kfree_skb_list_reason, to catch bugs
> earlier like introduced in commit eedade12f4cb ("net: kfree_skb_list use
> kmem_cache_free_bulk").
>
> In case of a bug like mentioned commit we would have seen OOPS with:
> general protection fault, probably for non-canonical address 0xdead0000000000b1
> And content of one the registers e.g. R13: dead000000000041
>
> In this case skb->len is at offset 112 bytes (0x70) why fault happens at
> 0x41+0x70 = 0xB1
I like the idea, FWIW. I was gonna apply the RFC but looks like there
was a dependency on the fix, so better if you repost and bot gets to
chew on it.
prev parent reply other threads:[~2023-01-25 2:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 11:46 [PATCH net-next RFC] net: introduce skb_poison_list and use in kfree_skb_list Jesper Dangaard Brouer
2023-01-25 2:11 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124181100.6aa0c669@kernel.org \
--to=kuba@kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.