From: Jakub Kicinski <kuba@kernel.org>
To: m.chetan.kumar@linux.intel.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
loic.poulain@linaro.org, ilpo.jarvinen@linux.intel.com,
ricardo.martinez@linux.intel.com,
chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com,
edumazet@google.com, pabeni@redhat.com,
chandrashekar.devegowda@intel.com, linuxwwan@intel.com,
linuxwwan_5g@intel.com,
Mishra Soumya Prakash <soumya.prakash.mishra@intel.com>,
Jesse Brandeburg <jesse.brandeburg@intel.com>
Subject: Re: [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection
Date: Tue, 24 Jan 2023 20:53:56 -0800 [thread overview]
Message-ID: <20230124205356.2bd6683e@kernel.org> (raw)
In-Reply-To: <fc8bbb0b66a5ff3a489ea9857d79b374508090ef.1674307425.git.m.chetan.kumar@linux.intel.com>
On Sat, 21 Jan 2023 19:03:38 +0530 m.chetan.kumar@linux.intel.com wrote:
> 1> Driver Registers with Devlink framework.
> 2> Implements devlink ops flash_update callback that programs modem fw.
> 3> Creates region & snapshot required for device coredump log collection.
Sounds like these should be 3 patches?
> + devlink_params_register(dl_ctx, t7xx_devlink_params, ARRAY_SIZE(t7xx_devlink_params));
> + value.vbool = false;
> + devlink_param_driverinit_value_set(dl_ctx, T7XX_DEVLINK_PARAM_ID_FASTBOOT, value);
> + devlink_set_features(dl_ctx, DEVLINK_F_RELOAD);
> + devlink_register(dl_ctx);
Please take the devl_lock() explicitly and use the devl_
version of those calls.
next prev parent reply other threads:[~2023-01-25 4:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-21 13:32 [PATCH v5 net-next 0/5] net: wwan: t7xx: fw flashing & coredump support m.chetan.kumar
2023-01-21 13:32 ` [PATCH v5 net-next 1/5] net: wwan: t7xx: Add AP CLDMA m.chetan.kumar
2023-01-21 13:33 ` [PATCH v5 net-next 2/5] net: wwan: t7xx: Infrastructure for early port configuration m.chetan.kumar
2023-01-21 13:33 ` [PATCH v5 net-next 3/5] net: wwan: t7xx: PCIe reset rescan m.chetan.kumar
2023-01-25 4:45 ` Jakub Kicinski
2023-01-26 15:25 ` Bjorn Helgaas
2023-01-27 10:27 ` Kumar, M Chetan
2023-01-27 13:30 ` Bjorn Helgaas
2023-01-21 13:33 ` [PATCH v5 net-next 4/5] net: wwan: t7xx: Enable devlink based fw flashing and coredump collection m.chetan.kumar
2023-01-25 4:53 ` Jakub Kicinski [this message]
2023-01-25 10:37 ` Kumar, M Chetan
2023-01-21 13:33 ` [PATCH v5 net-next 5/5] net: wwan: t7xx: Devlink documentation m.chetan.kumar
2023-01-22 2:13 ` Bagas Sanjaya
2023-01-24 14:30 ` Kumar, M Chetan
2023-01-25 4:51 ` Jakub Kicinski
2023-01-25 10:33 ` Kumar, M Chetan
2023-01-25 11:34 ` Ilpo Järvinen
2023-01-25 18:08 ` Jakub Kicinski
2023-01-26 10:55 ` Kumar, M Chetan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230124205356.2bd6683e@kernel.org \
--to=kuba@kernel.org \
--cc=chandrashekar.devegowda@intel.com \
--cc=chiranjeevi.rapolu@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=haijun.liu@mediatek.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linuxwwan@intel.com \
--cc=linuxwwan_5g@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=soumya.prakash.mishra@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.