From: Kees Cook <keescook@chromium.org>
To: "Rafał Miłecki" <rafal@milecki.pl>
Cc: "Gustavo A. R. Silva" <gustavoars@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] nvmem: u-boot-env: replace zero-length array with flexible-array member
Date: Wed, 25 Jan 2023 12:27:44 -0800 [thread overview]
Message-ID: <202301251227.3A6AAC1B@keescook> (raw)
In-Reply-To: <494915c85c52e66aa83fce49556ccf3e@milecki.pl>
On Fri, Jan 13, 2023 at 07:41:02AM +0100, Rafał Miłecki wrote:
> On 2023-01-10 02:40, Gustavo A. R. Silva wrote:
> > Zero-length arrays are deprecated[1] and we are moving towards
> > adopting C99 flexible-array members instead. So, replace zero-length
> > array declaration in struct u_boot_env_image_broadcom with flex-array
> > member.
> >
> > This helps with the ongoing efforts to tighten the FORTIFY_SOURCE
> > routines on memcpy() and help us make progress towards globally
> > enabling -fstrict-flex-arrays=3 [2].
>
> I also handled this issue in my
> [PATCH V2 4/6] nvmem: u-boot-env: convert to layout driver
> https://lore.kernel.org/linux-arm-kernel/20230111073102.8147-4-zajec5@gmail.com/
Ah-ha, thanks! Looks good. :)
--
Kees Cook
prev parent reply other threads:[~2023-01-25 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 1:40 [PATCH][next] nvmem: u-boot-env: replace zero-length array with flexible-array member Gustavo A. R. Silva
2023-01-12 22:49 ` Kees Cook
2023-01-13 6:41 ` Rafał Miłecki
2023-01-25 20:27 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202301251227.3A6AAC1B@keescook \
--to=keescook@chromium.org \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.