From: David Teigland <teigland@sourceware.org>
To: lvm-devel@redhat.com
Subject: main - Revert "lvresize: enable crypt resizing with --force"
Date: Wed, 25 Jan 2023 16:13:22 +0000 (GMT) [thread overview]
Message-ID: <20230125161322.4F9023858D39@sourceware.org> (raw)
Gitweb: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=8adfcddc35be16ac1d1a00a169ec89a7f12d69af
Commit: 8adfcddc35be16ac1d1a00a169ec89a7f12d69af
Parent: 49c650423a17197c66b1c839a0274db8fba9a7d9
Author: David Teigland <teigland@redhat.com>
AuthorDate: Wed Jan 25 09:30:05 2023 -0600
Committer: David Teigland <teigland@redhat.com>
CommitterDate: Wed Jan 25 10:10:57 2023 -0600
Revert "lvresize: enable crypt resizing with --force"
It looks like force was not being used to enable crypt resize,
but rather to force an inconsistency between LV and crypt
sizes, so this is either not needed or force in this case
should have some other meaning.
This reverts commit ed808a9b548ca59221d512bfb7ae581e8367fe50.
---
lib/metadata/lv_manip.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/lib/metadata/lv_manip.c b/lib/metadata/lv_manip.c
index f06b08254..cfb118f11 100644
--- a/lib/metadata/lv_manip.c
+++ b/lib/metadata/lv_manip.c
@@ -6417,13 +6417,9 @@ static int _fs_reduce(struct cmd_context *cmd, struct logical_volume *lv,
goto out;
}
if (!strcmp(lp->fsopt, "checksize")) {
- if (!lp->force) {
- log_error("crypt reduce is required (see --resizefs or cryptsetup resize.)");
- ret = 0;
- goto out;
- }
- /* This is only because it has been allowed in the past. */
- log_print("Forcing cryptsetup resize (--resizefs preferred.)");
+ log_error("crypt reduce is required (see --resizefs or cryptsetup resize.)");
+ ret = 0;
+ goto out;
}
if (test_mode()) {
ret = 1;
reply other threads:[~2023-01-25 16:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230125161322.4F9023858D39@sourceware.org \
--to=teigland@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.