From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8841C05027 for ; Thu, 26 Jan 2023 14:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230360AbjAZOrc (ORCPT ); Thu, 26 Jan 2023 09:47:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54494 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230482AbjAZOrc (ORCPT ); Thu, 26 Jan 2023 09:47:32 -0500 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF336A31F for ; Thu, 26 Jan 2023 06:47:23 -0800 (PST) Received: by mail-pl1-x630.google.com with SMTP id be8so2005355plb.7 for ; Thu, 26 Jan 2023 06:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=lMOybId87xz2ZyOHJXou8xZjJy2Gienx1uyxdWQ0pNTgLk+M2+B9DN4O5BJIr5Pji+ XW6Xp6rjEnaG7YFn/hj/Oh93k0G7s506IcxiYqxAg4dAN2bBej0MOTA+2h77TSGv5DcS XBUawWXccLWOHRppDnOqp1h5c8rU/sGkxnT8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=hgdvB6ZmOjsyLQOP0N13ERc0bxahGLYHiUd2DJtHQdjTQHMwdssdTkK0RBGcwmqCDy iQNlo0UoDzmxOwclj8v3DuuwBg1VSxShzEubLpCVRWIp5XZWB5Ojw4KrtZhDKw2ixZNm 1kGhoL23zeo/Ciug2Ma961ziqZsCjCDAaOO2ocVOXXlxCTAHIf5jQug99sSU34JBEqsB OQXcFvWfkFw0C+4KKoXPl+Yrf7E541B0GQigvrRIU0OY3SI8uruuYU/NUfexzYG9cxZp w9KjPANctPEcKd0+MMZpixR9jRgKjOmd+OI40oirAPcpZgxxmshZBx3Fe0Pv+aQ3Y4zz OhiA== X-Gm-Message-State: AFqh2kope224jmBTRhnYCORJF1PHAGwyUb4EVZCfWQ+iP47ZlBdX2WLX Wsugtwyw9fKwaEjQ/2XEEXGH8qg7pbxHSUOzpbI= X-Google-Smtp-Source: AMrXdXsQ9iGnU7hZJbbFFwwp29B7k3r1WFplJKzJsKhS/P+qYxclQigi3wIX8J/engpZhelsyuPTsg== X-Received: by 2002:a05:6a21:3381:b0:af:6cc0:5b3d with SMTP id yy1-20020a056a21338100b000af6cc05b3dmr50400165pzb.7.1674744442878; Thu, 26 Jan 2023 06:47:22 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:47:22 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v12 13/18] drm: exynos: dsi: Add host helper for te_irq_handler Date: Thu, 26 Jan 2023 20:14:22 +0530 Message-Id: <20230126144427.607098-14-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org IRQ handler for te-gpio seems to be common across DSIM host. However, Exynos is handling this via CRTC drivers but there is no clear evidence on how the same has been handled in i.MX8MM. Keeping the handler as-it-is can be a viable option but adding DSIM bridge core in upcoming patches is not possible to call Exynos CRTC handler as DSIM bridge has to be common across DRM bridge core instead of platform specific DRM drivers like Exynos here. So, this patch handles the handler via platform host helper, so-that handling platform specific hook across Exynos and generic can be reasonable till it makes it generic across all platforms. Signed-off-by: Jagan Teki --- Changes for v12: - updated patch - suggested by Marek V Changes for v11: - none Changes for v10: - split from previous series patch "drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge" drivers/gpu/drm/exynos/exynos_drm_dsi.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 488fae218205..1d95909391e2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -325,6 +325,7 @@ struct exynos_dsim_host_ops { void (*unregister_host)(struct exynos_dsi *dsim); int (*attach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device); int (*detach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device); + irqreturn_t (*te_irq_handler)(struct exynos_dsi *dsim); }; struct exynos_dsi_enc { @@ -1333,11 +1334,10 @@ static irqreturn_t exynos_dsi_irq(int irq, void *dev_id) static irqreturn_t exynos_dsi_te_irq_handler(int irq, void *dev_id) { struct exynos_dsi *dsi = (struct exynos_dsi *)dev_id; - struct exynos_dsi_enc *dsi_enc = dsi->priv; - struct drm_encoder *encoder = &dsi_enc->encoder; + const struct exynos_dsi_plat_data *pdata = dsi->plat_data; - if (dsi->state & DSIM_STATE_VIDOUT_AVAILABLE) - exynos_drm_crtc_te_handler(encoder->crtc); + if (pdata->host_ops && pdata->host_ops->te_irq_handler) + return pdata->host_ops->te_irq_handler(dsi); return IRQ_HANDLED; } @@ -1716,6 +1716,17 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) return 0; } +static irqreturn_t _exynos_dsi_te_irq_handler(struct exynos_dsi *dsim) +{ + struct exynos_dsi_enc *dsi_enc = dsim->priv; + struct drm_encoder *encoder = &dsi_enc->encoder; + + if (dsim->state & DSIM_STATE_VIDOUT_AVAILABLE) + exynos_drm_crtc_te_handler(encoder->crtc); + + return IRQ_HANDLED; +} + static int _exynos_dsi_host_attach(struct exynos_dsi *dsim, struct mipi_dsi_device *device) { @@ -2030,6 +2041,7 @@ static const struct exynos_dsim_host_ops exynos_dsi_host_ops = { .unregister_host = exynos_dsi_unregister_host, .attach = _exynos_dsi_host_attach, .detach = _exynos_dsi_host_detach, + .te_irq_handler = _exynos_dsi_te_irq_handler, }; static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = { -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B18BFC05027 for ; Thu, 26 Jan 2023 14:53:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cY6zapWBcbGGceNxW/rxuDKMCMAs+43yF5tIqEEEdJI=; b=GWJuZkvJUZLPqf ZvlkDgqkMwJs4h3G0BZzWfZqHQtniy+TgHxO0GfH93MTeRttDjt5kgcrxJuO4aAxzqUgl6EEViIjY xa9J9k7YZnYK35NX+5xi/B953yrCBluv016BxTJDZTPBWYoEntnOJR53bkH3gd/tP94M9u/k/sFYr Dw3275QShPU182zNYpSSDYKXISblddKIUN+EJntp1avHZ6GyKxZU3MsCjo/r9c0tVMd/ddiBRrfCB MgN6if3zc03kS9H4oZrP06BV2dG8GuSz5he5r3uerMXLaj4MPC0OENNWm9WWamFkXaT8RejZhszSi 8lM24+1MwfXKAH5tXqmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3bc-00BIlR-SE; Thu, 26 Jan 2023 14:52:01 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pL3X9-00BGoc-VO for linux-arm-kernel@lists.infradead.org; Thu, 26 Jan 2023 14:47:26 +0000 Received: by mail-pl1-x631.google.com with SMTP id jl3so2000317plb.8 for ; Thu, 26 Jan 2023 06:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=lMOybId87xz2ZyOHJXou8xZjJy2Gienx1uyxdWQ0pNTgLk+M2+B9DN4O5BJIr5Pji+ XW6Xp6rjEnaG7YFn/hj/Oh93k0G7s506IcxiYqxAg4dAN2bBej0MOTA+2h77TSGv5DcS XBUawWXccLWOHRppDnOqp1h5c8rU/sGkxnT8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=LWbjHBKVFFL4fIfQTmDb6SZphzJsb5fMFTMNjwsnMmWc5ysXFbBglpyUxXqq7svrcT pJyaF30NFrTYS+La7kQZsMuaGsUic7Uxn6LPGKFwzIFgUD+TLdGT6ksMvA4xz2iSltK7 EgFJdAolx9aalJnDdGtC7V2IFRux4jyYeYPlbfS2Zkkjjtp1Uj/rcKKVZqDYsZFv6PCK xpB/jMIRLb1ffu1wk9pB6XM4cTvI7aPfTz0WDPdZXHNwplduxp2hFdpMO46oXPcrvVdl 1sTzGjF8fKrsxaYyFh0EkdIr+UJE6Em8Qc7KJJJdOR2Fb07zFYVv4tukbHAfwY+k9+Zq WsbQ== X-Gm-Message-State: AFqh2kqShrjw4Nftf8JrvgKn0PSvFVhZ+VGZUjPOJgkltY9ZoXQLc9Wk pr4eobErE4zLQ+DrD4uhnXGo8Q== X-Google-Smtp-Source: AMrXdXsQ9iGnU7hZJbbFFwwp29B7k3r1WFplJKzJsKhS/P+qYxclQigi3wIX8J/engpZhelsyuPTsg== X-Received: by 2002:a05:6a21:3381:b0:af:6cc0:5b3d with SMTP id yy1-20020a056a21338100b000af6cc05b3dmr50400165pzb.7.1674744442878; Thu, 26 Jan 2023 06:47:22 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:47:22 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Cc: Matteo Lisi , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, NXP Linux Team , linux-amarula , Jagan Teki Subject: [PATCH v12 13/18] drm: exynos: dsi: Add host helper for te_irq_handler Date: Thu, 26 Jan 2023 20:14:22 +0530 Message-Id: <20230126144427.607098-14-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230126_064724_321134_39BE09E3 X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SVJRIGhhbmRsZXIgZm9yIHRlLWdwaW8gc2VlbXMgdG8gYmUgY29tbW9uIGFjcm9zcyBEU0lNwqBo b3N0LgoKSG93ZXZlciwgRXh5bm9zIGlzIGhhbmRsaW5nIHRoaXMgdmlhIENSVEMgZHJpdmVycyBi dXQgdGhlcmUgaXMgbm8gY2xlYXIKZXZpZGVuY2XCoG9uIGhvdyB0aGUgc2FtZSBoYXMgYmVlbsKg aGFuZGxlZCBpbiBpLk1YOE1NLiBLZWVwaW5nIHRoZSBoYW5kbGVyCmFzLWl0LWlzIGNhbiBiZSBh IHZpYWJsZSBvcHRpb24gYnV0IGFkZGluZyBEU0lNIGJyaWRnZSBjb3JlIGluIHVwY29taW5nCnBh dGNoZXMgaXMgbm90IHBvc3NpYmxlIHRvIGNhbGwgRXh5bm9zIENSVEMgaGFuZGxlciBhcyBEU0lN IGJyaWRnZSBoYXMKdG8gYmUgY29tbW9uIGFjcm9zcyBEUk0gYnJpZGdlIGNvcmUgaW5zdGVhZCBv ZiBwbGF0Zm9ybSBzcGVjaWZpYyBEUk0KZHJpdmVycyBsaWtlIEV4eW5vcyBoZXJlLgoKU28sIHRo aXMgcGF0Y2ggaGFuZGxlcyB0aGUgaGFuZGxlciB2aWEgcGxhdGZvcm0gaG9zdCBoZWxwZXIsIHNv LXRoYXQKaGFuZGxpbmcgcGxhdGZvcm0gc3BlY2lmaWPCoGhvb2sgYWNyb3NzIEV4eW5vcyBhbmQg Z2VuZXJpYyBjYW4gYmUKcmVhc29uYWJsZSB0aWxsIGl0IG1ha2VzIGl0IGdlbmVyaWMgYWNyb3Nz IGFsbCBwbGF0Zm9ybXMuCgpTaWduZWQtb2ZmLWJ5OiBKYWdhbiBUZWtpIDxqYWdhbkBhbWFydWxh c29sdXRpb25zLmNvbT4KLS0tCkNoYW5nZXMgZm9yIHYxMjoKLSB1cGRhdGVkIHBhdGNoCi0gc3Vn Z2VzdGVkIGJ5IE1hcmVrIFYKQ2hhbmdlcyBmb3IgdjExOgotIG5vbmUKQ2hhbmdlcyBmb3IgdjEw OgotIHNwbGl0IGZyb20gcHJldmlvdXMgc2VyaWVzIHBhdGNoCiJkcm06IGJyaWRnZTogR2VuZXJh bGl6ZSBFeHlub3MtRFNJIGRyaXZlciBpbnRvIGEgU2Ftc3VuZyBEU0lNIGJyaWRnZSIKCiBkcml2 ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcm1fZHNpLmMgfCAyMCArKysrKysrKysrKysrKysr LS0tLQogMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jIGIvZHJp dmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jCmluZGV4IDQ4OGZhZTIxODIwNS4u MWQ5NTkwOTM5MWUyIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19k cm1fZHNpLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL2V4eW5vcy9leHlub3NfZHJtX2RzaS5jCkBA IC0zMjUsNiArMzI1LDcgQEAgc3RydWN0IGV4eW5vc19kc2ltX2hvc3Rfb3BzIHsKIAl2b2lkICgq dW5yZWdpc3Rlcl9ob3N0KShzdHJ1Y3QgZXh5bm9zX2RzaSAqZHNpbSk7CiAJaW50ICgqYXR0YWNo KShzdHJ1Y3QgZXh5bm9zX2RzaSAqZHNpbSwgc3RydWN0IG1pcGlfZHNpX2RldmljZSAqZGV2aWNl KTsKIAlpbnQgKCpkZXRhY2gpKHN0cnVjdCBleHlub3NfZHNpICpkc2ltLCBzdHJ1Y3QgbWlwaV9k c2lfZGV2aWNlICpkZXZpY2UpOworCWlycXJldHVybl90ICgqdGVfaXJxX2hhbmRsZXIpKHN0cnVj dCBleHlub3NfZHNpICpkc2ltKTsKIH07CiAKIHN0cnVjdCBleHlub3NfZHNpX2VuYyB7CkBAIC0x MzMzLDExICsxMzM0LDEwIEBAIHN0YXRpYyBpcnFyZXR1cm5fdCBleHlub3NfZHNpX2lycShpbnQg aXJxLCB2b2lkICpkZXZfaWQpCiBzdGF0aWMgaXJxcmV0dXJuX3QgZXh5bm9zX2RzaV90ZV9pcnFf aGFuZGxlcihpbnQgaXJxLCB2b2lkICpkZXZfaWQpCiB7CiAJc3RydWN0IGV4eW5vc19kc2kgKmRz aSA9IChzdHJ1Y3QgZXh5bm9zX2RzaSAqKWRldl9pZDsKLQlzdHJ1Y3QgZXh5bm9zX2RzaV9lbmMg KmRzaV9lbmMgPSBkc2ktPnByaXY7Ci0Jc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyID0gJmRz aV9lbmMtPmVuY29kZXI7CisJY29uc3Qgc3RydWN0IGV4eW5vc19kc2lfcGxhdF9kYXRhICpwZGF0 YSA9IGRzaS0+cGxhdF9kYXRhOwogCi0JaWYgKGRzaS0+c3RhdGUgJiBEU0lNX1NUQVRFX1ZJRE9V VF9BVkFJTEFCTEUpCi0JCWV4eW5vc19kcm1fY3J0Y190ZV9oYW5kbGVyKGVuY29kZXItPmNydGMp OworCWlmIChwZGF0YS0+aG9zdF9vcHMgJiYgcGRhdGEtPmhvc3Rfb3BzLT50ZV9pcnFfaGFuZGxl cikKKwkJcmV0dXJuIHBkYXRhLT5ob3N0X29wcy0+dGVfaXJxX2hhbmRsZXIoZHNpKTsKIAogCXJl dHVybiBJUlFfSEFORExFRDsKIH0KQEAgLTE3MTYsNiArMTcxNiwxNyBAQCBzdGF0aWMgaW50IGV4 eW5vc19kc2lfcGFyc2VfZHQoc3RydWN0IGV4eW5vc19kc2kgKmRzaSkKIAlyZXR1cm4gMDsKIH0K IAorc3RhdGljIGlycXJldHVybl90IF9leHlub3NfZHNpX3RlX2lycV9oYW5kbGVyKHN0cnVjdCBl eHlub3NfZHNpICpkc2ltKQoreworCXN0cnVjdCBleHlub3NfZHNpX2VuYyAqZHNpX2VuYyA9IGRz aW0tPnByaXY7CisJc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyID0gJmRzaV9lbmMtPmVuY29k ZXI7CisKKwlpZiAoZHNpbS0+c3RhdGUgJiBEU0lNX1NUQVRFX1ZJRE9VVF9BVkFJTEFCTEUpCisJ CWV4eW5vc19kcm1fY3J0Y190ZV9oYW5kbGVyKGVuY29kZXItPmNydGMpOworCisJcmV0dXJuIElS UV9IQU5ETEVEOworfQorCiBzdGF0aWMgaW50IF9leHlub3NfZHNpX2hvc3RfYXR0YWNoKHN0cnVj dCBleHlub3NfZHNpICpkc2ltLAogCQkJCSAgIHN0cnVjdCBtaXBpX2RzaV9kZXZpY2UgKmRldmlj ZSkKIHsKQEAgLTIwMzAsNiArMjA0MSw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZXh5bm9zX2Rz aW1faG9zdF9vcHMgZXh5bm9zX2RzaV9ob3N0X29wcyA9IHsKIAkudW5yZWdpc3Rlcl9ob3N0ID0g ZXh5bm9zX2RzaV91bnJlZ2lzdGVyX2hvc3QsCiAJLmF0dGFjaCA9IF9leHlub3NfZHNpX2hvc3Rf YXR0YWNoLAogCS5kZXRhY2ggPSBfZXh5bm9zX2RzaV9ob3N0X2RldGFjaCwKKwkudGVfaXJxX2hh bmRsZXIgPSBfZXh5bm9zX2RzaV90ZV9pcnFfaGFuZGxlciwKIH07CiAKIHN0YXRpYyBjb25zdCBz dHJ1Y3QgZXh5bm9zX2RzaV9wbGF0X2RhdGEgZXh5bm9zMzI1MF9kc2lfcGRhdGEgPSB7Ci0tIAoy LjI1LjEKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwps aW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJh ZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51 eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 359DAC54E94 for ; Thu, 26 Jan 2023 14:47:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FF8B10E927; Thu, 26 Jan 2023 14:47:26 +0000 (UTC) Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4677310E927 for ; Thu, 26 Jan 2023 14:47:23 +0000 (UTC) Received: by mail-pl1-x630.google.com with SMTP id z13so2009341plg.6 for ; Thu, 26 Jan 2023 06:47:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=lMOybId87xz2ZyOHJXou8xZjJy2Gienx1uyxdWQ0pNTgLk+M2+B9DN4O5BJIr5Pji+ XW6Xp6rjEnaG7YFn/hj/Oh93k0G7s506IcxiYqxAg4dAN2bBej0MOTA+2h77TSGv5DcS XBUawWXccLWOHRppDnOqp1h5c8rU/sGkxnT8c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=A1BDEAt+rxWWloQDlKB/2I6ZLTZG0ASWjyAAcB7oGTE=; b=5Xba45NFECc0rOS3x5unTAe9gAAzRbWv3sU45V89OfIFMLM5JMFp9Vd3ib2EImBGiD 2uY+bzmyW7IOZ26VXb2LEcchU4boa9uze6qEBWGZfGlQtkxopZOunKF+yVRfESnAK2h0 Oa+lfVZOsIjLgJWHN4bULd6MkOpe2Cr6A+NZjwmThqYI/Haie6bNB7Nc0MkVZeR7sgqL 7F/xBqkB6nkbP6CsBLvFDEoz6ee9wCQB8u1ZA65JQrZ7dpQzsZ6Af2sWEyc4q3fOH4f1 GRQmz933RUhIKlMLDcdC4A5jI47TuQE03mHXtNXuq7966LsO0jB6eyddB2g558utLtx3 tZ6w== X-Gm-Message-State: AFqh2krJqqGYe96pxooCZMzIP10+cJjVoJIZ8V8sBiusoAdsd0RqW9+y n8PAgdOfwr/VTOpdP+D6YivYNw== X-Google-Smtp-Source: AMrXdXsQ9iGnU7hZJbbFFwwp29B7k3r1WFplJKzJsKhS/P+qYxclQigi3wIX8J/engpZhelsyuPTsg== X-Received: by 2002:a05:6a21:3381:b0:af:6cc0:5b3d with SMTP id yy1-20020a056a21338100b000af6cc05b3dmr50400165pzb.7.1674744442878; Thu, 26 Jan 2023 06:47:22 -0800 (PST) Received: from localhost.localdomain ([2405:201:c00a:a238:3cb1:2156:ef87:8af5]) by smtp.gmail.com with ESMTPSA id d197-20020a6336ce000000b0042988a04bfdsm823660pga.9.2023.01.26.06.47.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Jan 2023 06:47:22 -0800 (PST) From: Jagan Teki To: Andrzej Hajda , Inki Dae , Marek Szyprowski , Seung-Woo Kim , Kyungmin Park , Frieder Schrempf , Tim Harvey , Adam Ford , Robert Foss , Laurent Pinchart , Marek Vasut Subject: [PATCH v12 13/18] drm: exynos: dsi: Add host helper for te_irq_handler Date: Thu, 26 Jan 2023 20:14:22 +0530 Message-Id: <20230126144427.607098-14-jagan@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230126144427.607098-1-jagan@amarulasolutions.com> References: <20230126144427.607098-1-jagan@amarulasolutions.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Matteo Lisi , dri-devel@lists.freedesktop.org, NXP Linux Team , linux-amarula , linux-arm-kernel@lists.infradead.org, Jagan Teki Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" IRQ handler for te-gpio seems to be common across DSIM host. However, Exynos is handling this via CRTC drivers but there is no clear evidence on how the same has been handled in i.MX8MM. Keeping the handler as-it-is can be a viable option but adding DSIM bridge core in upcoming patches is not possible to call Exynos CRTC handler as DSIM bridge has to be common across DRM bridge core instead of platform specific DRM drivers like Exynos here. So, this patch handles the handler via platform host helper, so-that handling platform specific hook across Exynos and generic can be reasonable till it makes it generic across all platforms. Signed-off-by: Jagan Teki --- Changes for v12: - updated patch - suggested by Marek V Changes for v11: - none Changes for v10: - split from previous series patch "drm: bridge: Generalize Exynos-DSI driver into a Samsung DSIM bridge" drivers/gpu/drm/exynos/exynos_drm_dsi.c | 20 ++++++++++++++++---- 1 file changed, 16 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 488fae218205..1d95909391e2 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -325,6 +325,7 @@ struct exynos_dsim_host_ops { void (*unregister_host)(struct exynos_dsi *dsim); int (*attach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device); int (*detach)(struct exynos_dsi *dsim, struct mipi_dsi_device *device); + irqreturn_t (*te_irq_handler)(struct exynos_dsi *dsim); }; struct exynos_dsi_enc { @@ -1333,11 +1334,10 @@ static irqreturn_t exynos_dsi_irq(int irq, void *dev_id) static irqreturn_t exynos_dsi_te_irq_handler(int irq, void *dev_id) { struct exynos_dsi *dsi = (struct exynos_dsi *)dev_id; - struct exynos_dsi_enc *dsi_enc = dsi->priv; - struct drm_encoder *encoder = &dsi_enc->encoder; + const struct exynos_dsi_plat_data *pdata = dsi->plat_data; - if (dsi->state & DSIM_STATE_VIDOUT_AVAILABLE) - exynos_drm_crtc_te_handler(encoder->crtc); + if (pdata->host_ops && pdata->host_ops->te_irq_handler) + return pdata->host_ops->te_irq_handler(dsi); return IRQ_HANDLED; } @@ -1716,6 +1716,17 @@ static int exynos_dsi_parse_dt(struct exynos_dsi *dsi) return 0; } +static irqreturn_t _exynos_dsi_te_irq_handler(struct exynos_dsi *dsim) +{ + struct exynos_dsi_enc *dsi_enc = dsim->priv; + struct drm_encoder *encoder = &dsi_enc->encoder; + + if (dsim->state & DSIM_STATE_VIDOUT_AVAILABLE) + exynos_drm_crtc_te_handler(encoder->crtc); + + return IRQ_HANDLED; +} + static int _exynos_dsi_host_attach(struct exynos_dsi *dsim, struct mipi_dsi_device *device) { @@ -2030,6 +2041,7 @@ static const struct exynos_dsim_host_ops exynos_dsi_host_ops = { .unregister_host = exynos_dsi_unregister_host, .attach = _exynos_dsi_host_attach, .detach = _exynos_dsi_host_detach, + .te_irq_handler = _exynos_dsi_te_irq_handler, }; static const struct exynos_dsi_plat_data exynos3250_dsi_pdata = { -- 2.25.1