From: "Michael S. Tsirkin" <mst@redhat.com>
To: Eli Cohen <elic@nvidia.com>
Cc: "virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
Yang Yingliang <yangyingliang@huawei.com>
Subject: Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules()
Date: Fri, 27 Jan 2023 05:43:09 -0500 [thread overview]
Message-ID: <20230127054259-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <DM8PR12MB540017B7D9940F73F6C060FCABF59@DM8PR12MB5400.namprd12.prod.outlook.com>
Were you going to do this?
On Wed, Jan 04, 2023 at 02:31:52PM +0000, Eli Cohen wrote:
> Sure, thanks!
>
> > -----Original Message-----
> > From: Michael S. Tsirkin <mst@redhat.com>
> > Sent: Wednesday, 4 January 2023 15:58
> > To: Eli Cohen <elic@nvidia.com>
> > Cc: Yang Yingliang <yangyingliang@huawei.com>; virtualization@lists.linux-
> > foundation.org; jasowang@redhat.com
> > Subject: Re: [PATCH -next] vdpa/mlx5: fix check wrong pointer in
> > mlx5_vdpa_add_mac_vlan_rules()
> >
> > On Wed, Jan 04, 2023 at 11:41:31AM +0000, Eli Cohen wrote:
> > > I see these patches were not sent yet.
> > > Michael/Yang Yinglliang, isn't it better to send a fixed patch instead of
> > sending the original and fix on top of it?
> >
> > depends on the severity of the fix. in this case it seems to leak
> > uninitialized stack data to userspace, so I'd say it's best to
> > squash in the fix.
> > keep signed-off by of the fixup contributor so they get attribution.
> >
> > --
> > MST
>
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2023-01-27 10:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230104074418.1737510-1-yangyingliang@huawei.com>
[not found] ` <DM8PR12MB5400CDBCE2E0150F50E2224FABF59@DM8PR12MB5400.namprd12.prod.outlook.com>
[not found] ` <DM8PR12MB540012D1421616399D0903CCABF59@DM8PR12MB5400.namprd12.prod.outlook.com>
2023-01-04 13:58 ` [PATCH -next] vdpa/mlx5: fix check wrong pointer in mlx5_vdpa_add_mac_vlan_rules() Michael S. Tsirkin
[not found] ` <DM8PR12MB540017B7D9940F73F6C060FCABF59@DM8PR12MB5400.namprd12.prod.outlook.com>
2023-01-27 10:43 ` Michael S. Tsirkin [this message]
2023-01-09 9:10 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127054259-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=elic@nvidia.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.