From: Christoph Hellwig <hch@lst.de>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>,
Andrew Morton <akpm@linux-foundation.org>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] fs: build the legacy direct I/O code conditionally
Date: Fri, 27 Jan 2023 07:30:42 +0100 [thread overview]
Message-ID: <20230127063042.GA3174@lst.de> (raw)
In-Reply-To: <Y9LulMOE1BnUMP2l@ZenIV>
On Thu, Jan 26, 2023 at 09:20:20PM +0000, Al Viro wrote:
> On Wed, Jan 25, 2023 at 07:58:39AM +0100, Christoph Hellwig wrote:
> > Add a new LEGACY_DIRECT_IO config symbol that is only selected by the
> > file systems that still use the legacy blockdev_direct_IO code, so that
> > kernels without support for those file systems don't need to build the
> > code.
>
> Looks sane... FWIW, I've got this in the misc pile; doesn't seem to
> conflict anything in your series, thankfully...
Yes, this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
If someone had time to convert ocfs2 to iomap we could also kill
the entire __blockdev_direct_IO variant.
next prev parent reply other threads:[~2023-01-27 6:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 6:58 build direct-io.c conditionally Christoph Hellwig
2023-01-25 6:58 ` [PATCH 1/2] fs: move sb_init_dio_done_wq out of direct-io.c Christoph Hellwig
2023-01-25 9:10 ` Jan Kara
2023-01-25 18:17 ` Eric Biggers
2023-01-25 6:58 ` [PATCH 2/2] fs: build the legacy direct I/O code conditionally Christoph Hellwig
2023-01-25 9:13 ` Jan Kara
2023-01-25 18:18 ` Eric Biggers
2023-01-26 21:20 ` Al Viro
2023-01-27 6:30 ` Christoph Hellwig [this message]
2023-01-26 17:31 ` build direct-io.c conditionally Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127063042.GA3174@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.