Re: [PATCH] MIPS: OCTEON: octeon-usb: Consolidate error messages

[Thomas Bogendoerfer <tsbogend@alpha.franken.de>]

On Wed, Dec 21, 2022 at 03:23:49PM +0100, Ladislav Michl wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> Console output currently looks like USB clocks initialized succesfully
> even in case of error. Fix that and use consistently dev_err for fatal
> errors otherwise dev_warn.
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  Hi there,
> 
>  this is just cleanup before real work. Just note that even
>  warning says "Invalid UCTL clock rate ..., using 100000000 instead"
>  clock_rate is not set to 100000000. There's also some indentation
>  fixes to be done.
> 
>  However my main concern is unimplemented errata 29206 as noted in
>  OCTEON III CN70XX/CN71XX Known Issues Revision 1.9, released under
>  NDA. You can see its implementation in coreboot here (line 196):
>  https://fossies.org/linux/coreboot/src/vendorcode/cavium/bdk/libbdk-hal/bdk-usb.c
> 
>  Above looks like BSD license. I'll reimplement said errata
>  from scratch, unless someone sees as a problem "Marvell Proprietary
>  and Confidential" documentation is used as source.
> 
>  arch/mips/cavium-octeon/octeon-usb.c | 42 +++++++++++++---------------
>  1 file changed, 20 insertions(+), 22 deletions(-)

applied to mips-next.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]