From: Jakub Kicinski <kuba@kernel.org>
To: Yunsheng Lin <linyunsheng@huawei.com>
Cc: Alexander Duyck <alexander.duyck@gmail.com>, <nbd@nbd.name>,
<davem@davemloft.net>, <edumazet@google.com>, <hawk@kernel.org>,
<ilias.apalodimas@linaro.org>, <linux-kernel@vger.kernel.org>,
<lorenzo@kernel.org>, <netdev@vger.kernel.org>,
<pabeni@redhat.com>
Subject: Re: [net PATCH] skb: Do mix page pool and page referenced frags in GRO
Date: Fri, 27 Jan 2023 21:26:46 -0800 [thread overview]
Message-ID: <20230127212646.4cfeb475@kernel.org> (raw)
In-Reply-To: <cde24ed8-1852-ce93-69f3-ff378731f52c@huawei.com>
On Sat, 28 Jan 2023 10:37:47 +0800 Yunsheng Lin wrote:
> If we are not allowing gro for the above case, setting NAPI_GRO_CB(p)->flush
> to 1 in gro_list_prepare() seems to be making more sense so that the above
> case has the same handling as skb_has_frag_list() handling?
> https://elixir.bootlin.com/linux/v6.2-rc4/source/net/core/gro.c#L503
>
> As it seems to avoid some unnecessary operation according to comment
> in tcp4_gro_receive():
> https://elixir.bootlin.com/linux/v6.2-rc4/source/net/ipv4/tcp_offload.c#L322
The frag_list case can be determined with just the input skb.
For pp_recycle we need to compare input skb's pp_recycle with
the pp_recycle of the skb already held by GRO.
I'll hold off with applying a bit longer tho, in case Eric
wants to chime in with an ack or opinion.
next prev parent reply other threads:[~2023-01-28 5:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-24 12:43 [PATCH] net: page_pool: fix refcounting issues with fragmented allocation Felix Fietkau
2023-01-24 14:11 ` Ilias Apalodimas
2023-01-24 15:57 ` Alexander H Duyck
2023-01-24 16:59 ` Felix Fietkau
2023-01-26 10:31 ` Ilias Apalodimas
2023-01-26 15:41 ` Alexander Duyck
2023-01-26 16:05 ` Ilias Apalodimas
2023-01-24 17:22 ` Felix Fietkau
2023-01-24 21:10 ` Alexander H Duyck
2023-01-24 21:30 ` Felix Fietkau
2023-01-25 17:11 ` Alexander H Duyck
2023-01-25 17:32 ` Felix Fietkau
2023-01-25 18:26 ` Alexander H Duyck
2023-01-25 18:42 ` Felix Fietkau
2023-01-25 19:02 ` Alexander H Duyck
2023-01-25 19:10 ` Felix Fietkau
2023-01-25 19:40 ` Felix Fietkau
2023-01-25 20:02 ` Felix Fietkau
2023-01-25 22:14 ` Alexander H Duyck
2023-01-26 6:12 ` Felix Fietkau
2023-01-26 9:14 ` Felix Fietkau
2023-01-26 16:08 ` Alexander Duyck
2023-01-26 16:40 ` Alexander Duyck
2023-01-26 17:44 ` Felix Fietkau
2023-01-26 18:38 ` Alexander H Duyck
2023-01-26 18:43 ` Felix Fietkau
2023-01-26 19:06 ` [net PATCH] skb: Do mix page pool and page referenced frags in GRO Alexander Duyck
2023-01-26 19:14 ` Toke Høiland-Jørgensen
2023-01-26 19:48 ` Alexander Duyck
2023-01-26 21:35 ` Toke Høiland-Jørgensen
2023-01-26 23:13 ` Jakub Kicinski
2023-01-27 7:15 ` Ilias Apalodimas
2023-01-27 7:21 ` Felix Fietkau
2023-01-30 16:49 ` Jesper Dangaard Brouer
2023-01-28 2:37 ` Yunsheng Lin
2023-01-28 5:26 ` Jakub Kicinski [this message]
2023-01-28 7:08 ` Eric Dumazet
2023-01-30 8:50 ` Paolo Abeni
2023-01-30 16:17 ` Alexander Duyck
2023-01-28 7:15 ` Eric Dumazet
2023-01-28 17:08 ` Alexander Duyck
2023-01-28 7:50 ` patchwork-bot+netdevbpf
2023-01-26 10:32 ` [PATCH] net: page_pool: fix refcounting issues with fragmented allocation Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230127212646.4cfeb475@kernel.org \
--to=kuba@kernel.org \
--cc=alexander.duyck@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.