All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Peter Maydell" <peter.maydell@linaro.org>
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Stefan Hajnoczi" <stefanha@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>
Subject: [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job
Date: Mon, 30 Jan 2023 11:44:46 +0100	[thread overview]
Message-ID: <20230130104446.1286773-7-thuth@redhat.com> (raw)
In-Reply-To: <20230130104446.1286773-1-thuth@redhat.com>

We can get rid of the build-coroutine-sigaltstack job by moving
the configure flags that should be tested here to other jobs:
Move --with-coroutine=sigaltstack to the build-without-defaults job
and --enable-trace-backends=ftrace to the cross-s390x-kvm-only job.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 .gitlab-ci.d/buildtest.yml   | 14 ++------------
 .gitlab-ci.d/crossbuilds.yml |  2 +-
 2 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml
index 91c7467a66..1438797a1c 100644
--- a/.gitlab-ci.d/buildtest.yml
+++ b/.gitlab-ci.d/buildtest.yml
@@ -533,19 +533,8 @@ build-tci:
     - QTEST_QEMU_BINARY="./qemu-system-s390x" ./tests/qtest/pxe-test -m slow
     - make check-tcg
 
-# Alternate coroutines implementations are only really of interest to KVM users
-# However we can't test against KVM on Gitlab-CI so we can only run unit tests
-build-coroutine-sigaltstack:
-  extends: .native_build_job_template
-  needs:
-    job: amd64-ubuntu2004-container
-  variables:
-    IMAGE: ubuntu2004
-    CONFIGURE_ARGS: --with-coroutine=sigaltstack --disable-tcg
-                    --enable-trace-backends=ftrace
-    MAKE_CHECK_ARGS: check-unit
-
 # Check our reduced build configurations
+# (and an alternative coroutine implementation)
 build-without-defaults:
   extends: .native_build_job_template
   needs:
@@ -559,6 +548,7 @@ build-without-defaults:
       --disable-pie
       --disable-qom-cast-debug
       --disable-strip
+      --with-coroutine=sigaltstack
     TARGETS: avr-softmmu mips64-softmmu s390x-softmmu sh4-softmmu
       sparc64-softmmu hexagon-linux-user i386-linux-user s390x-linux-user
     MAKE_CHECK_ARGS: check-unit check-qtest-avr check-qtest-mips64
diff --git a/.gitlab-ci.d/crossbuilds.yml b/.gitlab-ci.d/crossbuilds.yml
index 8dbbb8f881..027d2088da 100644
--- a/.gitlab-ci.d/crossbuilds.yml
+++ b/.gitlab-ci.d/crossbuilds.yml
@@ -159,7 +159,7 @@ cross-s390x-kvm-only:
     job: s390x-debian-cross-container
   variables:
     IMAGE: debian-s390x-cross
-    EXTRA_CONFIGURE_OPTS: --disable-tcg
+    EXTRA_CONFIGURE_OPTS: --disable-tcg --enable-trace-backends=ftrace
 
 cross-mips64el-kvm-only:
   extends: .cross_accel_build_job
-- 
2.31.1



  parent reply	other threads:[~2023-01-30 10:47 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-30 10:44 [PATCH 0/6] Shorten the runtime of some gitlab-CI shared runner jobs Thomas Huth
2023-01-30 10:44 ` [PATCH 1/6] gitlab-ci.d/buildtest: Remove ppc-softmmu from the clang-system job Thomas Huth
2023-01-30 22:37   ` Philippe Mathieu-Daudé
2023-01-30 10:44 ` [PATCH 2/6] gitlab-ci.d/buildtest: Remove aarch64-softmmu from the build-system-ubuntu job Thomas Huth
2023-01-30 10:44 ` [PATCH 3/6] tests/qtest/display-vga-test: Add proper checks if a device is available Thomas Huth
2023-01-30 21:13   ` Richard Henderson
2023-01-30 10:44 ` [PATCH 4/6] gitlab-ci.d/buildtest: Merge the --without-default-* jobs Thomas Huth
2023-01-30 13:28   ` Fabiano Rosas
2023-01-31  8:02     ` Thomas Huth
2023-01-30 17:45   ` Alex Bennée
2023-01-30 22:43   ` Philippe Mathieu-Daudé
2023-01-30 10:44 ` [PATCH 5/6] gitlab-ci.d/buildtest: Merge the two gprof-gcov jobs Thomas Huth
2023-01-30 17:42   ` Alex Bennée
2023-01-31  7:53     ` Thomas Huth
2023-01-30 10:44 ` Thomas Huth [this message]
2023-01-30 10:58   ` [PATCH 6/6] gitlab-ci.d/buildtest: Disintegrate the build-coroutine-sigaltstack job Daniel P. Berrangé
2023-01-30 12:05     ` Thomas Huth
2023-02-03 11:23     ` Thomas Huth
2023-02-03 12:08       ` Kevin Wolf
2023-02-03 15:44         ` Thomas Huth
2023-02-03 15:47           ` Peter Maydell
2023-02-03 21:14             ` Juan Quintela
2023-02-04 10:23               ` Peter Maydell
2023-02-06  9:36                 ` Juan Quintela
2023-02-06  7:44               ` Thomas Huth
2023-02-06  8:46                 ` Juan Quintela
2023-02-06 10:47                   ` Peter Maydell
2023-02-03 21:10         ` Juan Quintela
2023-02-02 11:30 ` [PATCH 0/6] Shorten the runtime of some gitlab-CI shared runner jobs Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130104446.1286773-7-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.