From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Phil Auld <pauld@redhat.com>
Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org,
mingo@redhat.com, peterz@infradead.org, ritesh.list@gmail.com,
sshegde@linux.ibm.com, vincent.guittot@linaro.org,
vishalc@linux.vnet.ibm.com, vschneid@redhat.com
Subject: Re: [PATCH v2] sched/debug: Put sched/domains files under the verbose flag
Date: Mon, 30 Jan 2023 20:24:51 +0530 [thread overview]
Message-ID: <20230130145451.GB159593@linux.vnet.ibm.com> (raw)
In-Reply-To: <20230120163330.1334128-1-pauld@redhat.com>
* Phil Auld <pauld@redhat.com> [2023-01-20 11:33:30]:
> The debug files under sched/domains can take a long time to regenerate,
> especially when updates are done one at a time. Move these files under
> the sched verbose debug flag. Allow changes to verbose to trigger
> generation of the files. This lets a user batch the updates but still
> have the information available. The detailed topology printk messages
> are also under verbose.
>
> Discussion that lead to this approach can be found in the link below.
>
> Simplified code to maintain use of debugfs bool routines suggested by
> Michael Ellerman <mpe@ellerman.id.au>.
>
> Signed-off-by: Phil Auld <pauld@redhat.com>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Peter Zijlstra (Intel) <peterz@infradead.org>
> Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Cc: Valentin Schneider <vschneid@redhat.com>
> Cc: Vishal Chourasia <vishalc@linux.vnet.ibm.com>
> Cc: Vincent Guittot <vincent.guittot@linaro.org>
> Link: https://lore.kernel.org/all/Y01UWQL2y2r69sBX@li-05afa54c-330e-11b2-a85c-e3f3aa0db1e9.ibm.com/
> ---
>
Looks good to me.
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
--
Thanks and Regards
Srikar Dronamraju
next prev parent reply other threads:[~2023-01-30 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-19 15:07 [RESEND PATCH] sched/debug: Put sched/domains files under the verbose flag Phil Auld
2023-01-19 15:36 ` Greg KH
2023-01-20 15:52 ` Valentin Schneider
2023-01-20 16:06 ` Phil Auld
2023-01-20 16:33 ` [PATCH v2] " Phil Auld
2023-01-21 7:43 ` Greg KH
2023-01-27 15:01 ` Valentin Schneider
2023-01-30 14:54 ` Srikar Dronamraju [this message]
2023-02-08 13:26 ` Phil Auld
2023-02-15 6:03 ` Vishal Chourasia
2023-03-03 18:37 ` [RESEND PATCH " Phil Auld
2023-03-09 14:44 ` Greg KH
2023-03-09 17:48 ` Phil Auld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130145451.GB159593@linux.vnet.ibm.com \
--to=srikar@linux.vnet.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pauld@redhat.com \
--cc=peterz@infradead.org \
--cc=ritesh.list@gmail.com \
--cc=sshegde@linux.ibm.com \
--cc=vincent.guittot@linaro.org \
--cc=vishalc@linux.vnet.ibm.com \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.