All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	chiranjeevi.rapolu@intel.com, luca@z3ntu.xyz,
	krzysztof.kozlowski+dt@linaro.org,
	laurent.pinchart@ideasonboard.com, sakari.ailus@iki.fi,
	mchehab@kernel.org, linux-media@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v6.1] media: dt-bindings: Add OV5670
Date: Mon, 30 Jan 2023 09:58:40 -0600	[thread overview]
Message-ID: <20230130155840.GA2706990-robh@kernel.org> (raw)
In-Reply-To: <20230129121132.uamuvywdsuah5ivn@uno.localdomain>

On Sun, Jan 29, 2023 at 01:11:32PM +0100, Jacopo Mondi wrote:
> On Sun, Jan 29, 2023 at 12:40:03PM +0100, Krzysztof Kozlowski wrote:
> > On 28/01/2023 12:27, Jacopo Mondi wrote:
> > > Add the bindings documentation for Omnivision OV5670 image sensor.
> > >
> > > Signed-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> > > ---
> > > v6->6.1
> > > - Use additionalProperties: false for endpoint properties from
> > >   video-interfaces.yaml
> > > - List 'remote-endpoint' among the accepted endpoint properties
> > >   now that we use additionalProperties: false
> >
> > b4 diff '20230128112736.8000-1-jacopo.mondi@ideasonboard.com'
> > Could not create fake-am range for lower series v1
> >
> > Can you send patches in a way it does not break out workflows? Why
> > making our review process more difficult?
> 
> Because it's a nit on a 10 patches series with no other changes
> requested ?

So? Think of patch series as an 'email transport' for your git branches. 
If you rebase your branch, that's a whole new branch to send.

> What is difficult exactly ?

In addition to 'b4 diff', if a maintainer is applying this series, for a 
v7 they just do:

b4 shazam msgid-of-v7

For v6.1, they do:

b4 shazam msgid-of-v6
git rebase -i ...
<stop on patch 1>
git reset --hard HEAD^
b4 shazam msgid-of-v6.1
git rebase --continue

Which one makes the maintainer's life easier?

If it's a CI job trying to apply and test this, there's no way it's 
going to do the second case.

Rob

  parent reply	other threads:[~2023-01-30 15:59 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-26 16:59 [PATCH v6 0/9] media: i2c: ov5670: OF support, runtime_pm, regulators Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 1/9] media: dt-bindings: Add OV5670 Jacopo Mondi
2023-01-27 14:19   ` Krzysztof Kozlowski
2023-01-27 18:14     ` Jacopo Mondi
2023-01-27 19:58       ` Krzysztof Kozlowski
2023-01-27 20:38         ` Sakari Ailus
2023-01-27 20:44           ` Krzysztof Kozlowski
2023-01-28  9:58             ` Jacopo Mondi
2023-01-28 10:07               ` Sakari Ailus
2023-01-28 11:03                 ` Jacopo Mondi
2023-01-29 11:36                   ` Krzysztof Kozlowski
2023-01-28 11:27   ` [PATCH v6.1] " Jacopo Mondi
2023-01-29 11:40     ` Krzysztof Kozlowski
2023-01-29 12:11       ` Jacopo Mondi
2023-01-29 12:31         ` Krzysztof Kozlowski
2023-01-30 15:58         ` Rob Herring [this message]
2023-01-30 16:11           ` Jacopo Mondi
2023-01-29 11:40     ` Krzysztof Kozlowski
2023-01-26 16:59 ` [PATCH v6 2/9] media: i2c: ov5670: Allow probing with OF Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 3/9] media: i2c: ov5670: Use common clock framework Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 4/9] media: i2c: ov5670: Probe regulators Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 5/9] media: i2c: ov5670: Probe GPIOs Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 6/9] media: i2c: ov5670: Add runtime_pm operations Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 7/9] media: i2c: ov5670: Implement init_cfg Jacopo Mondi
2023-01-26 16:59 ` [PATCH v6 8/9] media: i2c: ov5670: Add .get_selection() support Jacopo Mondi
2023-01-28 17:57   ` Luca Weiss
2023-01-26 16:59 ` [PATCH v6 9/9] media: i2c: ov5670: Handle RO controls in set_ctrl Jacopo Mondi
2023-01-28 21:27 ` [PATCH v6 0/9] media: i2c: ov5670: OF support, runtime_pm, regulators Luca Weiss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230130155840.GA2706990-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=chiranjeevi.rapolu@intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jacopo.mondi@ideasonboard.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.