From: Jeroen Roovers <jer@xs4all.nl>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: netdev@vger.kernel.org, Simon Horman <simon.horman@corigine.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat")
Date: Mon, 30 Jan 2023 18:44:52 +0100 [thread overview]
Message-ID: <20230130184452.396762f8@wim.fritz.box> (raw)
In-Reply-To: <20230129195309.1941497-1-j.neuschaefer@gmx.net>
On Sun, 29 Jan 2023 20:53:08 +0100
Jonathan Neuschäfer <j.neuschaefer@gmx.net> wrote:
> Spell them as "default" and "heartbeat".
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> ---
>
> v2:
> - also fix "hearbeat", as suggested by Simon Horman
> ---
> drivers/net/ethernet/dec/tulip/tulip.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/dec/tulip/tulip.h
> b/drivers/net/ethernet/dec/tulip/tulip.h index
> 0ed598dc7569c..10d7d8de93660 100644 ---
> a/drivers/net/ethernet/dec/tulip/tulip.h +++
> b/drivers/net/ethernet/dec/tulip/tulip.h @@ -250,7 +250,7 @@ enum
> t21143_csr6_bits { csr6_ttm = (1<<22), /* Transmit Threshold Mode,
> set for 10baseT, 0 for 100BaseTX */ csr6_sf = (1<<21), /* Store and
> forward. If set ignores TR bits */ csr6_hbd = (1<<19), /* Heart beat
> disable. Disables SQE function in 10baseT */
If you are going to put "heartbeat" in the title of the patch, you may
want to fix "Heart beat" to match here as well. :-)
Kind regards,
jer
prev parent reply other threads:[~2023-01-30 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 19:53 [PATCH v2] net: tulip: Fix typos ("defualt" and "hearbeat") Jonathan Neuschäfer
2023-01-30 9:48 ` Leon Romanovsky
2023-01-30 17:44 ` Jeroen Roovers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130184452.396762f8@wim.fritz.box \
--to=jer@xs4all.nl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j.neuschaefer@gmx.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.