From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Adam Ford <aford173@gmail.com>,
linux-media@vger.kernel.org,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Xavier Roumegue <xavier.roumegue@oss.nxp.com>,
linux-imx@nxp.com, kernel@pengutronix.de,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v4 2/3] dt-bindings: media: imx8-isi: Use 'port' instead of 'ports' for i.MX8MN
Date: Mon, 30 Jan 2023 12:55:53 -0600 [thread overview]
Message-ID: <20230130185553.GA3110926-robh@kernel.org> (raw)
In-Reply-To: <Y9LI//H0a8P8c0gL@pendragon.ideasonboard.com>
On Thu, Jan 26, 2023 at 08:39:59PM +0200, Laurent Pinchart wrote:
> Hi Adam,
>
> On Thu, Jan 26, 2023 at 12:31:16PM -0600, Adam Ford wrote:
> > On Thu, Jan 26, 2023 at 11:06 AM Laurent Pinchart wrote:
> > >
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > ---
> > > .../bindings/media/nxp,imx8-isi.yaml | 39 +++++++++++--------
> > > 1 file changed, 22 insertions(+), 17 deletions(-)
> >
> > Is there a reason not to squash the two bindings into just one patch?
>
> As indicated in the cover letter, I've kept this separate to clearly
> show the impact on the bindings. If using a 'port' node is the preferred
> option, I can squash this patch, if using a 'ports' unconditionally is
> favoured, then I'll just drop it.
Just always use 'ports'.
Rob
next prev parent reply other threads:[~2023-01-30 18:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 17:06 [PATCH v4 0/3] media: nxp: i.MX8 ISI driver Laurent Pinchart
2023-01-26 17:06 ` [PATCH v4 1/3] dt-bindings: media: Add i.MX8 ISI DT bindings Laurent Pinchart
2023-01-30 18:56 ` Rob Herring
2023-01-26 17:06 ` [PATCH v4 2/3] dt-bindings: media: imx8-isi: Use 'port' instead of 'ports' for i.MX8MN Laurent Pinchart
2023-01-26 18:31 ` Adam Ford
2023-01-26 18:39 ` Laurent Pinchart
2023-01-26 18:47 ` Adam Ford
2023-01-30 18:55 ` Rob Herring [this message]
2023-01-26 17:06 ` [PATCH v4 3/3] media: nxp: Add i.MX8 ISI driver Laurent Pinchart
2023-01-28 10:10 ` kernel test robot
2023-02-03 9:54 ` [PATCH v4 0/3] media: nxp: " Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230130185553.GA3110926-robh@kernel.org \
--to=robh@kernel.org \
--cc=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-imx@nxp.com \
--cc=linux-media@vger.kernel.org \
--cc=xavier.roumegue@oss.nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.