From: Chao Yu <chao@kernel.org>
To: akpm@linux-foundation.org, adobriyan@gmail.com
Cc: viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Chao Yu <chao@kernel.org>
Subject: [PATCH v2] proc: remove mark_inode_dirty() in .setattr()
Date: Tue, 31 Jan 2023 23:08:40 +0800 [thread overview]
Message-ID: <20230131150840.34726-1-chao@kernel.org> (raw)
procfs' .setattr() has updated i_uid, i_gid and i_mode into proc
dirent, we don't need to call mark_inode_dirty() for delayed
update, remove it.
Signed-off-by: Chao Yu <chao@kernel.org>
---
v2:
- remove mark_inode_dirty() from proc_setattr() and proc_sys_setattr()
as well.
fs/proc/base.c | 1 -
fs/proc/generic.c | 1 -
fs/proc/proc_sysctl.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/fs/proc/base.c b/fs/proc/base.c
index 9e479d7d202b..16236fe9b9fe 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -699,7 +699,6 @@ int proc_setattr(struct user_namespace *mnt_userns, struct dentry *dentry,
return error;
setattr_copy(&init_user_ns, inode, attr);
- mark_inode_dirty(inode);
return 0;
}
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index 5f52f20d5ed1..f547e9593a77 100644
--- a/fs/proc/generic.c
+++ b/fs/proc/generic.c
@@ -127,7 +127,6 @@ static int proc_notify_change(struct user_namespace *mnt_userns,
return error;
setattr_copy(&init_user_ns, inode, iattr);
- mark_inode_dirty(inode);
proc_set_user(de, inode->i_uid, inode->i_gid);
de->mode = inode->i_mode;
diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c
index 48f2d60bd78a..4e71d18e610e 100644
--- a/fs/proc/proc_sysctl.c
+++ b/fs/proc/proc_sysctl.c
@@ -841,7 +841,6 @@ static int proc_sys_setattr(struct user_namespace *mnt_userns,
return error;
setattr_copy(&init_user_ns, inode, attr);
- mark_inode_dirty(inode);
return 0;
}
--
2.36.1
next reply other threads:[~2023-01-31 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 15:08 Chao Yu [this message]
2023-02-07 18:17 ` [PATCH v2] proc: remove mark_inode_dirty() in .setattr() Alexey Dobriyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230131150840.34726-1-chao@kernel.org \
--to=chao@kernel.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.