All of lore.kernel.org
 help / color / mirror / Atom feed
From: sbabic@denx.de
To: Detlev Casanova <detlev.casanova@collabora.com>,u-boot@lists.denx.de
Subject: [PATCH v3] imx6q-sabrelite: Re-add mmc aliases
Date: Tue, 31 Jan 2023 17:52:27 +0100 (CET)	[thread overview]
Message-ID: <20230131165230.151FF85B18@phobos.denx.de> (raw)
In-Reply-To: <20221208181552.36921-1-detlev.casanova@collabora.com>

> In commit d0399a46e7cda63c07e3eb8558bef84cfb068028, the device tree was
> synchronized from linux and the aliases were dropped.
> They need to be kept so that the mmc cards are in the right order.
> Without the aliases, u-boot reports:
> MMC:   FSL_SDHC: 2, FSL_SDHC: 3
> With the aliases, u-boot reports:
> MMC:   FSL_SDHC: 0, FSL_SDHC: 1
> The upstream linux device tree does not contain the same aliases than
> u-boot (It keeps the devices order with /dev/mmcblk2 and /dev/mmcblk3).
> Because this board has been using different aliases in u-boot
> and linux, a imx6q-sabrelite-u-boot.dtsi file is added to be
> automatically included in imx6q-sabrelite.dts.
> This way, linux and u-boot each keep their own aliases and there
> is no breakage on current installations.
> This should never be done for new boards as we want to keep linux and
> u-boot with the same aliases as much as possible.
> This patch is only necessary to avoid breaking existing setups.
> Signed-off-by: Detlev Casanova <detlev.casanova@collabora.com>
> Reviewed-by: Fabio Estevam <festevam@denx.de>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,        Managing Director: Erika Unter  
HRB 165235 Munich,   Office: Kirchenstr.5, 82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================

  parent reply	other threads:[~2023-01-31 16:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-08 15:23 [PATCH v2] imx6: Re-add mmc aliases Detlev Casanova
2022-12-08 16:55 ` Fabio Estevam
2022-12-08 18:15   ` [PATCH v3] imx6q-sabrelite: " Detlev Casanova
2022-12-08 18:37     ` Fabio Estevam
2023-01-31 16:52     ` sbabic [this message]
2022-12-09 11:01 ` [PATCH v2] imx6: " Peter Robinson
2022-12-09 13:46   ` Detlev Casanova

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230131165230.151FF85B18@phobos.denx.de \
    --to=sbabic@denx.de \
    --cc=detlev.casanova@collabora.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.