From: Jakub Kicinski <kuba@kernel.org>
To: Michael Kelley <mikelley@microsoft.com>
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/1] hv_netvsc: Fix missed pagebuf entries in netvsc_dma_map/unmap()
Date: Wed, 1 Feb 2023 21:01:07 -0800 [thread overview]
Message-ID: <20230201210107.450ff5d3@kernel.org> (raw)
In-Reply-To: <1675135986-254490-1-git-send-email-mikelley@microsoft.com>
On Mon, 30 Jan 2023 19:33:06 -0800 Michael Kelley wrote:
> @@ -990,9 +987,7 @@ static int netvsc_dma_map(struct hv_device *hv_dev,
> struct hv_netvsc_packet *packet,
> struct hv_page_buffer *pb)
> {
> - u32 page_count = packet->cp_partial ?
> - packet->page_buf_cnt - packet->rmsg_pgcnt :
> - packet->page_buf_cnt;
> + u32 page_count = packet->page_buf_cnt;
> dma_addr_t dma;
> int i;
Suspiciously, the caller still does:
if (packet->cp_partial)
pb += packet->rmsg_pgcnt;
ret = netvsc_dma_map(ndev_ctx->device_ctx, packet, pb);
Shouldn't that if () pb +=... also go away?
next prev parent reply other threads:[~2023-02-02 5:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 3:33 [PATCH net 1/1] hv_netvsc: Fix missed pagebuf entries in netvsc_dma_map/unmap() Michael Kelley
2023-01-31 17:01 ` Haiyang Zhang
2023-02-02 5:01 ` Jakub Kicinski [this message]
2023-02-02 5:20 ` Michael Kelley (LINUX)
2023-02-02 8:30 ` Paolo Abeni
2023-02-02 19:24 ` Michael Kelley (LINUX)
2023-02-02 8:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230201210107.450ff5d3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikelley@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.