* [linux-stable-rc:queue/4.19 1/66] drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled'
@ 2023-02-01 13:35 kernel test robot
2023-02-02 3:48 ` cuigaosheng
0 siblings, 1 reply; 3+ messages in thread
From: kernel test robot @ 2023-02-01 13:35 UTC (permalink / raw)
To: Gaosheng Cui; +Cc: oe-kbuild-all, Sasha Levin, Krzysztof Kozlowski
tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.19
head: 923e939ad273761d537bc8b4e314e7fbac1d975d
commit: e283c92e9ef8852a075bed84d3427a0704159f9c [1/66] memory: atmel-sdramc: Fix missing clk_disable_unprepare in atmel_ramc_probe()
config: arm-defconfig (https://download.01.org/0day-ci/archive/20230201/202302012152.IA9WllvH-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=e283c92e9ef8852a075bed84d3427a0704159f9c
git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
git fetch --no-tags linux-stable-rc queue/4.19
git checkout e283c92e9ef8852a075bed84d3427a0704159f9c
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
drivers/memory/atmel-sdramc.c: In function 'atmel_ramc_probe':
>> drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration]
62 | clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
| ^~~~~~~~~~~~~~~~~~~~
drivers/memory/atmel-sdramc.c:62:21: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
62 | clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
| ^
drivers/memory/atmel-sdramc.c:68:21: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
68 | clk = devm_clk_get_enabled(&pdev->dev, "mpddr");
| ^
cc1: some warnings being treated as errors
vim +/devm_clk_get_enabled +62 drivers/memory/atmel-sdramc.c
53
54 static int atmel_ramc_probe(struct platform_device *pdev)
55 {
56 const struct at91_ramc_caps *caps;
57 struct clk *clk;
58
59 caps = of_device_get_match_data(&pdev->dev);
60
61 if (caps->has_ddrck) {
> 62 clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
63 if (IS_ERR(clk))
64 return PTR_ERR(clk);
65 }
66
67 if (caps->has_mpddr_clk) {
68 clk = devm_clk_get_enabled(&pdev->dev, "mpddr");
69 if (IS_ERR(clk)) {
70 pr_err("AT91 RAMC: couldn't get mpddr clock\n");
71 return PTR_ERR(clk);
72 }
73 }
74
75 return 0;
76 }
77
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-stable-rc:queue/4.19 1/66] drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled'
2023-02-01 13:35 [linux-stable-rc:queue/4.19 1/66] drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled' kernel test robot
@ 2023-02-02 3:48 ` cuigaosheng
2023-02-03 12:41 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: cuigaosheng @ 2023-02-02 3:48 UTC (permalink / raw)
To: kernel test robot; +Cc: oe-kbuild-all, Sasha Levin, Krzysztof Kozlowski
Thanks for reporting the issue, this patch depends on the following patches:
7ef9651e9792 clk: Provide new devm_clk helpers for prepared and enabled clocks
abae8e57e49a clk: generalize devm_clk_get() a bit
we can fix the issue by applying them, thanks for Sasha's work again!
Gaosheng.
On 2023/2/1 21:35, kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git queue/4.19
> head: 923e939ad273761d537bc8b4e314e7fbac1d975d
> commit: e283c92e9ef8852a075bed84d3427a0704159f9c [1/66] memory: atmel-sdramc: Fix missing clk_disable_unprepare in atmel_ramc_probe()
> config: arm-defconfig (https://download.01.org/0day-ci/archive/20230201/202302012152.IA9WllvH-lkp@intel.com/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=e283c92e9ef8852a075bed84d3427a0704159f9c
> git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> git fetch --no-tags linux-stable-rc queue/4.19
> git checkout e283c92e9ef8852a075bed84d3427a0704159f9c
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm olddefconfig
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/
>
> If you fix the issue, kindly add following tag where applicable
> | Reported-by: kernel test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> drivers/memory/atmel-sdramc.c: In function 'atmel_ramc_probe':
>>> drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled' [-Werror=implicit-function-declaration]
> 62 | clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/memory/atmel-sdramc.c:62:21: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 62 | clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
> | ^
> drivers/memory/atmel-sdramc.c:68:21: warning: assignment to 'struct clk *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 68 | clk = devm_clk_get_enabled(&pdev->dev, "mpddr");
> | ^
> cc1: some warnings being treated as errors
>
>
> vim +/devm_clk_get_enabled +62 drivers/memory/atmel-sdramc.c
>
> 53
> 54 static int atmel_ramc_probe(struct platform_device *pdev)
> 55 {
> 56 const struct at91_ramc_caps *caps;
> 57 struct clk *clk;
> 58
> 59 caps = of_device_get_match_data(&pdev->dev);
> 60
> 61 if (caps->has_ddrck) {
> > 62 clk = devm_clk_get_enabled(&pdev->dev, "ddrck");
> 63 if (IS_ERR(clk))
> 64 return PTR_ERR(clk);
> 65 }
> 66
> 67 if (caps->has_mpddr_clk) {
> 68 clk = devm_clk_get_enabled(&pdev->dev, "mpddr");
> 69 if (IS_ERR(clk)) {
> 70 pr_err("AT91 RAMC: couldn't get mpddr clock\n");
> 71 return PTR_ERR(clk);
> 72 }
> 73 }
> 74
> 75 return 0;
> 76 }
> 77
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [linux-stable-rc:queue/4.19 1/66] drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled'
2023-02-02 3:48 ` cuigaosheng
@ 2023-02-03 12:41 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-03 12:41 UTC (permalink / raw)
To: cuigaosheng, kernel test robot; +Cc: oe-kbuild-all, Sasha Levin
On 02/02/2023 04:48, cuigaosheng wrote:
> Thanks for reporting the issue, this patch depends on the following patches:
> 7ef9651e9792 clk: Provide new devm_clk helpers for prepared and enabled clocks
> abae8e57e49a clk: generalize devm_clk_get() a bit
> we can fix the issue by applying them, thanks for Sasha's work again!
>
Or just drop the backports.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-03 12:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-01 13:35 [linux-stable-rc:queue/4.19 1/66] drivers/memory/atmel-sdramc.c:62:23: error: implicit declaration of function 'devm_clk_get_enabled' kernel test robot
2023-02-02 3:48 ` cuigaosheng
2023-02-03 12:41 ` Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.