Re: [RFC PATCH] drm/pancsf: Add a new driver for Mali CSF-based GPUs

[kernel test robot <lkp@intel.com>]

Hi Boris,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on drm-misc/drm-misc-next]
[also build test WARNING on drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm-tip/drm-tip linus/master v6.2-rc6 next-20230201]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Boris-Brezillon/drm-pancsf-Add-a-new-driver-for-Mali-CSF-based-GPUs/20230201-172815
base:   git://anongit.freedesktop.org/drm/drm-misc drm-misc-next
patch link:    https://lore.kernel.org/r/20230201084832.1708866-1-boris.brezillon%40collabora.com
patch subject: [RFC PATCH] drm/pancsf: Add a new driver for Mali CSF-based GPUs
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230202/202302020210.bkPwVPew-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/794ce1c0209242bf1496fc4195ca707d45b37e73
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Boris-Brezillon/drm-pancsf-Add-a-new-driver-for-Mali-CSF-based-GPUs/20230201-172815
        git checkout 794ce1c0209242bf1496fc4195ca707d45b37e73
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/gpu/drm/pancsf/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/pancsf/pancsf_drv.c:65:5: warning: no previous prototype for 'pancsf_ioctl_vm_create' [-Wmissing-prototypes]
      65 | int pancsf_ioctl_vm_create(struct drm_device *ddev, void *data,
         |     ^~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/pancsf/pancsf_drv.c:84:5: warning: no previous prototype for 'pancsf_ioctl_vm_destroy' [-Wmissing-prototypes]
      84 | int pancsf_ioctl_vm_destroy(struct drm_device *ddev, void *data,
         |     ^~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/pancsf/pancsf_drv.c:258:1: warning: no previous prototype for 'pancsf_free_sync_signal_array' [-Wmissing-prototypes]
     258 | pancsf_free_sync_signal_array(struct pancsf_sync_signal_array *array)
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/pancsf/pancsf_drv.c:273:1: warning: no previous prototype for 'pancsf_collect_sync_signal_array' [-Wmissing-prototypes]
     273 | pancsf_collect_sync_signal_array(struct drm_file *file,
         | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   drivers/gpu/drm/pancsf/pancsf_drv.c: In function 'pancsf_collect_sync_signal_array':
   drivers/gpu/drm/pancsf/pancsf_drv.c:290:21: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     290 |                 int ret;
         |                     ^~~
   drivers/gpu/drm/pancsf/pancsf_drv.c: In function 'pancsf_mmap_io':
>> drivers/gpu/drm/pancsf/pancsf_drv.c:628:9: warning: conversion from 'long long unsigned int' to 'long unsigned int' changes value from '18446462598732840960' to '0' [-Woverflow]
     628 |         case DRM_PANCSF_USER_FLUSH_ID_MMIO_OFFSET:
         |         ^~~~


vim +628 drivers/gpu/drm/pancsf/pancsf_drv.c

   618	
   619	static int pancsf_mmap_io(struct file *filp, struct vm_area_struct *vma)
   620	{
   621		struct drm_file *priv = filp->private_data;
   622		struct pancsf_file *pfile = priv->driver_priv;
   623		struct pancsf_device *pfdev = pfile->pfdev;
   624		phys_addr_t phys_offset;
   625		size_t size;
   626	
   627		switch (vma->vm_pgoff << PAGE_SHIFT) {
 > 628		case DRM_PANCSF_USER_FLUSH_ID_MMIO_OFFSET:
   629			size = PAGE_SIZE;
   630			phys_offset = 0;
   631			break;
   632		default:
   633			return -EINVAL;
   634		}
   635	
   636		if (vma->vm_end - vma->vm_start != size)
   637			return -EINVAL;
   638	
   639		vma->vm_flags |= VM_IO | VM_DONTCOPY | VM_DONTEXPAND | VM_NORESERVE |
   640				 VM_DONTDUMP | VM_PFNMAP;
   641	
   642		vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
   643	
   644		return io_remap_pfn_range(vma,
   645					  vma->vm_start,
   646					  (pfdev->phys_addr + phys_offset) >> PAGE_SHIFT,
   647					  size,
   648					  vma->vm_page_prot);
   649	}
   650	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests