From: Jakub Kicinski <kuba@kernel.org>
To: Qingfang DENG <dqfext@gmail.com>
Cc: Jesper Dangaard Brouer <hawk@kernel.org>,
Ilias Apalodimas <ilias.apalodimas@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: page_pool: use in_softirq() instead
Date: Thu, 2 Feb 2023 10:06:40 -0800 [thread overview]
Message-ID: <20230202100640.350fcd08@kernel.org> (raw)
In-Reply-To: <20230201220105.410fee4c@kernel.org>
On Wed, 1 Feb 2023 22:01:05 -0800 Jakub Kicinski wrote:
> On Thu, 2 Feb 2023 10:44:17 +0800 Qingfang DENG wrote:
> > From: Qingfang DENG <qingfang.deng@siflower.com.cn>
> >
> > We use BH context only for synchronization, so we don't care if it's
> > actually serving softirq or not.
> >
> > As a side node, in case of threaded NAPI, in_serving_softirq() will
> > return false because it's in process context with BH off, making
> > page_pool_recycle_in_cache() unreachable.
>
> LGTM, but I don't think this qualifies as a fix.
> It's just a missed optimization, right?
Well, nobody seems to have disagreed with me in 12h, so please drop the
Fixes tags and repost against net-next :)
next prev parent reply other threads:[~2023-02-02 18:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 2:44 [PATCH net] net: page_pool: use in_softirq() instead Qingfang DENG
2023-02-02 6:01 ` Jakub Kicinski
2023-02-02 18:06 ` Jakub Kicinski [this message]
2023-02-02 8:59 ` Leon Romanovsky
2023-02-03 11:15 ` Jesper Dangaard Brouer
2023-02-03 13:05 ` DENG Qingfang
2023-02-06 10:18 ` Jesper Dangaard Brouer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202100640.350fcd08@kernel.org \
--to=kuba@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=ilias.apalodimas@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.