From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, drivers@pensando.io
Subject: Re: [PATCH net 3/6] ionic: add check for NULL t/rxqcqs in reconfig
Date: Thu, 2 Feb 2023 12:46:15 -0800 [thread overview]
Message-ID: <20230202124615.1bf1a2f9@kernel.org> (raw)
In-Reply-To: <917e57c0-fd37-18a8-a418-c439badb7d41@amd.com>
On Thu, 2 Feb 2023 12:06:52 -0800 Shannon Nelson wrote:
> On 2/2/23 10:05 AM, Jakub Kicinski wrote:
> > On Wed, 1 Feb 2023 17:29:59 -0800 Shannon Nelson wrote:
> >> Make sure there are qcqs to clean before trying to swap resources
> >> or clean their interrupt assignments.
> >
> > ... Otherwise $what-may-happen
> >
> > Bug fixes should come with an explanation of what the user-visible
> > misbehavior is
>
> I can add some text here and post a v2.
>
> Would you prefer I repost some of these as net-next rather than net as
> Leon was suggesting, or keep this patchset together for v2? I have a
> couple other larger net-next patches getting ready as well...
I'm not sure what the user impact of the fixes is, but at a glance
splitting this into separate series makes most sense. We merge net
into net-next every Thu, so if there is a dependency the wait should
not be too long.
next prev parent reply other threads:[~2023-02-02 20:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 1:29 [PATCH net 0/6] ionic: code maintenance Shannon Nelson
2023-02-02 1:29 ` [PATCH net 1/6] ionic: remove unnecessary indirection Shannon Nelson
2023-02-02 8:43 ` Leon Romanovsky
2023-02-02 1:29 ` [PATCH net 2/6] ionic: remove unnecessary void casts Shannon Nelson
2023-02-02 8:43 ` Leon Romanovsky
2023-02-02 1:29 ` [PATCH net 3/6] ionic: add check for NULL t/rxqcqs in reconfig Shannon Nelson
2023-02-02 8:44 ` Leon Romanovsky
2023-02-02 18:05 ` Jakub Kicinski
2023-02-02 20:06 ` Shannon Nelson
2023-02-02 20:46 ` Jakub Kicinski [this message]
2023-02-02 20:55 ` Shannon Nelson
2023-02-02 1:30 ` [PATCH net 4/6] ionic: clean interrupt before enabling queue to avoid credit race Shannon Nelson
2023-02-02 8:46 ` Leon Romanovsky
2023-02-02 1:30 ` [PATCH net 5/6] ionic: clear up notifyq alloc commentary Shannon Nelson
2023-02-02 8:46 ` Leon Romanovsky
2023-02-02 1:30 ` [PATCH net 6/6] ionic: missed doorbell workaround Shannon Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202124615.1bf1a2f9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.