From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0BBBEC636D4 for ; Fri, 3 Feb 2023 15:12:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vtjJbhRUnIwDjwbdk1bQgEUwgfoCI5g5RK9Fd9mZgjw=; b=IHWCl+zyzFvyV/ uYrJh1OhzpuC6ze646vlWnMA+i1H0DbyZkKX88OLPm7MgLh+SD6XWZ1yG4VEpb/ZbtxxeSdvLYFbe 5ZVQoDgJ5GrkH9wSyVjZ9MnBvVBQXEJPsvAn/d9YHsUKQgRaTTL3jGw7f7Y0+tvEYf2CYjrpAIE+Y yL0wiksp4B/Da8o0p+PywTu/zOmPUZ8/UxZCrXPzA+198PU6nkZnWSVUOmqPj2yp9o46GTKuBBbRm K64VTN4WnI7HQsIhM6rng0UJ4ngvTwqh5DXL8e/NwfyKEgxe0lnqUqWeqqeLj7EjfN6NSYS4Ho3L2 cEiNQ5fWGq8e2Op/tK4g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxjc-002dpy-Bt; Fri, 03 Feb 2023 15:12:16 +0000 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxjX-002dlb-LH for linux-mtd@lists.infradead.org; Fri, 03 Feb 2023 15:12:14 +0000 Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BACBF4000B; Fri, 3 Feb 2023 15:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675437126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fgonYy5kf0HaJcOsNAlLRss28D6PMmH9gqHFpX6dh2A=; b=VU3LhwPORdLdOo9J3/3gGJ1WgBCWKGJsOTr2bJDho2mIByMUvrpRzWC0dXrrcHgR4sgt1U GJhFbRe8kilQk9HqxH2uODDKDrOsuaCm+AHvkHlCOL07/eKGPY4FgghklIQCr8BkW1nztu NV8TpHq69bVdmEh20BM7g0GEkYZv38YL+A3YYw8OdQW90/3ZS/duUXIWMBNMyG6Z/pobEz mxb1Eucf+he1UNIVzko/estx/OBrAxiN8g3Mgkk+za+g0DCdPjPBpp8I26/PTq9rAeyQiA kBpkFymDRH2SPOsT4dl1OsR9bwkoYpHxSv3hRK1nUMqH2bmdY8U4qPReTFRHAA== Date: Fri, 3 Feb 2023 16:12:02 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Marek Vasut , Francesco Dolcini , u-boot@lists.denx.de Subject: Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0 Message-ID: <20230203161202.76f3b057@xps-13> In-Reply-To: References: <20230124104444.330913-1-francesco@dolcini.it> <20230126101204.245ace0d@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_071212_236450_7B4C03E7 X-CRM114-Status: GOOD ( 47.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGkgRnJhbmNlc2NvLAoKZnJhbmNlc2NvQGRvbGNpbmkuaXQgd3JvdGUgb24gVGh1LCAyIEZlYiAy MDIzIDEyOjMzOjM0ICswMTAwOgoKPiBPbiBUaHUsIEphbiAyNiwgMjAyMyBhdCAxMDoxMjowNEFN ICswMTAwLCBNaXF1ZWwgUmF5bmFsIHdyb3RlOgo+ID4gZ3JlZ2toQGxpbnV4Zm91bmRhdGlvbi5v cmcgd3JvdGUgb24gVGh1LCAyNiBKYW4gMjAyMyAxMDowMTowMiArMDEwMDoKPiA+ICAgCj4gPiA+ IE9uIFdlZCwgSmFuIDI1LCAyMDIzIGF0IDEwOjA2OjU3UE0gKzAxMDAsIEZyYW5jZXNjbyBEb2xj aW5pIHdyb3RlOiAgCj4gPiA+ID4gSGVsbG8gTWlxdWVsLCBHcmVnIGFuZCBhbGwKPiA+ID4gPiAK PiA+ID4gPiBPbiBUdWUsIEphbiAyNCwgMjAyMyBhdCAwNDozODo1OVBNICswMTAwLCBHcmVnIEty b2FoLUhhcnRtYW4gd3JvdGU6ICAgIAo+ID4gPiA+ID4gT24gVHVlLCBKYW4gMjQsIDIwMjMgYXQg MTE6NDQ6NDRBTSArMDEwMCwgRnJhbmNlc2NvIERvbGNpbmkgd3JvdGU6ICAgIAo+ID4gPiA+ID4g PiBGcm9tOiBGcmFuY2VzY28gRG9sY2luaSA8ZnJhbmNlc2NvLmRvbGNpbmlAdG9yYWRleC5jb20+ Cj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBBZGQgYSBtZWNoYW5pc20gdG8gaGFuZGxlIHRoZSBj YXNlIGluIHdoaWNoIHBhcnRpdGlvbnMgYXJlIHByZXNlbnQgYXMKPiA+ID4gPiA+ID4gZGlyZWN0 IGNoaWxkIG9mIHRoZSBuYW5kIGNvbnRyb2xsZXIgbm9kZSBhbmQgI3NpemUtY2VsbHMgaXMgc2V0 IHRvIDwwPi4KPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IFRoaXMgY291bGQgaGFwcGVuIGlmIHRo ZSBuYW5kLWNvbnRyb2xsZXIgbm9kZSBpbiB0aGUgRFRTIGlzIHN1cHBvc2VkIHRvCj4gPiA+ID4g PiA+IGhhdmUgI3NpemUtY2VsbHMgc2V0IHRvIDAsIGJ1dCBmb3Igc29tZSBoaXN0b3JpY2FsIHJl YXNvbi9idWcgaXQgd2FzIHNldAo+ID4gPiA+ID4gPiB0byAxIGluIHRoZSBwYXN0LCBhbmQgdGhl IGZpcm13YXJlIChlLmcuIFUtQm9vdCkgaXMgYWRkaW5nIHRoZSBwYXJ0aXRpb24KPiA+ID4gPiA+ ID4gYXMgZGlyZWN0IGNoaWxkcmVuIG9mIHRoZSBuYW5kLWNvbnRyb2xsZXIgZGVmYXVsdGluZyB0 byAjc2l6ZS1jZWxscwo+ID4gPiA+ID4gPiBiZWluZyB0byAxLgo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gVGhpcyBwcmV2ZW50cyBhIHJlYWwgYm9vdCBmYWlsdXJlIG9uIGNvbGlicmktaW14NyB0 aGF0IGhhcHBlbmVkIGR1cmluZyB2Ni4xCj4gPiA+ID4gPiA+IGRldmVsb3BtZW50IGN5Y2xlcy4K PiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IExpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2Fs bC9ZNGRnQlRHTldwTTZTUVhJQGZyYW5jZXNjby1uYi5pbnQudG9yYWRleC5jb20vCj4gPiA+ID4g PiA+IExpbms6IGh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL2FsbC8yMDIyMTIwMjA3MTkwMC4xMTQz OTUwLTEtZnJhbmNlc2NvQGRvbGNpbmkuaXQvCj4gPiA+ID4gPiA+IFNpZ25lZC1vZmYtYnk6IEZy YW5jZXNjbyBEb2xjaW5pIDxmcmFuY2VzY28uZG9sY2luaUB0b3JhZGV4LmNvbT4KPiA+ID4gPiA+ ID4gUmV2aWV3ZWQtYnk6IEdyZWcgS3JvYWgtSGFydG1hbiA8Z3JlZ2toQGxpbnV4Zm91bmRhdGlv bi5vcmc+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiBJIGRvIG5vdCBleHBlY3QgdGhpcyBw YXRjaCB0byBiZSBiYWNrcG9ydGVkIHRvIHN0YWJsZSwgaG93ZXZlciBJIHdvdWxkIGV4cGVjdAo+ ID4gPiA+ID4gPiB0aGF0IHdlIGRvIG5vdCBiYWNrcG9ydCBuYW5kLWNvbnRyb2xsZXIgZHRzIGNs ZWFudXBzIG5laXRoZXIuCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiB2NDoKPiA+ID4gPiA+ID4g IGZpeGVkIHdyb25nIEVuZ2xpc2ggc3BlbGxpbmcgaW4gdGhlIGNvbW1lbnQKPiA+ID4gPiA+ID4g Cj4gPiA+ID4gPiA+IHYzOgo+ID4gPiA+ID4gPiAgbWlub3IgZm9ybWF0dGluZyBjaGFuZ2UsIHJl bW92ZWQgbm90IG5lZWRlZCBuZXctbGluZSBhbmQgc3BhY2UuIAo+ID4gPiA+ID4gPiAKPiA+ID4g PiA+ID4gdjI6Cj4gPiA+ID4gPiA+ICBmaXh1cCBzaXplLWNlbGxzIG9ubHkgd2hlbiBwYXJ0aXRp b25zIGFyZSBkaXJlY3QgY2hpbGRyZW4gb2YgdGhlIG5hbmQtY29udHJvbGxlcgo+ID4gPiA+ID4g PiAgY29tcGxldGVseSByZXZpc2VkIGNvbW1pdCBtZXNzYWdlLCBjb21tZW50cyBhbmQgd2Fybmlu ZyBwcmludAo+ID4gPiA+ID4gPiAgdXNlIHByX3dhcm4gaW5zdGVhZCBvZiBwcl93YXJuX29uY2UK PiA+ID4gPiA+ID4gIGFkZGVkIFJldmlld2VkLWJ5IEdyZWcKPiA+ID4gPiA+ID4gIHJlbW92ZWQg Y2M6c3RhYmxlQCBhbmQgZml4ZXMgdGFnLCBzaW5jZSB0aGUgcHJvYmxlbWF0aWMgY29tbWl0IHdh cyByZXZlcnRlZAo+ID4gPiA+ID4gPiAtLS0KPiA+ID4gPiA+ID4gIGRyaXZlcnMvbXRkL3BhcnNl cnMvb2ZwYXJ0X2NvcmUuYyB8IDE5ICsrKysrKysrKysrKysrKysrKysKPiA+ID4gPiA+ID4gIDEg ZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspCj4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9tdGQvcGFyc2Vycy9vZnBhcnRfY29yZS5jIGIvZHJpdmVycy9t dGQvcGFyc2Vycy9vZnBhcnRfY29yZS5jCj4gPiA+ID4gPiA+IGluZGV4IDE5MjE5MGM0MmZjOC4u ZTdiOGU5ZDBhOTEwIDEwMDY0NAo+ID4gPiA+ID4gPiAtLS0gYS9kcml2ZXJzL210ZC9wYXJzZXJz L29mcGFydF9jb3JlLmMKPiA+ID4gPiA+ID4gKysrIGIvZHJpdmVycy9tdGQvcGFyc2Vycy9vZnBh cnRfY29yZS5jCj4gPiA+ID4gPiA+IEBAIC0xMjIsNiArMTIyLDI1IEBAIHN0YXRpYyBpbnQgcGFy c2VfZml4ZWRfcGFydGl0aW9ucyhzdHJ1Y3QgbXRkX2luZm8gKm1hc3RlciwKPiA+ID4gPiA+ID4g IAo+ID4gPiA+ID4gPiAgCQlhX2NlbGxzID0gb2Zfbl9hZGRyX2NlbGxzKHBwKTsKPiA+ID4gPiA+ ID4gIAkJc19jZWxscyA9IG9mX25fc2l6ZV9jZWxscyhwcCk7Cj4gPiA+ID4gPiA+ICsJCWlmICgh ZGVkaWNhdGVkICYmIHNfY2VsbHMgPT0gMCkgewo+ID4gPiA+ID4gPiArCQkJLyoKPiA+ID4gPiA+ ID4gKwkJCSAqIFRoaXMgaXMgYSB1Z2x5IHdvcmthcm91bmQgdG8gbm90IGNyZWF0ZQo+ID4gPiA+ ID4gPiArCQkJICogcmVncmVzc2lvbiBvbiBkZXZpY2VzIHRoYXQgYXJlIHN0aWxsIGNyZWF0aW5n Cj4gPiA+ID4gPiA+ICsJCQkgKiBwYXJ0aXRpb25zIGFzIGRpcmVjdCBjaGlsZHJlbiBvZiB0aGUg bmFuZCBjb250cm9sbGVyLgo+ID4gPiA+ID4gPiArCQkJICogVGhpcyBjYW4gaGFwcGVuIGluIGNh c2UgdGhlIG5hbmQgY29udHJvbGxlciBub2RlIGhhcwo+ID4gPiA+ID4gPiArCQkJICogI3NpemUt Y2VsbHMgZXF1YWwgdG8gMCBhbmQgdGhlIGZpcm13YXJlIChlLmcuCj4gPiA+ID4gPiA+ICsJCQkg KiBVLUJvb3QpIGp1c3QgYWRkIHRoZSBwYXJ0aXRpb25zIHRoZXJlIGFzc3VtaW5nCj4gPiA+ID4g PiA+ICsJCQkgKiAzMi1iaXQgYWRkcmVzc2luZy4KPiA+ID4gPiA+ID4gKwkJCSAqCj4gPiA+ID4g PiA+ICsJCQkgKiBJZiB5b3UgZ2V0IHRoaXMgd2FybmluZyB5b3VyIGZpcm13YXJlIGFuZC9vciBE VFMKPiA+ID4gPiA+ID4gKwkJCSAqIHNob3VsZCBiZSByZWFsbHkgZml4ZWQuCj4gPiA+ID4gPiA+ ICsJCQkgKgo+ID4gPiA+ID4gPiArCQkJICogVGhpcyBpcyB3b3JraW5nIG9ubHkgZm9yIGRldmlj ZXMgc21hbGxlciB0aGFuIDRHaUIuCj4gPiA+ID4gPiA+ICsJCQkgKi8KPiA+ID4gPiA+ID4gKwkJ CXByX3dhcm4oIiVzOiBvZnBhcnQgcGFydGl0aW9uICVwT0YgKCVwT0YpICNzaXplLWNlbGxzIGlz IHdyb25nbHkgc2V0IHRvIDwwPiwgYXNzdW1pbmcgPDE+IGZvciBwYXJzaW5nIHBhcnRpdGlvbnMu XG4iLAo+ID4gPiA+ID4gPiArCQkJCW1hc3Rlci0+bmFtZSwgcHAsIG10ZF9ub2RlKTsgICAgCj4g PiA+ID4gPiAKPiA+ID4gPiA+IFRoaXMgaXMgYSBkcml2ZXIsIGFsd2F5cyB1c2UgZGV2XyooKSBj YWxscywgbm90IHByXyooKSBjYWxscyBzbyB0aGF0IHdlCj4gPiA+ID4gPiBrbm93IHdoYXQgaXMg YmVpbmcgcmVmZXJyZWQgdG8gZXhhY3RseS4gICAgCj4gPiA+ID4gCj4gPiA+ID4gSXMgdGhpcyBy ZWFzb25hYmxlIGhlcmU/IFdoZXJlIGNhbiBJIGdldCB0aGUgc3RydWN0IGRldmljZT8gICAgCj4g PiA+IAo+ID4gPiBXYWxrIGJhY2sgdXAgdGhlIGNhbGwgY2hhaW4sIHRoZXJlIGhhcyB0byBiZSBh IGRldmljZSBzb21ld2hlcmUKPiA+ID4gY29udHJvbGxpbmcgdGhpcywgcmlnaHQ/Cj4gPiA+ICAg Cj4gPiA+ID4gSW4gZ2VuZXJhbCB0aGlzIGZpbGUgdXNlcyBvbmx5IHByXyogZGVidWcgQVBJIGFu ZCBtZXNzYWdlcyBhcmUgYWJvdXQgT0YKPiA+ID4gPiBub2Rlcy9wcm9wZXJ0aWVzLCBub3QgYWJv dXQgYSBkZXZpY2UuICAgIAo+ID4gPiAKPiA+ID4gT0Ygbm9kZXMgYW5kIHByb3BlcnRpZXMgYXJl IHBhcnQgb2YgYSBkZXZpY2UncyBwcm9wZXJ0aWVzIDopICAKPiA+IAo+ID4gWWVzIGJ1dCB0aGUg d2FybmluZyBjb21lcyBmcm9tIGEgd3JvbmcgRFQgZGVzY3JpcHRpb24sIGhlbmNlIGl0IGZlbHQK PiA+IGJldHRlciBzdWl0ZWQgdG8gd2FybiBhZ2FpbnN0IHRoZSBub2RlIG5hbWUgd2hpY2ggaXMg ZWFzaWx5IGlkZW50aWZpYWJsZQo+ID4gaW4gYSB0ZXh0IGZpbGUgYW5kIG11c3QgYmUgZml4ZWQg cmF0aGVyIHRoYW4gdGhlIGRldmljZSB3aGljaCBpcyBhIHB1cmUKPiA+IHNvZnR3YXJlIGNvbXBv bmVudC4KPiA+IAo+ID4gQW55d2F5LCBGcmFuY2VzY28sIHBsZWFzZSBzaG93IHVzIHRoZSByZXN1 bHRhbnQgbGluZSBhbmQgaWYgaXQgZmVlbHMKPiA+IG1lYW5pbmdmdWwgZW5vdWdoIHdlJ2xsIHRh a2UgdGhlIGRldl93YXJuIGFwcHJvYWNoLiAgCj4gCj4gU28sIEkgdHJpZWQsIGJ1dCBJIGd1ZXNz IEkgZmFpbGVkLgo+IAo+IEJvdGgKPiAKPiAgIGRldl93YXJuKCZtdGRfZ2V0X21hc3RlcihtYXN0 ZXIpLT5kZXYsIC4uLik7Cj4gCj4gYW5kCj4gCj4gICBkZXZfd2FybigmbWFzdGVyLT5kZXYsIC4u Lik7Cj4gCj4gYXJlIE5VTEwuCgptdGQtPmRldiAoaW4gcmF3IE5BTkQpIGlzIHBvcHVsYXRlZCBi eSB0aGUgY29udHJvbGxlciBkcml2ZXJzLCBzbyB0aGUKbWFzdGVyIG10ZCBkZXZpY2UgaXMgcG9p bnRpbmcgdG8gdGhlIGJ1cyAic3RydWN0IGRldmljZSIgaW4gaXRzCmRldi5wYXJlbnQgZmllbGQu IFRoaXMgaGFwcGVucyBhdCB0aGUgZW5kIG9mIHRoZSBwcm9iZSBvZiB0aGUKY29udHJvbGxlciwg YWZ0ZXIgc2V0dGluZyB0aGUgZGV2IGVudHJ5LCBzbyB3ZSBleHBlY3QgdGhlIG5hbWUgb2YgdGhl CmNvbnRyb2xsZXIgdG8gYXBwZWFyLgoKPiAobnVsbCk6IGdwbWktbmFuZDogb2ZwYXJ0IHBhcnRp dGlvbiAvc29jL25hbmQtY29udHJvbGxlckAzMzAwMjAwMC9wYXJ0aXRpb25AMCAoL3NvYy9uYW5k LWNvbnRyb2xsZXJAMzMwMDIwMDApICNzaXplLWNlbGxzIGlzIHdyb25nbHkgc2V0IHRvIDwwPiwg YXNzdW1pbmcgPDE+IGZvciBwYXJzaW5nIHBhcnRpdGlvbnMuCgpTZWNvbmQgZmllbGQgbG9va3Mg cmlnaHQsIGZpcnN0IGZpZWxkIGRvZXMgbm90IChidXMgb3IgY2xhc3MgaWQ/KSBJCmhhdmUgbm8g aWRlYSB3aHkgaXQgaGFzIG5vdCBiZWVuIHBvcHVsYXRlZCBhdCB0aGlzIHBvaW50IChlbmQgb2Yg dGhlCmNvbnRyb2xsZXIgcHJvYmUpLiBCdXQgaXQncyBub3QgYSBiaWcgZGVhbCwgYXQgbGVhc3Qg d2UgaGF2ZSB0aGUgZGV2aWNlCm5hbWUsIHNvIGl0J3Mgb2sgZm9yIG1lLgoKPiB3aGlsZSB0aGUg Y3VycmVudCB2NCBpcyBqdXN0Ogo+IAo+IGdwbWktbmFuZDogb2ZwYXJ0IHBhcnRpdGlvbiAvc29j L25hbmQtY29udHJvbGxlckAzMzAwMjAwMC9wYXJ0aXRpb25AMCAoL3NvYy9uYW5kLWNvbnRyb2xs ZXJAMzMwMDIwMDApICNzaXplLWNlbGxzIGlzIHdyb25nbHkgc2V0IHRvIDwwPiwgYXNzdW1pbmcg PDE+IGZvciBwYXJzaW5nIHBhcnRpdGlvbnMuCj4gCj4gb24gYSBjb2xpYnJpLWlteDcuCj4gCj4g QW55IGFkdmljZT8KPiAKPiBGcmFuY2VzY28KPiAKCgpUaGFua3MsCk1pcXXDqGwKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQg ZGlzY3Vzc2lvbiBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1h bi9saXN0aW5mby9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 018C9C64EC4 for ; Fri, 3 Feb 2023 15:12:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E049385F53; Fri, 3 Feb 2023 16:12:13 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=bootlin.com header.i=@bootlin.com header.b="VU3LhwPO"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 00F8085D17; Fri, 3 Feb 2023 16:12:12 +0100 (CET) Received: from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net [217.70.183.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 24F1A8545E for ; Fri, 3 Feb 2023 16:12:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=miquel.raynal@bootlin.com Received: (Authenticated sender: miquel.raynal@bootlin.com) by mail.gandi.net (Postfix) with ESMTPSA id BACBF4000B; Fri, 3 Feb 2023 15:12:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1675437126; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fgonYy5kf0HaJcOsNAlLRss28D6PMmH9gqHFpX6dh2A=; b=VU3LhwPORdLdOo9J3/3gGJ1WgBCWKGJsOTr2bJDho2mIByMUvrpRzWC0dXrrcHgR4sgt1U GJhFbRe8kilQk9HqxH2uODDKDrOsuaCm+AHvkHlCOL07/eKGPY4FgghklIQCr8BkW1nztu NV8TpHq69bVdmEh20BM7g0GEkYZv38YL+A3YYw8OdQW90/3ZS/duUXIWMBNMyG6Z/pobEz mxb1Eucf+he1UNIVzko/estx/OBrAxiN8g3Mgkk+za+g0DCdPjPBpp8I26/PTq9rAeyQiA kBpkFymDRH2SPOsT4dl1OsR9bwkoYpHxSv3hRK1nUMqH2bmdY8U4qPReTFRHAA== Date: Fri, 3 Feb 2023 16:12:02 +0100 From: Miquel Raynal To: Francesco Dolcini Cc: Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Richard Weinberger , Vignesh Raghavendra , Marek Vasut , Francesco Dolcini , u-boot@lists.denx.de Subject: Re: [PATCH v4] mtd: parsers: ofpart: add workaround for #size-cells 0 Message-ID: <20230203161202.76f3b057@xps-13> In-Reply-To: References: <20230124104444.330913-1-francesco@dolcini.it> <20230126101204.245ace0d@xps-13> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Hi Francesco, francesco@dolcini.it wrote on Thu, 2 Feb 2023 12:33:34 +0100: > On Thu, Jan 26, 2023 at 10:12:04AM +0100, Miquel Raynal wrote: > > gregkh@linuxfoundation.org wrote on Thu, 26 Jan 2023 10:01:02 +0100: > > =20 > > > On Wed, Jan 25, 2023 at 10:06:57PM +0100, Francesco Dolcini wrote: =20 > > > > Hello Miquel, Greg and all > > > >=20 > > > > On Tue, Jan 24, 2023 at 04:38:59PM +0100, Greg Kroah-Hartman wrote:= =20 > > > > > On Tue, Jan 24, 2023 at 11:44:44AM +0100, Francesco Dolcini wrote= : =20 > > > > > > From: Francesco Dolcini > > > > > >=20 > > > > > > Add a mechanism to handle the case in which partitions are pres= ent as > > > > > > direct child of the nand controller node and #size-cells is set= to <0>. > > > > > >=20 > > > > > > This could happen if the nand-controller node in the DTS is sup= posed to > > > > > > have #size-cells set to 0, but for some historical reason/bug i= t was set > > > > > > to 1 in the past, and the firmware (e.g. U-Boot) is adding the = partition > > > > > > as direct children of the nand-controller defaulting to #size-c= ells > > > > > > being to 1. > > > > > >=20 > > > > > > This prevents a real boot failure on colibri-imx7 that happened= during v6.1 > > > > > > development cycles. > > > > > >=20 > > > > > > Link: https://lore.kernel.org/all/Y4dgBTGNWpM6SQXI@francesco-nb= .int.toradex.com/ > > > > > > Link: https://lore.kernel.org/all/20221202071900.1143950-1-fran= cesco@dolcini.it/ > > > > > > Signed-off-by: Francesco Dolcini > > > > > > Reviewed-by: Greg Kroah-Hartman > > > > > > --- > > > > > > I do not expect this patch to be backported to stable, however = I would expect > > > > > > that we do not backport nand-controller dts cleanups neither. > > > > > >=20 > > > > > > v4: > > > > > > fixed wrong English spelling in the comment > > > > > >=20 > > > > > > v3: > > > > > > minor formatting change, removed not needed new-line and space= .=20 > > > > > >=20 > > > > > > v2: > > > > > > fixup size-cells only when partitions are direct children of t= he nand-controller > > > > > > completely revised commit message, comments and warning print > > > > > > use pr_warn instead of pr_warn_once > > > > > > added Reviewed-by Greg > > > > > > removed cc:stable@ and fixes tag, since the problematic commit= was reverted > > > > > > --- > > > > > > drivers/mtd/parsers/ofpart_core.c | 19 +++++++++++++++++++ > > > > > > 1 file changed, 19 insertions(+) > > > > > >=20 > > > > > > diff --git a/drivers/mtd/parsers/ofpart_core.c b/drivers/mtd/pa= rsers/ofpart_core.c > > > > > > index 192190c42fc8..e7b8e9d0a910 100644 > > > > > > --- a/drivers/mtd/parsers/ofpart_core.c > > > > > > +++ b/drivers/mtd/parsers/ofpart_core.c > > > > > > @@ -122,6 +122,25 @@ static int parse_fixed_partitions(struct m= td_info *master, > > > > > > =20 > > > > > > a_cells =3D of_n_addr_cells(pp); > > > > > > s_cells =3D of_n_size_cells(pp); > > > > > > + if (!dedicated && s_cells =3D=3D 0) { > > > > > > + /* > > > > > > + * This is a ugly workaround to not create > > > > > > + * regression on devices that are still creating > > > > > > + * partitions as direct children of the nand controller. > > > > > > + * This can happen in case the nand controller node has > > > > > > + * #size-cells equal to 0 and the firmware (e.g. > > > > > > + * U-Boot) just add the partitions there assuming > > > > > > + * 32-bit addressing. > > > > > > + * > > > > > > + * If you get this warning your firmware and/or DTS > > > > > > + * should be really fixed. > > > > > > + * > > > > > > + * This is working only for devices smaller than 4GiB. > > > > > > + */ > > > > > > + pr_warn("%s: ofpart partition %pOF (%pOF) #size-cells is wr= ongly set to <0>, assuming <1> for parsing partitions.\n", > > > > > > + master->name, pp, mtd_node); =20 > > > > >=20 > > > > > This is a driver, always use dev_*() calls, not pr_*() calls so t= hat we > > > > > know what is being referred to exactly. =20 > > > >=20 > > > > Is this reasonable here? Where can I get the struct device? =20 > > >=20 > > > Walk back up the call chain, there has to be a device somewhere > > > controlling this, right? > > > =20 > > > > In general this file uses only pr_* debug API and messages are abou= t OF > > > > nodes/properties, not about a device. =20 > > >=20 > > > OF nodes and properties are part of a device's properties :) =20 > >=20 > > Yes but the warning comes from a wrong DT description, hence it felt > > better suited to warn against the node name which is easily identifiable > > in a text file and must be fixed rather than the device which is a pure > > software component. > >=20 > > Anyway, Francesco, please show us the resultant line and if it feels > > meaningful enough we'll take the dev_warn approach. =20 >=20 > So, I tried, but I guess I failed. >=20 > Both >=20 > dev_warn(&mtd_get_master(master)->dev, ...); >=20 > and >=20 > dev_warn(&master->dev, ...); >=20 > are NULL. mtd->dev (in raw NAND) is populated by the controller drivers, so the master mtd device is pointing to the bus "struct device" in its dev.parent field. This happens at the end of the probe of the controller, after setting the dev entry, so we expect the name of the controller to appear. > (null): gpmi-nand: ofpart partition /soc/nand-controller@33002000/partiti= on@0 (/soc/nand-controller@33002000) #size-cells is wrongly set to <0>, ass= uming <1> for parsing partitions. Second field looks right, first field does not (bus or class id?) I have no idea why it has not been populated at this point (end of the controller probe). But it's not a big deal, at least we have the device name, so it's ok for me. > while the current v4 is just: >=20 > gpmi-nand: ofpart partition /soc/nand-controller@33002000/partition@0 (/s= oc/nand-controller@33002000) #size-cells is wrongly set to <0>, assuming <1= > for parsing partitions. >=20 > on a colibri-imx7. >=20 > Any advice? >=20 > Francesco >=20 Thanks, Miqu=C3=A8l