From: Eric Biggers <ebiggers@kernel.org>
To: linux-hardening@vger.kernel.org, Kees Cook <keescook@chromium.org>
Cc: llvm@lists.linux.dev, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: [PATCH] randstruct: temporarily disable clang support
Date: Fri, 3 Feb 2023 11:42:01 -0800 [thread overview]
Message-ID: <20230203194201.92015-1-ebiggers@kernel.org> (raw)
From: Eric Biggers <ebiggers@google.com>
Randstruct with clang is currently unsafe to use in any clang release
that supports it, due to a clang bug that is causing miscompilations:
"-frandomize-layout-seed inconsistently randomizes all-function-pointers
structs" (https://github.com/llvm/llvm-project/issues/60349). Disable
it temporarily until the bug is fixed and the fix is released in a clang
version that can be checked for.
Fixes: 035f7f87b729 ("randstruct: Enable Clang support")
Cc: stable@vger.kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
---
security/Kconfig.hardening | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/security/Kconfig.hardening b/security/Kconfig.hardening
index 53baa95cb644..aad16187148c 100644
--- a/security/Kconfig.hardening
+++ b/security/Kconfig.hardening
@@ -280,7 +280,8 @@ config ZERO_CALL_USED_REGS
endmenu
config CC_HAS_RANDSTRUCT
- def_bool $(cc-option,-frandomize-layout-seed-file=/dev/null)
+ # Temporarily disabled due to https://github.com/llvm/llvm-project/issues/60349
+ def_bool n
choice
prompt "Randomize layout of sensitive kernel structures"
base-commit: 7b753a909f426f2789d9db6f357c3d59180a9354
--
2.39.1
next reply other threads:[~2023-02-03 19:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-03 19:42 Eric Biggers [this message]
2023-02-04 19:06 ` [PATCH] randstruct: temporarily disable clang support Kees Cook
2023-02-06 23:41 ` Fangrui Song
2023-02-07 18:01 ` Nick Desaulniers
2023-02-08 6:55 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230203194201.92015-1-ebiggers@kernel.org \
--to=ebiggers@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.