From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4325C05027 for ; Mon, 6 Feb 2023 13:37:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 9F25F1E9; Mon, 6 Feb 2023 14:36:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 9F25F1E9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675690662; bh=06llItq3OgrONTHisa13nIfm5l9ZtJLDr8aom1oC+R0=; h=Date:From:To:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=kKd902cZzDh0KW7w92AXFKUOf7KC60VLuOiliInmOF0ZV8//iMG702V73Cw0FgELK v69l9o0UoNtcryyfKQM81ys0yjy7WVk6peK7d9ma1UDjeNcakgbq/GfvdflZldllTc g2i1cvvHD6Z9Nlw3s7rTdlNce06EFRO3QJYkfxbc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 1AAA6F80564; Mon, 6 Feb 2023 14:35:13 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 713CDF80169; Fri, 3 Feb 2023 21:57:58 +0100 (CET) Received: from mail-ot1-f52.google.com (mail-ot1-f52.google.com [209.85.210.52]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 0D697F8001D for ; Fri, 3 Feb 2023 21:57:51 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 0D697F8001D Received: by mail-ot1-f52.google.com with SMTP id g21-20020a9d6495000000b0068bb336141dso1737690otl.11 for ; Fri, 03 Feb 2023 12:57:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DTUpcYkNxPIlJHACYCYR7pDb1Buy+e4lFP4bk5Zgp34=; b=NyVKYchIRv3ha/CLOAGt3R6mUbUM9V7sT99EsF6fLvnSrHI8zgFeii63jf3rHt7nv6 8x+pfyR84Cr5R45mSslbyOiwlbThhpdv74jw1XPl0ppxo9x3OLWNPtEQEPpihE1VoVUw P4iLFUvy6pREY+5Lf4OIdtNwUuXQl9sBV06uoGAB83fcjgrQe1J+zr4dFTpq4qINi/xU NptxWX9ddQulWdzkLp4cK/EF2713rFiheUeSUft8BZaPNhi/pVV+QXkFIHA0Yazl2xBU +i5c1JpVmsULw/RMHQOvwqbSj8v/v389OKJ7Htget/Gd2O0v9lZxcwECd08z2QocF5GJ ckIw== X-Gm-Message-State: AO0yUKUN3ET4hlZWVG3+q1qb0pK7WLDMdrvpKihNei9OxWvokygryd5E 6h5Dq96jLHQVAs3oBGKFlA== X-Google-Smtp-Source: AK7set/idxy63+ygBDyPnMqtJWkCkCzx9MyU4A+nT1Br4FymPkR4Z0JILK7N/Htqiz/3btTinW8cgQ== X-Received: by 2002:a05:6830:1e57:b0:68b:b721:8f1c with SMTP id e23-20020a0568301e5700b0068bb7218f1cmr6718583otj.27.1675457869992; Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c22-20020a9d6856000000b0068bd5af9b82sm1611458oto.43.2023.02.03.12.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: (nullmailer pid 873929 invoked by uid 1000); Fri, 03 Feb 2023 20:57:48 -0000 Date: Fri, 3 Feb 2023 14:57:48 -0600 From: Rob Herring To: Gatien Chevallier Subject: Re: [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Message-ID: <20230203205748.GA860175-robh@kernel.org> References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-3-gatien.chevallier@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127164040.1047583-3-gatien.chevallier@foss.st.com> X-Mailman-Approved-At: Mon, 06 Feb 2023 14:35:03 +0100 X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ulf.hansson@linaro.org, linux-iio@vger.kernel.org, alexandre.torgue@foss.st.com, edumazet@google.com, Oleksii_Moisieiev@epam.com, krzysztof.kozlowski+dt@linaro.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, herbert@gondor.apana.org.au, olivier.moysan@foss.st.com, kuba@kernel.org, arnaud.pouliquen@foss.st.com, pabeni@redhat.com, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, fabrice.gasnier@foss.st.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, vkoul@kernel.org, linux-crypto@vger.kernel.org, netdev@vger.kernel.org, dmaengine@vger.kernel.org, davem@davemloft.net, jic23@kernel.org, linux-i2c@vger.kernel.org Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On Fri, Jan 27, 2023 at 05:40:36PM +0100, Gatien Chevallier wrote: > feature-domains is an optional property that allows a peripheral to > refer to one or more feature domain controller(s). > > Description of this property is added to all peripheral binding files of > the peripheral under the STM32 System Bus. It allows an accurate > representation of the hardware, where various peripherals are connected > to this firewall bus. The firewall can then check the peripheral accesses > before allowing it to probe. > > Signed-off-by: Gatien Chevallier > --- > > Patch not present in V1 and V2. > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 5 +++++ > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 5 +++++ > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-cec.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 5 +++++ > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 6 ++++++ > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++ > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 5 +++++ > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 5 +++++ > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 5 +++++ > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 5 +++++ > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 5 +++++ > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 5 +++++ > Documentation/devicetree/bindings/usb/dwc2.yaml | 5 +++++ > 24 files changed, 121 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > index 4ccb335e8063..cb2ad7d5fdb5 100644 > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > @@ -41,6 +41,11 @@ properties: > maximum: 2 > default: 0 > > + feature-domains: > + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains Not how common properties work. Consumer properties should be in a schema with 'select: true' (the one you are referencing) and here you just need to define the entries. Like clocks, power-domains, etc. > + minItems: 1 > + maxItems: 3 Why is this variable and what is each entry? I still don't like the naming. Everything is a feature and a domain... It might be a bit easier to come up with a name with multiple users of this binding presented. I'm hesistant to define any new common binding with only 1 user as I've said multiple times on this binding. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 041D5C05027 for ; Fri, 3 Feb 2023 20:57:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229657AbjBCU5x (ORCPT ); Fri, 3 Feb 2023 15:57:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43234 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbjBCU5w (ORCPT ); Fri, 3 Feb 2023 15:57:52 -0500 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C104F928F2; Fri, 3 Feb 2023 12:57:50 -0800 (PST) Received: by mail-ot1-f46.google.com with SMTP id 70-20020a9d084c000000b0068bccf754f1so1742405oty.7; Fri, 03 Feb 2023 12:57:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DTUpcYkNxPIlJHACYCYR7pDb1Buy+e4lFP4bk5Zgp34=; b=D6kjA0iDCoHbJoW0/A85Gd/DEhgeFoqvSv2XUAWEbb1o+0YfaV5M3siOzoHq6v+lem V8B6SLkgyxx/W3zB640h3M9fhSuQRaR8LNQQOuiUzmt1QdoYEVcn76JrF6ewHHqp3BxN Hy2T0sAe3/8AOzMRx9zYqk92gEFBgmAH0ufB0/8eI8xfuhJfuVaupJ3T1XZ1archyji/ Nola6qXtDnqlRQdvhMBBBSETrlm+Jd6/+GcxoM2hwr0JFnTnXCwe2grgSZIh27ikr6Um mpX2POkA56H64IeN4GJVZ1uydAwgcMldwGbymiD8KpgUN+uUj18tRkFOctge3sIMEhyG 8cTg== X-Gm-Message-State: AO0yUKVPGuB7WkOnxV5ZFvTP+YeGM2mRoFmSfcEhOqt90HjqZ1lrYGhk EH1ec8I1KvYGvqaHgJ3Iqw== X-Google-Smtp-Source: AK7set/idxy63+ygBDyPnMqtJWkCkCzx9MyU4A+nT1Br4FymPkR4Z0JILK7N/Htqiz/3btTinW8cgQ== X-Received: by 2002:a05:6830:1e57:b0:68b:b721:8f1c with SMTP id e23-20020a0568301e5700b0068bb7218f1cmr6718583otj.27.1675457869992; Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c22-20020a9d6856000000b0068bd5af9b82sm1611458oto.43.2023.02.03.12.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: (nullmailer pid 873929 invoked by uid 1000); Fri, 03 Feb 2023 20:57:48 -0000 Date: Fri, 3 Feb 2023 14:57:48 -0600 From: Rob Herring To: Gatien Chevallier Cc: Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org, herbert@gondor.apana.org.au, davem@davemloft.net, krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com, vkoul@kernel.org, jic23@kernel.org, olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com, mchehab@kernel.org, fabrice.gasnier@foss.st.com, ulf.hansson@linaro.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Message-ID: <20230203205748.GA860175-robh@kernel.org> References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-3-gatien.chevallier@foss.st.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230127164040.1047583-3-gatien.chevallier@foss.st.com> Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org On Fri, Jan 27, 2023 at 05:40:36PM +0100, Gatien Chevallier wrote: > feature-domains is an optional property that allows a peripheral to > refer to one or more feature domain controller(s). > > Description of this property is added to all peripheral binding files of > the peripheral under the STM32 System Bus. It allows an accurate > representation of the hardware, where various peripherals are connected > to this firewall bus. The firewall can then check the peripheral accesses > before allowing it to probe. > > Signed-off-by: Gatien Chevallier > --- > > Patch not present in V1 and V2. > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 5 +++++ > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 5 +++++ > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-cec.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 5 +++++ > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 6 ++++++ > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++ > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 5 +++++ > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 5 +++++ > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 5 +++++ > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 5 +++++ > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 5 +++++ > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 5 +++++ > Documentation/devicetree/bindings/usb/dwc2.yaml | 5 +++++ > 24 files changed, 121 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > index 4ccb335e8063..cb2ad7d5fdb5 100644 > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > @@ -41,6 +41,11 @@ properties: > maximum: 2 > default: 0 > > + feature-domains: > + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains Not how common properties work. Consumer properties should be in a schema with 'select: true' (the one you are referencing) and here you just need to define the entries. Like clocks, power-domains, etc. > + minItems: 1 > + maxItems: 3 Why is this variable and what is each entry? I still don't like the naming. Everything is a feature and a domain... It might be a bit easier to come up with a name with multiple users of this binding presented. I'm hesistant to define any new common binding with only 1 user as I've said multiple times on this binding. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E95D7C05027 for ; Fri, 3 Feb 2023 20:58:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m4N9Xg2OyakoD+vb502/d5scLPfpckW2VGDfOMjc3pY=; b=O3QTLoSNcrp/qv xlCDacWbGg9kls7CXXwm8ysaYUqC7I4C/zL29GT/UwWBSBG9HbXyRsQ6LEKNQxrUoBnP2IpuHwHmm uwABCswxootTfGnQLwRnMnfH7YirHFbNzMblosaZdP/33/x60xyw6jSzmLkCDfpIu/EzshOCaCrSz Nwph5ymdUr4NRv5nhA6oiLJRuRj4g731E+tirzV8U501Ea92XKxpnvoDvTNHeTKquYmUpJ3jj4Ot8 So8ZGtgx9za8Qj6WC6bq3kCBIISQaIRIB6qn5h4vJBRGVLbQvFXL8yG7sTJqoyzwYPhZmhqGsgdXK uF/4qEeS2r+79gHQqSNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO38K-003ZOg-05; Fri, 03 Feb 2023 20:58:08 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO383-003ZKK-J2; Fri, 03 Feb 2023 20:57:56 +0000 Received: by mail-ot1-f52.google.com with SMTP id e12-20020a0568301e4c00b0068bc93e7e34so1745903otj.4; Fri, 03 Feb 2023 12:57:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DTUpcYkNxPIlJHACYCYR7pDb1Buy+e4lFP4bk5Zgp34=; b=DZDjnoi9XT9ajcLaMCbM/fzZ8y/GakfMdy65VvRRHYvZ5kK2Y6nxmIs1Op13dkf23F DjVuH8GR0Tlg2ewqIlnNLKwWGBj9jEPKaghCjPIv0QDtBTljJp8A06k7uLSwcmQ7Ap+Z OeKasFPWGXvSZDCCZH7tXMIzy3dOJVQoXvb+yHL+Ga0iNhyntZf7amcCmcTOeizPoTMA +TZ3BvlOcmGKJg8H8esWbjvAXd2Oq2MnVOGa2Ih5erJAlOmQJCgx9fcpRhoSf0HtgRnD FwU7QRGT/k7/HfvEZSSHdWsgRNJW2uGpKEotBvHeGYe7kVu6xkY3JSsTjQRhK6UJ7c4E M/GA== X-Gm-Message-State: AO0yUKWoDnipPafcxcENer6h4lDJrewhC8q8TR2CXnGpVL03Bz9VBSWj 4itc+hx/Ybc/qIHz9SWiYA== X-Google-Smtp-Source: AK7set/idxy63+ygBDyPnMqtJWkCkCzx9MyU4A+nT1Br4FymPkR4Z0JILK7N/Htqiz/3btTinW8cgQ== X-Received: by 2002:a05:6830:1e57:b0:68b:b721:8f1c with SMTP id e23-20020a0568301e5700b0068bb7218f1cmr6718583otj.27.1675457869992; Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c22-20020a9d6856000000b0068bd5af9b82sm1611458oto.43.2023.02.03.12.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: (nullmailer pid 873929 invoked by uid 1000); Fri, 03 Feb 2023 20:57:48 -0000 Date: Fri, 3 Feb 2023 14:57:48 -0600 From: Rob Herring To: Gatien Chevallier Cc: Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org, herbert@gondor.apana.org.au, davem@davemloft.net, krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com, vkoul@kernel.org, jic23@kernel.org, olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com, mchehab@kernel.org, fabrice.gasnier@foss.st.com, ulf.hansson@linaro.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Message-ID: <20230203205748.GA860175-robh@kernel.org> References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-3-gatien.chevallier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127164040.1047583-3-gatien.chevallier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_125752_677362_2F45FEF4 X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 05:40:36PM +0100, Gatien Chevallier wrote: > feature-domains is an optional property that allows a peripheral to > refer to one or more feature domain controller(s). > > Description of this property is added to all peripheral binding files of > the peripheral under the STM32 System Bus. It allows an accurate > representation of the hardware, where various peripherals are connected > to this firewall bus. The firewall can then check the peripheral accesses > before allowing it to probe. > > Signed-off-by: Gatien Chevallier > --- > > Patch not present in V1 and V2. > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 5 +++++ > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 5 +++++ > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-cec.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 5 +++++ > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 6 ++++++ > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++ > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 5 +++++ > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 5 +++++ > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 5 +++++ > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 5 +++++ > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 5 +++++ > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 5 +++++ > Documentation/devicetree/bindings/usb/dwc2.yaml | 5 +++++ > 24 files changed, 121 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > index 4ccb335e8063..cb2ad7d5fdb5 100644 > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > @@ -41,6 +41,11 @@ properties: > maximum: 2 > default: 0 > > + feature-domains: > + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains Not how common properties work. Consumer properties should be in a schema with 'select: true' (the one you are referencing) and here you just need to define the entries. Like clocks, power-domains, etc. > + minItems: 1 > + maxItems: 3 Why is this variable and what is each entry? I still don't like the naming. Everything is a feature and a domain... It might be a bit easier to come up with a name with multiple users of this binding presented. I'm hesistant to define any new common binding with only 1 user as I've said multiple times on this binding. Rob -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE346C61DA4 for ; Fri, 3 Feb 2023 20:58:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BRp2ziDCpe7dfUkKlOkxk7rFJvw22lCF3PHwyroonU4=; b=QXPSUH+GBSSzhm 79CQVvfcfyGBWXDP1GUTmDFgzGXr0kvjC6CeGyEDlhQHCJAcjA0+HqCMxvvWoC3gTcUxMdggROzY7 2Wvws8zZEesNUVB05n7lkAbjTGzE87/5O8wn1sdv5IQeioQKcfyqTnnXc3xDxXvDTCBx9o4FmWUH2 mIyoC9njUFYLkcAZz3UFlP+uKqPzIabR6O9+nvy2iAynk4QG9+l4y5nYcoa/GU/eNfbfmfC9qMtQz CBf/8gpIDMeDgejR2zXjsfdqBkOnvq+9blZPH032WChZlnDkbbfN86ceOSTXPlYnX4Egxs9agJS9X KLOzXWNhFgaVjnMd7sIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO38C-003ZN5-KS; Fri, 03 Feb 2023 20:58:00 +0000 Received: from mail-ot1-f52.google.com ([209.85.210.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pO383-003ZKK-J2; Fri, 03 Feb 2023 20:57:56 +0000 Received: by mail-ot1-f52.google.com with SMTP id e12-20020a0568301e4c00b0068bc93e7e34so1745903otj.4; Fri, 03 Feb 2023 12:57:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DTUpcYkNxPIlJHACYCYR7pDb1Buy+e4lFP4bk5Zgp34=; b=DZDjnoi9XT9ajcLaMCbM/fzZ8y/GakfMdy65VvRRHYvZ5kK2Y6nxmIs1Op13dkf23F DjVuH8GR0Tlg2ewqIlnNLKwWGBj9jEPKaghCjPIv0QDtBTljJp8A06k7uLSwcmQ7Ap+Z OeKasFPWGXvSZDCCZH7tXMIzy3dOJVQoXvb+yHL+Ga0iNhyntZf7amcCmcTOeizPoTMA +TZ3BvlOcmGKJg8H8esWbjvAXd2Oq2MnVOGa2Ih5erJAlOmQJCgx9fcpRhoSf0HtgRnD FwU7QRGT/k7/HfvEZSSHdWsgRNJW2uGpKEotBvHeGYe7kVu6xkY3JSsTjQRhK6UJ7c4E M/GA== X-Gm-Message-State: AO0yUKWoDnipPafcxcENer6h4lDJrewhC8q8TR2CXnGpVL03Bz9VBSWj 4itc+hx/Ybc/qIHz9SWiYA== X-Google-Smtp-Source: AK7set/idxy63+ygBDyPnMqtJWkCkCzx9MyU4A+nT1Br4FymPkR4Z0JILK7N/Htqiz/3btTinW8cgQ== X-Received: by 2002:a05:6830:1e57:b0:68b:b721:8f1c with SMTP id e23-20020a0568301e5700b0068bb7218f1cmr6718583otj.27.1675457869992; Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id c22-20020a9d6856000000b0068bd5af9b82sm1611458oto.43.2023.02.03.12.57.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Feb 2023 12:57:49 -0800 (PST) Received: (nullmailer pid 873929 invoked by uid 1000); Fri, 03 Feb 2023 20:57:48 -0000 Date: Fri, 3 Feb 2023 14:57:48 -0600 From: Rob Herring To: Gatien Chevallier Cc: Oleksii_Moisieiev@epam.com, gregkh@linuxfoundation.org, herbert@gondor.apana.org.au, davem@davemloft.net, krzysztof.kozlowski+dt@linaro.org, alexandre.torgue@foss.st.com, vkoul@kernel.org, jic23@kernel.org, olivier.moysan@foss.st.com, arnaud.pouliquen@foss.st.com, mchehab@kernel.org, fabrice.gasnier@foss.st.com, ulf.hansson@linaro.org, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-crypto@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, alsa-devel@alsa-project.org, linux-media@vger.kernel.org, linux-mmc@vger.kernel.org, netdev@vger.kernel.org, linux-phy@lists.infradead.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH v3 2/6] dt-bindings: treewide: add feature-domains description in binding files Message-ID: <20230203205748.GA860175-robh@kernel.org> References: <20230127164040.1047583-1-gatien.chevallier@foss.st.com> <20230127164040.1047583-3-gatien.chevallier@foss.st.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230127164040.1047583-3-gatien.chevallier@foss.st.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_125752_677362_2F45FEF4 X-CRM114-Status: GOOD ( 19.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 27, 2023 at 05:40:36PM +0100, Gatien Chevallier wrote: > feature-domains is an optional property that allows a peripheral to > refer to one or more feature domain controller(s). > > Description of this property is added to all peripheral binding files of > the peripheral under the STM32 System Bus. It allows an accurate > representation of the hardware, where various peripherals are connected > to this firewall bus. The firewall can then check the peripheral accesses > before allowing it to probe. > > Signed-off-by: Gatien Chevallier > --- > > Patch not present in V1 and V2. > > Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dma.yaml | 5 +++++ > Documentation/devicetree/bindings/dma/st,stm32-dmamux.yaml | 5 +++++ > Documentation/devicetree/bindings/i2c/st,stm32-i2c.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/adc/st,stm32-adc.yaml | 5 +++++ > .../devicetree/bindings/iio/adc/st,stm32-dfsdm-adc.yaml | 5 +++++ > Documentation/devicetree/bindings/iio/dac/st,stm32-dac.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-cec.yaml | 5 +++++ > Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 5 +++++ > .../bindings/memory-controllers/st,stm32-fmc2-ebi.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-lptimer.yaml | 5 +++++ > Documentation/devicetree/bindings/mfd/st,stm32-timers.yaml | 6 ++++++ > Documentation/devicetree/bindings/mmc/arm,pl18x.yaml | 5 +++++ > Documentation/devicetree/bindings/net/stm32-dwmac.yaml | 5 +++++ > .../devicetree/bindings/phy/phy-stm32-usbphyc.yaml | 5 +++++ > .../devicetree/bindings/regulator/st,stm32-vrefbuf.yaml | 5 +++++ > Documentation/devicetree/bindings/rng/st,stm32-rng.yaml | 5 +++++ > Documentation/devicetree/bindings/serial/st,stm32-uart.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-i2s.yaml | 5 +++++ > Documentation/devicetree/bindings/sound/st,stm32-sai.yaml | 5 +++++ > .../devicetree/bindings/sound/st,stm32-spdifrx.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-qspi.yaml | 5 +++++ > Documentation/devicetree/bindings/spi/st,stm32-spi.yaml | 5 +++++ > Documentation/devicetree/bindings/usb/dwc2.yaml | 5 +++++ > 24 files changed, 121 insertions(+) > > diff --git a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > index 4ccb335e8063..cb2ad7d5fdb5 100644 > --- a/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > +++ b/Documentation/devicetree/bindings/crypto/st,stm32-hash.yaml > @@ -41,6 +41,11 @@ properties: > maximum: 2 > default: 0 > > + feature-domains: > + $ref: /schemas/feature-controllers/feature-domain-controller.yaml#/properties/feature-domains Not how common properties work. Consumer properties should be in a schema with 'select: true' (the one you are referencing) and here you just need to define the entries. Like clocks, power-domains, etc. > + minItems: 1 > + maxItems: 3 Why is this variable and what is each entry? I still don't like the naming. Everything is a feature and a domain... It might be a bit easier to come up with a name with multiple users of this binding presented. I'm hesistant to define any new common binding with only 1 user as I've said multiple times on this binding. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel