From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE4CC05027 for ; Mon, 6 Feb 2023 18:42:15 +0000 (UTC) Received: from mailout4.zoneedit.com (mailout4.zoneedit.com [64.68.198.64]) by mx.groups.io with SMTP id smtpd.web11.62325.1675708928607680141 for ; Mon, 06 Feb 2023 10:42:09 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: denix.org, ip: 64.68.198.64, mailfrom: denis@denix.org) Received: from localhost (localhost [127.0.0.1]) by mailout4.zoneedit.com (Postfix) with ESMTP id DF98940C37; Mon, 6 Feb 2023 18:42:07 +0000 (UTC) Received: from mailout4.zoneedit.com ([127.0.0.1]) by localhost (zmo14-pco.easydns.vpn [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Z2lzNc5fGxNQ; Mon, 6 Feb 2023 18:42:07 +0000 (UTC) Received: from mail.denix.org (pool-100-15-88-116.washdc.fios.verizon.net [100.15.88.116]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mailout4.zoneedit.com (Postfix) with ESMTPSA id 9AC8E40BA9; Mon, 6 Feb 2023 18:42:01 +0000 (UTC) Received: by mail.denix.org (Postfix, from userid 1000) id BFE00163716; Mon, 6 Feb 2023 13:41:39 -0500 (EST) Date: Mon, 6 Feb 2023 13:41:39 -0500 From: Denys Dmytriyenko To: p-bhagat@ti.com Cc: meta-arago@lists.yoctoproject.org, praneeth@ti.com, reatmon@ti.com, c-shilwant@ti.com, s-adivi@ti.com, g-gupta@ti.com Subject: Re: [meta-arago] [dunfell][PATCH] ti-tisdk-makefile: Makefile_linux-dtbs: Fix incorrect DTBO file generated by Makefile Message-ID: <20230206184139.GS22689@denix.org> References: <20230206094316.32352-1-p-bhagat@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230206094316.32352-1-p-bhagat@ti.com> User-Agent: Mutt/1.5.20 (2009-06-14) List-Id: X-Webhook-Received: from li982-79.members.linode.com [45.33.32.79] by aws-us-west-2-korg-lkml-1.web.codeaurora.org with HTTPS for ; Mon, 06 Feb 2023 18:42:15 -0000 X-Groupsio-URL: https://lists.yoctoproject.org/g/meta-arago/message/14201 On Mon, Feb 06, 2023 at 03:13:16PM +0530, Paresh Bhagat via lists.yoctoproject.org wrote: > Command "make linux-dtbs" at SDK top-level generates incorrect overlay > dtbo file. Fix it by building every device tree binary. > > Signed-off-by: Paresh Bhagat > --- > .../ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > index fa409d0a..a492ac84 100644 > --- a/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > +++ b/meta-arago-distro/recipes-tisdk/ti-tisdk-makefile/ti-tisdk-makefile/Makefile_linux-dtbs > @@ -4,9 +4,7 @@ linux-dtbs: > @echo Building the Linux Kernel DTBs > @echo ===================================== > $(MAKE) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $(DEFCONFIG) > - @for DTB in __KERNEL_DEVICETREE__; do \ > - $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) $$DTB; \ > - done > + $(MAKE) -j $(MAKE_JOBS) -C $(LINUXKERNEL_INSTALL_DIR) ARCH=__KERNEL_ARCH__ CROSS_COMPILE=$(CROSS_COMPILE) dtbs; \ This doesn't look right! What exactly do you mean by "incorrect DTBO file generated"? This is exactly how the release binaries (DTBs, DTBOs and images) are built by Yocto - going through the predefined list building them one by one. Calling "make dtbs" is a sledgehammer approach and you'll end up with hundreds of unrelated DTBs... -- Denys