From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Tue, 7 Feb 2023 10:09:09 -0500 From: "Michael S. Tsirkin" Message-ID: <20230207095919-mutt-send-email-mst@kernel.org> References: <20230207111634.75542-1-hengqi@linux.alibaba.com> <1675770628.725382-1-xuanzhuo@linux.alibaba.com> <20230207092439-mutt-send-email-mst@kernel.org> <20230207094403-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio-dev] Re: [virtio-comment] Re: [PATCH] virtio-net: support per-queue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Alvaro Karsz Cc: Parav Pandit , Xuan Zhuo , "virtio-comment @ lists . oasis-open . org" , "virtio-dev @ lists . oasis-open . org" , Jason Wang , Heng Qi List-ID: On Tue, Feb 07, 2023 at 04:56:06PM +0200, Alvaro Karsz wrote: > > An example of a question is this: we have two RX queues say 1 and 2 each > > with a distinct interrupt vector. coalescing is set to 10 packets. Now > > 9 packets arrive on queue 1 and 1 on queue 2. Do you expect an > > interrupt? If yes which one - 1 or 2 or both? > > Sorry, I wasn't clear enough. > In this case, you should not issue an interrupt until one of the > queues receives the 10'th packet. > The counters are per queue, the coalescing parameters (usecs and > max_packets) are global. > > I agree that this should be mentioned in the spec, I missed it. Right. So in my humble opinion, ability to configure parameters per queue is not completely free, as this is doubling the memory requirements. Sounds like a feature bit is somewhat justified. No? -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org