All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Neal Frager via buildroot <buildroot@buildroot.org>
Cc: michal.simek@amd.com, kris.chaplin@amd.com, terry.oneal@amd.com,
	luca.ceresoli@bootlin.com, Neal Frager <neal.frager@amd.com>
Subject: Re: [Buildroot] [PATCH v1 1/1] configs/versal_vck190_defconfig: use Xilinx github for versal-firmware
Date: Tue, 7 Feb 2023 11:43:21 +0100	[thread overview]
Message-ID: <20230207114321.2b5c2df6@windsurf> (raw)
In-Reply-To: <20230127105305.25877-1-neal.frager@amd.com>

On Fri, 27 Jan 2023 10:53:05 +0000
Neal Frager via buildroot <buildroot@buildroot.org> wrote:

> Migrate versal-firmware package from nealfrager github to Xilinx github.
> The images are identical, so this patch has zero impact on functionality.
> 
> Signed-off-by: Neal Frager <neal.frager@amd.com>
> ---
>  configs/versal_vck190_defconfig            | 2 +-
>  package/versal-firmware/Config.in          | 2 +-
>  package/versal-firmware/versal-firmware.mk | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

I've applied, but to be honest, it still looks a bit weird. The branch
on the repo is special for Buildroot, and its contents are completely
different than the master branch of the ubuntu-firmware repository. Why
are those firmware files specific to Ubuntu, or specific to Buildroot?
They should normally be distro/build-system agnostic.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-07 10:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-27 10:53 [Buildroot] [PATCH v1 1/1] configs/versal_vck190_defconfig: use Xilinx github for versal-firmware Neal Frager via buildroot
2023-02-07 10:43 ` Thomas Petazzoni via buildroot [this message]
2023-02-07 10:48   ` Frager, Neal via buildroot
2023-02-07 11:07     ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230207114321.2b5c2df6@windsurf \
    --to=buildroot@buildroot.org \
    --cc=kris.chaplin@amd.com \
    --cc=luca.ceresoli@bootlin.com \
    --cc=michal.simek@amd.com \
    --cc=neal.frager@amd.com \
    --cc=terry.oneal@amd.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.