From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "George Kelly" <george.kelly1097@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [[bitbake][PATCH]] If you are behind a corporate proxy, the npm fetcher uses the proxy IP address already passed in the list of exports. However, it will error if the proxy injects its own root CA certificate. Thus, the NODE_EXTRA_CA_CERTS environment variable must be passed so the user can include their company's root CA as a trusted CA inside node's certificate store.
Date: Tue, 7 Feb 2023 12:00:54 +0100 [thread overview]
Message-ID: <20230207120054.754519dc@booty> (raw)
In-Reply-To: <20230206191142.17353-1-george.kelly1097@gmail.com>
Hello George,
thank you for your patch.
On Mon, 6 Feb 2023 14:11:42 -0500
"George Kelly" <george.kelly1097@gmail.com> wrote:
> Signed-off-by: George Kelly <george.kelly1097@gmail.com>
I'm not qualified to review the content of your changes, but
definitely your patch needs to have a better formatting. Don't
put a long description in the first line of the got commit
message (which also ends up in the e-mail subject).
The "[[bitbake][PATCH]]" also looks weird.
I recommend you to read the guidelines at
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
in order to prepare a good commit message and to send your patch
in a way that makes it more easily reviewed, applied and tested.
Best regards,
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2023-02-07 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 19:11 [[bitbake][PATCH]] If you are behind a corporate proxy, the npm fetcher uses the proxy IP address already passed in the list of exports. However, it will error if the proxy injects its own root CA certificate. Thus, the NODE_EXTRA_CA_CERTS environment variable must be passed so the user can include their company's root CA as a trusted CA inside node's certificate store George Kelly
2023-02-07 11:00 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207120054.754519dc@booty \
--to=luca.ceresoli@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=george.kelly1097@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.