Re: [bitbake-devel] [PATCH v2] fetch2: Add path control to BB_ALLOWED_NETWORKS #bitbake

[Luca Ceresoli <luca.ceresoli@bootlin.com>]

Hello Anders,

On Tue, 07 Feb 2023 01:17:44 -0800
Anders Jørgensen via lists.openembedded.org
<anders.joergensen=advent.energy@lists.openembedded.org> wrote:

> From d08ab52c29cda8969b9f9e198d1ef2fd11d06ca4 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Anders=20J=C3=B8rgensen?= <anders.joergensen@advent.energy>
> Date: Wed, 1 Feb 2023 13:08:11 +0100
> Subject: [PATCH] fetch2: Add path control to BB_ALLOWED_NETWORKS

I'm afraid also this v2 does not apply. The few lines quoted above
suggest you did not use git send-email to send it but maybe you
forwarded another email.

I recommend you to read the guidelines at
https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
in order to prepare a good commit message and to send your patch
in a way that makes it more easily reviewed, applied and tested.

Before sending it again to the list I suggest you try to send it to
yourself and check whether it looks correct, or to send it to a
colleague or friend who can try to apply it on  a local tree.

...

> @@ -1071,12 +1071,27 @@ def trusted_network(d, url):
> 
> network = network.split(':')[0]
> network = network.lower()
> +    path = path.lower()
> +
> +    for host_path in trusted_hosts.split(" "):
> +        host_path = host_path.lower()
> +        is_trusted = False
> +        split_data = host_path.split("/", 1)
> +        host = split_data[0]
> +        trusted_path = None
> +        if len(split_data) == 2:
> +            trusted_path = "/" + split_data[1]
> 
> -    for host in trusted_hosts.split(" "):
> -        host = host.lower()
> if host.startswith("*.") and ("." + network).endswith(host[1:]):

The lines here without a leading space character clearly show that this
is not a correctly formatted patch.

Best regards,
-- 
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com