From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray
Date: Tue, 7 Feb 2023 15:53:30 +0800 [thread overview]
Message-ID: <202302071553.dxgzoPxM-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20230119235936.19728-7-rpearsonhpe@gmail.com>
References: <20230119235936.19728-7-rpearsonhpe@gmail.com>
TO: Bob Pearson <rpearsonhpe@gmail.com>
Hi Bob,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on 1ec82317a1daac78c04b0c15af89018ccf9fa2b7]
url: https://github.com/intel-lab-lkp/linux/commits/Bob-Pearson/RDMA-rxe-Cleanup-mr_check_range/20230120-080520
base: 1ec82317a1daac78c04b0c15af89018ccf9fa2b7
patch link: https://lore.kernel.org/r/20230119235936.19728-7-rpearsonhpe%40gmail.com
patch subject: [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray
:::::: branch date: 3 weeks ago
:::::: commit date: 3 weeks ago
config: s390-randconfig-m041-20230206 (https://download.01.org/0day-ci/archive/20230207/202302071553.dxgzoPxM-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/infiniband/sw/rxe/rxe_mr.c:130 rxe_mr_fill_pages_from_sgt() warn: inconsistent returns '&((&xas)->xa)->xa_lock'.
vim +130 drivers/infiniband/sw/rxe/rxe_mr.c
02ea0a511558c9 Li Zhijian 2022-12-06 98
3222da9099ca42 Bob Pearson 2023-01-19 99 static int rxe_mr_fill_pages_from_sgt(struct rxe_mr *mr, struct sg_table *sgt)
3222da9099ca42 Bob Pearson 2023-01-19 100 {
3222da9099ca42 Bob Pearson 2023-01-19 101 XA_STATE(xas, &mr->page_list, 0);
3222da9099ca42 Bob Pearson 2023-01-19 102 struct sg_page_iter sg_iter;
3222da9099ca42 Bob Pearson 2023-01-19 103 struct page *page;
3222da9099ca42 Bob Pearson 2023-01-19 104 bool persistent = !!(mr->access & IB_ACCESS_FLUSH_PERSISTENT);
3222da9099ca42 Bob Pearson 2023-01-19 105
3222da9099ca42 Bob Pearson 2023-01-19 106 __sg_page_iter_start(&sg_iter, sgt->sgl, sgt->orig_nents, 0);
3222da9099ca42 Bob Pearson 2023-01-19 107 if (!__sg_page_iter_next(&sg_iter))
3222da9099ca42 Bob Pearson 2023-01-19 108 return 0;
3222da9099ca42 Bob Pearson 2023-01-19 109
3222da9099ca42 Bob Pearson 2023-01-19 110 do {
3222da9099ca42 Bob Pearson 2023-01-19 111 xas_lock(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 112 while (true) {
3222da9099ca42 Bob Pearson 2023-01-19 113 page = sg_page_iter_page(&sg_iter);
3222da9099ca42 Bob Pearson 2023-01-19 114
3222da9099ca42 Bob Pearson 2023-01-19 115 if (persistent && !is_pmem_page(page)) {
3222da9099ca42 Bob Pearson 2023-01-19 116 rxe_dbg_mr(mr, "Page can't be persistent\n");
3222da9099ca42 Bob Pearson 2023-01-19 117 return -EINVAL;
3222da9099ca42 Bob Pearson 2023-01-19 118 }
3222da9099ca42 Bob Pearson 2023-01-19 119
3222da9099ca42 Bob Pearson 2023-01-19 120 xas_store(&xas, page);
3222da9099ca42 Bob Pearson 2023-01-19 121 if (xas_error(&xas))
3222da9099ca42 Bob Pearson 2023-01-19 122 break;
3222da9099ca42 Bob Pearson 2023-01-19 123 xas_next(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 124 if (!__sg_page_iter_next(&sg_iter))
3222da9099ca42 Bob Pearson 2023-01-19 125 break;
3222da9099ca42 Bob Pearson 2023-01-19 126 }
3222da9099ca42 Bob Pearson 2023-01-19 127 xas_unlock(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 128 } while (xas_nomem(&xas, GFP_KERNEL));
3222da9099ca42 Bob Pearson 2023-01-19 129
3222da9099ca42 Bob Pearson 2023-01-19 @130 return xas_error(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 131 }
3222da9099ca42 Bob Pearson 2023-01-19 132
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Bob Pearson <rpearsonhpe@gmail.com>
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray
Date: Tue, 7 Feb 2023 11:03:07 +0300 [thread overview]
Message-ID: <202302071553.dxgzoPxM-lkp@intel.com> (raw)
Message-ID: <20230207080307.Ae1qpYDgwBS_VmtHrqf6VQFESileimb0RywPfSULYy8@z> (raw)
In-Reply-To: <20230119235936.19728-7-rpearsonhpe@gmail.com>
Hi Bob,
url: https://github.com/intel-lab-lkp/linux/commits/Bob-Pearson/RDMA-rxe-Cleanup-mr_check_range/20230120-080520
base: 1ec82317a1daac78c04b0c15af89018ccf9fa2b7
patch link: https://lore.kernel.org/r/20230119235936.19728-7-rpearsonhpe%40gmail.com
patch subject: [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray
config: s390-randconfig-m041-20230206 (https://download.01.org/0day-ci/archive/20230207/202302071553.dxgzoPxM-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
smatch warnings:
drivers/infiniband/sw/rxe/rxe_mr.c:130 rxe_mr_fill_pages_from_sgt() warn: inconsistent returns '&((&xas)->xa)->xa_lock'.
vim +130 drivers/infiniband/sw/rxe/rxe_mr.c
3222da9099ca42 Bob Pearson 2023-01-19 99 static int rxe_mr_fill_pages_from_sgt(struct rxe_mr *mr, struct sg_table *sgt)
3222da9099ca42 Bob Pearson 2023-01-19 100 {
3222da9099ca42 Bob Pearson 2023-01-19 101 XA_STATE(xas, &mr->page_list, 0);
3222da9099ca42 Bob Pearson 2023-01-19 102 struct sg_page_iter sg_iter;
3222da9099ca42 Bob Pearson 2023-01-19 103 struct page *page;
3222da9099ca42 Bob Pearson 2023-01-19 104 bool persistent = !!(mr->access & IB_ACCESS_FLUSH_PERSISTENT);
3222da9099ca42 Bob Pearson 2023-01-19 105
3222da9099ca42 Bob Pearson 2023-01-19 106 __sg_page_iter_start(&sg_iter, sgt->sgl, sgt->orig_nents, 0);
3222da9099ca42 Bob Pearson 2023-01-19 107 if (!__sg_page_iter_next(&sg_iter))
3222da9099ca42 Bob Pearson 2023-01-19 108 return 0;
3222da9099ca42 Bob Pearson 2023-01-19 109
3222da9099ca42 Bob Pearson 2023-01-19 110 do {
3222da9099ca42 Bob Pearson 2023-01-19 111 xas_lock(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 112 while (true) {
3222da9099ca42 Bob Pearson 2023-01-19 113 page = sg_page_iter_page(&sg_iter);
3222da9099ca42 Bob Pearson 2023-01-19 114
3222da9099ca42 Bob Pearson 2023-01-19 115 if (persistent && !is_pmem_page(page)) {
3222da9099ca42 Bob Pearson 2023-01-19 116 rxe_dbg_mr(mr, "Page can't be persistent\n");
3222da9099ca42 Bob Pearson 2023-01-19 117 return -EINVAL;
xas_unlock(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 118 }
3222da9099ca42 Bob Pearson 2023-01-19 119
3222da9099ca42 Bob Pearson 2023-01-19 120 xas_store(&xas, page);
3222da9099ca42 Bob Pearson 2023-01-19 121 if (xas_error(&xas))
3222da9099ca42 Bob Pearson 2023-01-19 122 break;
3222da9099ca42 Bob Pearson 2023-01-19 123 xas_next(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 124 if (!__sg_page_iter_next(&sg_iter))
3222da9099ca42 Bob Pearson 2023-01-19 125 break;
3222da9099ca42 Bob Pearson 2023-01-19 126 }
3222da9099ca42 Bob Pearson 2023-01-19 127 xas_unlock(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 128 } while (xas_nomem(&xas, GFP_KERNEL));
3222da9099ca42 Bob Pearson 2023-01-19 129
3222da9099ca42 Bob Pearson 2023-01-19 @130 return xas_error(&xas);
3222da9099ca42 Bob Pearson 2023-01-19 131 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next reply other threads:[~2023-02-07 7:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 7:53 kernel test robot [this message]
2023-02-07 8:03 ` [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 23:59 [PATCH for-next v7 0/6] RDMA/rxe: Replace mr page map with an xarray Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 1/6] RDMA/rxe: Cleanup mr_check_range Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 2/6] RDMA/rxe: Move rxe_map_mr_sg to rxe_mr.c Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 3/6] RDMA-rxe: Isolate mr code from atomic_reply() Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 4/6] RDMA-rxe: Isolate mr code from atomic_write_reply() Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 5/6] RDMA/rxe: Cleanup page variables in rxe_mr.c Bob Pearson
2023-01-19 23:59 ` [PATCH for-next v7 6/6] RDMA/rxe: Replace rxe_map and rxe_phys_buf by xarray Bob Pearson
2023-01-27 16:23 ` [PATCH for-next v7 0/6] RDMA/rxe: Replace mr page map with an xarray Jason Gunthorpe
2023-01-27 17:05 ` Bob Pearson
2023-01-27 19:26 ` Bob Pearson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302071553.dxgzoPxM-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.