All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Graeme Smecher <gsmecher@threespeedlogic.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2] package/python-orjson: disallow build when using musl.
Date: Tue, 7 Feb 2023 17:38:03 +0100	[thread overview]
Message-ID: <20230207163803.GI4124@scaer> (raw)
In-Reply-To: <20220519160214.214701-1-gsmecher@threespeedlogic.com>

Graeme, All,

On 2022-05-19 09:02 -0700, Graeme Smecher spake thusly:
> The python-orjson build bails as follows when using musl libc:
> 
> 	error: cannot produce cdylib for `orjson v3.6.7 (...)` as the
> 	target `i586-unknown-linux-musl` does not support these crate types

I could not reproduce such an error wit the following defconfig:

    BR2_TOOLCHAIN_BUILDROOT_MUSL=y
    BR2_TOOLCHAIN_BUILDROOT_CXX=y
    BR2_PER_PACKAGE_DIRECTORIES=y
    BR2_PACKAGE_PYTHON3=y
    BR2_PACKAGE_PYTHON_ORJSON=y

Since you submitted this patch, pythn-orjson was bumped multiple times,
and we've also bumped rust to 1.66.1, so maybe that was fixed now.

Could you have a further look into this, please?

Regards,
Yann E. MORIN.

> It's not machine-specific (it occurs on i586, s389x, and arm platforms),
> and is tied to what appears to be relatively arcane details for
> rust/musl:
> 
> 	https://github.com/rust-lang/rust/issues/59302
> 
> At some point, it will be possible to remove this restriction - but not
> yet.
> 
> Signed-off-by: Graeme Smecher <gsmecher@threespeedlogic.com>
> ---
>  package/python-orjson/Config.in | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/package/python-orjson/Config.in b/package/python-orjson/Config.in
> index 420e023b0a..b2ad9062cc 100644
> --- a/package/python-orjson/Config.in
> +++ b/package/python-orjson/Config.in
> @@ -1,6 +1,8 @@
>  config BR2_PACKAGE_PYTHON_ORJSON
>  	bool "python-orjson"
>  	depends on BR2_PACKAGE_HOST_RUSTC_TARGET_ARCH_SUPPORTS
> +	# doesn't build with musl until rust's cdylib targets work with it
> +	depends on !BR2_TOOLCHAIN_USES_MUSL
>  	select BR2_PACKAGE_PYTHON_CFFI # runtime
>  	help
>  	  orjson is a fast, correct JSON library for Python. It
> @@ -10,3 +12,6 @@ config BR2_PACKAGE_PYTHON_ORJSON
>  	  instances natively.
>  
>  	  https://github.com/ijl/orjson
> +
> +comment "python-orjson requires rust cdylib support, which musl doesn't have yet"
> +	depends on BR2_TOOLCHAIN_USES_MUSL
> -- 
> 2.35.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-07 16:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-09 19:06 [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 Graeme Smecher
2022-05-09 19:06 ` [Buildroot] [PATCH 2/2] package/python-orjson: disallow build when using musl Graeme Smecher
2022-05-19 16:02   ` [Buildroot] [PATCH v2] " Graeme Smecher
2023-02-07 16:38     ` Yann E. MORIN [this message]
2023-02-07 17:14       ` Graeme Smecher
2023-02-07 17:29         ` Yann E. MORIN
2023-02-07 17:56           ` Graeme Smecher
2022-05-09 22:14 ` [Buildroot] [PATCH 1/2] package/python-orjson: bump version to 3.6.8 James Hilliard
2022-07-24  7:40 ` Thomas Petazzoni via buildroot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230207163803.GI4124@scaer \
    --to=yann.morin.1998@free.fr \
    --cc=buildroot@buildroot.org \
    --cc=gsmecher@threespeedlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.