From: Rob Herring <robh@kernel.org>
To: Danny Kaehn <kaehndan@gmail.com>
Cc: krzysztof.kozlowski+dt@linaro.org, jikos@kernel.org,
benjamin.tissoires@redhat.com, devicetree@vger.kernel.org,
linux-input@vger.kernel.org, ethan.twardy@plexus.com
Subject: Re: [PATCH v4 1/4] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge
Date: Tue, 7 Feb 2023 12:50:07 -0600 [thread overview]
Message-ID: <20230207185007.GA3962587-robh@kernel.org> (raw)
In-Reply-To: <20230206135016.6737-2-kaehndan@gmail.com>
On Mon, Feb 06, 2023 at 07:50:13AM -0600, Danny Kaehn wrote:
> This is a USB HID device which includes an I2C controller and 8 GPIO pins.
>
> The binding allows describing the chip's gpio and i2c controller in DT
> using the subnodes named "gpio" and "i2c", respectively. This is
> intended to be used in configurations where the CP2112 is permanently
> connected in hardware.
My comments on v3 still apply. Please slow down your pace of sending new
versions so folks have change to review.
Rob
next prev parent reply other threads:[~2023-02-07 18:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 13:50 [PATCH v4 0/4] DeviceTree Support for USB-HID Devices and CP2112 Danny Kaehn
2023-02-06 13:50 ` [PATCH v4 1/4] dt-bindings: i2c: Add CP2112 HID USB to SMBus Bridge Danny Kaehn
2023-02-06 16:17 ` Krzysztof Kozlowski
2023-02-07 18:50 ` Rob Herring [this message]
2023-02-08 13:16 ` Daniel Kaehn
2023-02-06 13:50 ` [PATCH v4 2/4] HID: usbhid: Share USB device devicetree node with child HID device Danny Kaehn
2023-02-06 23:14 ` Dmitry Torokhov
2023-02-06 13:50 ` [PATCH v4 3/4] HID: cp2112: Fix driver not registering GPIO IRQ chip as threaded Danny Kaehn
2023-02-06 23:15 ` Dmitry Torokhov
2023-02-07 12:34 ` Daniel Kaehn
2023-02-10 0:32 ` Dmitry Torokhov
2023-02-06 13:50 ` [PATCH v4 4/4] HID: cp2112: Devicetree Support Danny Kaehn
2023-02-06 23:18 ` Dmitry Torokhov
2023-02-07 10:15 ` Andy Shevchenko
2023-02-07 12:28 ` Daniel Kaehn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207185007.GA3962587-robh@kernel.org \
--to=robh@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=ethan.twardy@plexus.com \
--cc=jikos@kernel.org \
--cc=kaehndan@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.