From: Jakub Kicinski <kuba@kernel.org>
To: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, jmaloy@redhat.com, ying.xue@windriver.com,
viro@zeniv.linux.org.uk,
syzbot+d43608d061e8847ec9f3@syzkaller.appspotmail.com
Subject: Re: [PATCH net 1/1] tipc: fix kernel warning when sending SYN message
Date: Tue, 7 Feb 2023 21:34:33 -0800 [thread overview]
Message-ID: <20230207213433.6d679340@kernel.org> (raw)
In-Reply-To: <20230207012046.8683-1-tung.q.nguyen@dektech.com.au>
On Tue, 7 Feb 2023 01:20:46 +0000 Tung Nguyen wrote:
> When sending a SYN message, this kernel stack trace is observed:
>
> ...
> [ 13.396352] RIP: 0010:_copy_from_iter+0xb4/0x550
> ...
> [ 13.398494] Call Trace:
> [ 13.398630] <TASK>
> [ 13.398630] ? __alloc_skb+0xed/0x1a0
> [ 13.398630] tipc_msg_build+0x12c/0x670 [tipc]
> [ 13.398630] ? shmem_add_to_page_cache.isra.71+0x151/0x290
> [ 13.398630] __tipc_sendmsg+0x2d1/0x710 [tipc]
> [ 13.398630] ? tipc_connect+0x1d9/0x230 [tipc]
> [ 13.398630] ? __local_bh_enable_ip+0x37/0x80
> [ 13.398630] tipc_connect+0x1d9/0x230 [tipc]
> [ 13.398630] ? __sys_connect+0x9f/0xd0
> [ 13.398630] __sys_connect+0x9f/0xd0
> [ 13.398630] ? preempt_count_add+0x4d/0xa0
> [ 13.398630] ? fpregs_assert_state_consistent+0x22/0x50
> [ 13.398630] __x64_sys_connect+0x16/0x20
> [ 13.398630] do_syscall_64+0x42/0x90
> [ 13.398630] entry_SYSCALL_64_after_hwframe+0x63/0xcd
>
> It is because commit a41dad905e5a ("iov_iter: saner checks for attempt
> to copy to/from iterator") has introduced sanity check for copying
> from/to iov iterator. Lacking of copy direction from the iterator
> viewpoint would lead to kernel stack trace like above.
How far does the bug itself date, tho?
Can we get a Fixes tag?
> This commit fixes this issue by initializing the iov iterator with
> the correct copy direction.
next prev parent reply other threads:[~2023-02-08 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 1:20 [PATCH net 1/1] tipc: fix kernel warning when sending SYN message Tung Nguyen
2023-02-08 5:34 ` Jakub Kicinski [this message]
2023-02-08 6:56 ` Tung Quang Nguyen
[not found] ` <20230207233033.6b5f4882@kernel.org>
2023-02-08 7:48 ` Tung Quang Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207213433.6d679340@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jmaloy@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+d43608d061e8847ec9f3@syzkaller.appspotmail.com \
--cc=tung.q.nguyen@dektech.com.au \
--cc=viro@zeniv.linux.org.uk \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.