From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Wed, 8 Feb 2023 05:10:02 -0500 From: "Michael S. Tsirkin" Message-ID: <20230208050822-mutt-send-email-mst@kernel.org> References: <20230207111634.75542-1-hengqi@linux.alibaba.com> <20230207090019-mutt-send-email-mst@kernel.org> <98c2cd3f-2f59-74e1-0b37-cbf2a9180bd4@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <98c2cd3f-2f59-74e1-0b37-cbf2a9180bd4@linux.alibaba.com> Subject: Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Heng Qi Cc: "virtio-comment @ lists . oasis-open . org" , "virtio-dev @ lists . oasis-open . org" , Jason Wang , Parav Pandit , Alvaro Karsz , Xuan Zhuo List-ID: On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote: > > I think it's a good idea to do this on top of Alvaro's patch > > unifying these two structures. > > I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good > way for me to > unify the two structures, since a patch should only do one thing. Problem is you were trying to change these existing structures too so the patches conflicted. However I think at this point we are in agreement on a new command with a new structure. In this case there won't be a conflict as you are not touching existing commands so no need for you to depend on Alvaro's patch. -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org