From: Mauro Carvalho Chehab <mchehab@kernel.org>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org, Moudy Ho <moudy.ho@mediatek.com>
Subject: Re: [PATCH 10/17] media: mediatek: mdp3: replace return by goto for proper unwind
Date: Wed, 8 Feb 2023 08:38:19 +0100 [thread overview]
Message-ID: <20230208083819.4365b97d@coco.lan> (raw)
In-Reply-To: <20230126150657.367921-11-hverkuil-cisco@xs4all.nl>
Em Thu, 26 Jan 2023 16:06:50 +0100
Hans Verkuil <hverkuil-cisco@xs4all.nl> escreveu:
> An error was returned at one point without going through the
> goto label for proper unwinding.
>
> This fixes a smatch warning:
>
> mtk-mdp3-comp.c:1005 mdp_comp_config() warn: missing unwind goto?
This patch doesn't apply, as the logic it is meant to touch
changed a lot. I'm simply discarding it from your PR.
Please work on a new version if still needed.
Regards,
Mauro
Thanks,
Mauro
next prev parent reply other threads:[~2023-02-08 7:39 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 15:06 [PATCH 00/17] media: sparse/smatch fixes Hans Verkuil
2023-01-26 15:06 ` [PATCH 01/17] media: visl: make visl_qops static Hans Verkuil
2023-01-26 15:06 ` [PATCH 02/17] media: davinci/vpif.c: drop unnecessary cast Hans Verkuil
2023-01-30 23:33 ` Lad, Prabhakar
2023-01-26 15:06 ` [PATCH 03/17] media: i2c: s5c73m3: return 0 instead of 'ret' Hans Verkuil
2023-01-26 15:06 ` [PATCH 04/17] media: dvb-frontends: cxd2880: " Hans Verkuil
2023-01-26 15:06 ` [PATCH 05/17] media: usb: dvb-usb-v2: af9015.c: " Hans Verkuil
2023-01-26 15:06 ` [PATCH 06/17] media: dvb-frontends: cxd2880: " Hans Verkuil
2023-01-26 15:06 ` [PATCH 07/17] media: marvell: change return to goto for proper unwind Hans Verkuil
2023-01-26 15:06 ` [PATCH 08/17] media: dvb-frontends: drx39xyj: replace return with " Hans Verkuil
2023-01-26 15:06 ` [PATCH 09/17] media: nxp: imx-jpeg: replace dummy gotos by returns Hans Verkuil
2023-01-27 20:38 ` [EXT] " Mirela Rabulea
2023-01-26 15:06 ` [PATCH 10/17] media: mediatek: mdp3: replace return by goto for proper unwind Hans Verkuil
2023-02-08 7:38 ` Mauro Carvalho Chehab [this message]
2023-01-26 15:06 ` [PATCH 11/17] media: mediatek: vcodec/venc: return 0 instead of 'ret' Hans Verkuil
2023-01-26 15:06 ` [PATCH 12/17] media: ti: davinci: vpbe_display.c: " Hans Verkuil
2023-01-30 23:35 ` Lad, Prabhakar
2023-01-26 15:06 ` [PATCH 13/17] media: i2c: ov7670: 0 instead of -EINVAL was returned Hans Verkuil
2023-01-26 21:44 ` Sakari Ailus
2023-01-26 15:06 ` [PATCH 14/17] media: usb: go7007: add second unwind label Hans Verkuil
2023-01-26 15:06 ` [PATCH 15/17] media: i2c: adp1653: introduce 'no_child' label Hans Verkuil
2023-01-26 15:19 ` Sakari Ailus
2023-01-27 7:43 ` Can smatch handle this better? (was: [PATCH 15/17] media: i2c: adp1653: introduce 'no_child' label) Hans Verkuil
2023-01-27 12:41 ` Dan Carpenter
2023-01-27 13:00 ` Hans Verkuil
2023-01-27 14:51 ` Dan Carpenter
2023-01-26 15:06 ` [PATCH 16/17] media: st: delta: introduce 'err_too_many_comps' label Hans Verkuil
2023-01-26 15:06 ` [PATCH 17/17] media: dvb-frontends: mb86a16.c: always use the same error path Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208083819.4365b97d@coco.lan \
--to=mchehab@kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=moudy.ho@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.