From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Date: Wed, 8 Feb 2023 09:17:34 -0500 From: "Michael S. Tsirkin" Message-ID: <20230208091334-mutt-send-email-mst@kernel.org> References: <20230207111634.75542-1-hengqi@linux.alibaba.com> <20230207090019-mutt-send-email-mst@kernel.org> <1675820731.3018508-1-xuanzhuo@linux.alibaba.com> <1675823090.089496-2-xuanzhuo@linux.alibaba.com> <3a1dbf6f-48ab-1eba-7f31-27e782a7ff12@linux.alibaba.com> MIME-Version: 1.0 In-Reply-To: <3a1dbf6f-48ab-1eba-7f31-27e782a7ff12@linux.alibaba.com> Subject: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Heng Qi Cc: Parav Pandit , Xuan Zhuo , "virtio-comment @ lists . oasis-open . org" , "virtio-dev @ lists . oasis-open . org" , Jason Wang , Alvaro Karsz List-ID: On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > I see two options. > > 1. Just have per VQ params. Software has the full knowledge of in which it is operating, and state remains at software level. > > This effectively achieves both the mode. > > > > 2. Have a mode cmd, > > Mode = (a) per device or (b) per VQ (c) disable > > After the mode is set, driver can set per device or per VQ. > > I find this more clear. > > Thanks. > Rereading this I think I misunderstood the proposal. Now we are burning memory on maintaining mode, and this information is duplicated. I'd say let's just add a new command COAL_QUEUE_SET with vqn as parameter. Existing commands are simply defined as a shortcut to running COAL_QUEUE_SET on all tx/rx queues respectively. Latest command dictates the parameters. To disable just set everything to 0 (btw we should make this explicit in the spec, but it can be guessed from: Upon reset, a device MUST initialize all coalescing parameters to 0. ) -- MST --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org