From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 150749860CC for ; Wed, 8 Feb 2023 14:44:20 +0000 (UTC) Date: Wed, 8 Feb 2023 09:44:12 -0500 From: "Michael S. Tsirkin" Message-ID: <20230208094330-mutt-send-email-mst@kernel.org> References: <20230207111634.75542-1-hengqi@linux.alibaba.com> <20230207090019-mutt-send-email-mst@kernel.org> <1675820731.3018508-1-xuanzhuo@linux.alibaba.com> <1675823090.089496-2-xuanzhuo@linux.alibaba.com> <3a1dbf6f-48ab-1eba-7f31-27e782a7ff12@linux.alibaba.com> <20230208091334-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Parav Pandit Cc: Heng Qi , Xuan Zhuo , "virtio-comment @ lists . oasis-open . org" , "virtio-dev @ lists . oasis-open . org" , Jason Wang , Alvaro Karsz List-ID: On Wed, Feb 08, 2023 at 02:37:55PM +0000, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:18 AM > > > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > > > I see two options. > > > > 1. Just have per VQ params. Software has the full knowledge of in which it is > > operating, and state remains at software level. > > > > This effectively achieves both the mode. > > > > > > > > 2. Have a mode cmd, > > > > Mode = (a) per device or (b) per VQ (c) disable After the mode is > > > > set, driver can set per device or per VQ. > > > > > > I find this more clear. > > > > > > Thanks. > > > > > > > Rereading this I think I misunderstood the proposal. > > Now we are burning memory on maintaining mode, and this information is > > duplicated. > > > It is not maintained in the pci resident memory, so it doesn't hurt. It can't reasonably be read from RAM at each packet, you need to cache it in memory. This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/