From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: "George Kelly" <george.kelly1097@gmail.com>
Cc: bitbake-devel@lists.openembedded.org
Subject: Re: [bitbake-devel] [bitbake][PATCHv2] Add NODE_EXTRA_CA_CERTS to export list
Date: Wed, 8 Feb 2023 11:14:56 +0100 [thread overview]
Message-ID: <20230208111456.08b95a45@booty> (raw)
In-Reply-To: <20230207221022.4346-1-george.kelly1097@gmail.com>
Hello George,
On Tue, 7 Feb 2023 17:10:22 -0500
"George Kelly" <george.kelly1097@gmail.com> wrote:
> If you are behind a corporate proxy, the npm fetcher uses
> the proxy IP address already passed in the list of exports.
> However, it will error if the proxy injects its own root
> CA certificate. Thus, the NODE_EXTRA_CA_CERTS environment
> variable must be passed so the user can include their
> company's root CA as a trusted CA inside node's
> certificate store.
>
> Signed-off-by: George Kelly <george.kelly1097@gmail.com>
Your subject and commit message looks definitely good now, thanks! I
added your patch to my testing branch.
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2023-02-08 10:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 22:10 [bitbake][PATCHv2] Add NODE_EXTRA_CA_CERTS to export list George Kelly
2023-02-08 10:14 ` Luca Ceresoli [this message]
2023-02-08 10:55 ` [bitbake-devel] " Peter Kjellerstedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208111456.08b95a45@booty \
--to=luca.ceresoli@bootlin.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=george.kelly1097@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.