From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id 26C5D9864E7 for ; Wed, 8 Feb 2023 17:38:49 +0000 (UTC) Date: Wed, 8 Feb 2023 12:38:41 -0500 From: "Michael S. Tsirkin" Message-ID: <20230208123630-mutt-send-email-mst@kernel.org> References: <20230206084746.40536-1-alvaro.karsz@solid-run.com> <20230206160206-mutt-send-email-mst@kernel.org> <20230206171410-mutt-send-email-mst@kernel.org> <20230207091242-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio-comment] RE: [virtio-dev] [PATCH] virtio-net: Fix and update VIRTIO_NET_F_NOTF_COAL feature Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Parav Pandit Cc: Alvaro Karsz , "virtio-comment@lists.oasis-open.org" , "virtio-dev@lists.oasis-open.org" , "jasowang@redhat.com" List-ID: On Wed, Feb 08, 2023 at 05:30:28PM +0000, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Tuesday, February 7, 2023 9:18 AM > > > > Why migration generate too many spurious interrupts? > > > > Because, you might want to migrate from hardware with to hardware without > > coalescing features. So you just tell guest "sure I will coalesce" but in fact send > > interrupts normally. > > For the hardware that has fake coalescing, HV wouldn't know it anyway without doing pre verification. > And HV may not migrate in such case for best experience. > HV may choose to migrate with low accuracy as you say, which is fine. > > But the spec guidance for the device implementations is to promote some reasonable level of accuracy. > Hard to define in words here. > Best effort is wide spectrum of range. :) > > Typically, we say in the spec as SHOULD. > So, lets skip the best-effort wording and stick to SHOULD part like rest of the spec. I think the point of best-effort is that driver must handle interrupts that arrive earlier. This is how we used it elsewhere. What else does it include in your opinion that we absolutely must exclude? I feel it's a good fit for a non-conformance section which is by nature a bit informal. For a conformance section SHOULD is indeed a good fit. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/