From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] package/dmalloc: disable stack-protector
Date: Wed, 8 Feb 2023 17:28:19 +0100 [thread overview]
Message-ID: <20230208162819.GA3386@scaer> (raw)
In-Reply-To: <20220612203729.GM427639@scaer>
Fabrice, All,
On 2022-06-12 22:37 +0200, Yann E. MORIN spake thusly:
> On 2022-06-10 23:05 +0200, Fabrice Fontaine spake thusly:
> > Fix the following build failure with stack-protector:
> > /home/autobuild/autobuild/instance-1/output-1/per-package/dmalloc/host/bin/i686-buildroot-linux-gnu-ld -shared --whole-archive -soname libdmallocth.so -o libdmallocth.so.t libdmallocth.a
> > /home/autobuild/autobuild/instance-1/output-1/per-package/dmalloc/host/bin/i686-buildroot-linux-gnu-ld: libdmallocth.a(append.o): in function `append_long':
> > append.c:(.text+0x115): undefined reference to `__stack_chk_fail_local'
[--SNIP--]
> > +DMALLOC_CFLAGS = $(TARGET_CFLAGS) -fno-stack-protector
>
> At the risk of more goofiness, but the reference build issue had me
> notice that dmalloc uses ld to do the link phase, while it should really
> call gcc.
[--SNIP--]
> So, thisis a bit of a bigger change, but I otherwise fdo not think that
> disabling SSP is a good idea, especially for a library that deals with
> allocating memory...
So, I eventually took the day to look at this during the dev-days.
I've sent an updated series now:
https://patchwork.ozlabs.org/project/buildroot/list/?series=340858
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2023-02-08 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 21:05 [Buildroot] [PATCH 1/2] package/dmalloc: fix strndup detection Fabrice Fontaine
2022-06-10 21:05 ` [Buildroot] [PATCH 2/2] package/dmalloc: disable stack-protector Fabrice Fontaine
2022-06-12 20:37 ` Yann E. MORIN
2023-02-08 16:28 ` Yann E. MORIN [this message]
2022-06-12 20:23 ` [Buildroot] [PATCH 1/2] package/dmalloc: fix strndup detection Yann E. MORIN
2022-06-19 13:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208162819.GA3386@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.