From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Sender: List-Post: List-Help: List-Unsubscribe: List-Subscribe: Received: from lists.oasis-open.org (oasis-open.org [10.110.1.242]) by lists.oasis-open.org (Postfix) with ESMTP id EC3AE986529 for ; Wed, 8 Feb 2023 22:53:27 +0000 (UTC) Date: Wed, 8 Feb 2023 17:53:19 -0500 From: "Michael S. Tsirkin" Message-ID: <20230208175158-mutt-send-email-mst@kernel.org> References: <20230208154819-mutt-send-email-mst@kernel.org> <20230208171348-mutt-send-email-mst@kernel.org> <20230208172646-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Subject: Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation Content-Type: text/plain; charset=us-ascii Content-Disposition: inline To: Alvaro Karsz Cc: Parav Pandit , Heng Qi , Xuan Zhuo , "virtio-comment @ lists . oasis-open . org" , "virtio-dev @ lists . oasis-open . org" , Jason Wang List-ID: On Thu, Feb 09, 2023 at 12:45:42AM +0200, Alvaro Karsz wrote: > Maybe we should do something more future friendly. > We may want to add more coalescing related features in the future. > * Maybe max/min sets? > * Maybe to offload the adaptive algo to the DPU? > > It will require more feature bits.. > > We could rename this new feature from VIRTIO_NET_F_PERQUEUE_NOTF_COAL > to something like VIRTIO_NET_F_ADVANCED_NOTF_COAL, and introduce a new > bitmask in the virto_net_config. > > We can implement just one bit at first. > BIT 0 - device supports per queue coalescing sets > > Then, we could add more features in the future without having to use > more feature bits. > > Every device that offers VIRTIO_NET_F_ADVANCED_NOTF_COAL should > maintain a valid bitmask. Without at least two bits there it sounds like over-engineering to me: we won't really know whether the fancy infrastructure is good for any extensions. -- MST This publicly archived list offers a means to provide input to the OASIS Virtual I/O Device (VIRTIO) TC. In order to verify user consent to the Feedback License terms and to minimize spam in the list archive, subscription is required before posting. Subscribe: virtio-comment-subscribe@lists.oasis-open.org Unsubscribe: virtio-comment-unsubscribe@lists.oasis-open.org List help: virtio-comment-help@lists.oasis-open.org List archive: https://lists.oasis-open.org/archives/virtio-comment/ Feedback License: https://www.oasis-open.org/who/ipr/feedback_license.pdf List Guidelines: https://www.oasis-open.org/policies-guidelines/mailing-lists Committee: https://www.oasis-open.org/committees/virtio/ Join OASIS: https://www.oasis-open.org/join/