All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Yann E . MORIN" <yann.morin.1998@free.fr>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/1] package/weston: bump to version 11.0.1
Date: Wed, 8 Feb 2023 20:33:24 +0100	[thread overview]
Message-ID: <20230208203324.4ccd9dba@windsurf> (raw)
In-Reply-To: <20221214151958.3419333-1-james.hilliard1@gmail.com>

Hello,

Thanks for the patch. It overall looks good, but I have one
question/comment.

On Wed, 14 Dec 2022 08:19:58 -0700
James Hilliard <james.hilliard1@gmail.com> wrote:

> @@ -73,7 +84,9 @@ config BR2_PACKAGE_WESTON_RDP
>  	depends on BR2_TOOLCHAIN_HAS_SYNC_4
>  	depends on BR2_USE_WCHAR # freerdp
>  	depends on BR2_INSTALL_LIBSTDCPP # freerdp
> +	depends on BR2_PACKAGE_XORG7 # freerdp-server

It feels really odd that we need to build half of the X.org planet to
have RDP support in Weston. Is this dependency really needed? Isn't
that something "wrong" in the freerdp package that should be fixed?

Best regards,

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2023-02-08 19:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-14 15:19 [Buildroot] [PATCH v2 1/1] package/weston: bump to version 11.0.1 James Hilliard
2023-02-08 19:33 ` Thomas Petazzoni via buildroot [this message]
2023-02-08 20:05   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230208203324.4ccd9dba@windsurf \
    --to=buildroot@buildroot.org \
    --cc=james.hilliard1@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.