From: Andrew Davis <afd@ti.com>
To: Denys Dmytriyenko <denys@konsulko.com>,
Ryan Eatmon <reatmon@ti.com>, <meta-ti@lists.yoctoproject.org>
Cc: Andrew Davis <afd@ti.com>
Subject: [meta-ti][master/kirkstone][PATCH 1/4] trusted-firmware-a: Use ti-k3-secdev if TI_SECURE_DEV_PKG_K3 is not defined
Date: Wed, 8 Feb 2023 17:10:28 -0600 [thread overview]
Message-ID: <20230208231031.16363-1-afd@ti.com> (raw)
Use the new ti-k3-secdev package to pull in the signing tools if they are
not provided by the environment. This allows us to use these tools
unconditionally. Remove the checks for the script and do the signing
for all K3 machines. The signature is automatically stripped from
the binaries on non-HS devices at boot time as needed so this change
is harmless for GP devices.
Signed-off-by: Andrew Davis <afd@ti.com>
---
.../trusted-firmware-a_%.bbappend | 43 ++++++-------------
1 file changed, 12 insertions(+), 31 deletions(-)
diff --git a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
index 5acc5c2e..95f1d2d9 100644
--- a/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
+++ b/meta-ti-bsp/recipes-bsp/trusted-firmware-a/trusted-firmware-a_%.bbappend
@@ -6,39 +6,20 @@ TFA_BUILD_TARGET:k3 = "all"
TFA_INSTALL_TARGET:k3 = "bl31"
TFA_SPD:k3 = "opteed"
+# Use default package TI SECDEV is one is not provided
+DEPENDS:append:k3 = "${@ '' if d.getVar('TI_SECURE_DEV_PKG_K3') else ' ti-k3-secdev-native' }"
+
+# Set a default value for TI_K3_SECDEV_INSTALL_DIR
+export TI_K3_SECDEV_INSTALL_DIR = "${STAGING_DIR_NATIVE}${datadir}/ti/ti-k3-secdev"
+include recipes-ti/includes/ti-paths.inc
+TI_SECURE_DEV_PKG:k3 = "${@ d.getVar('TI_SECURE_DEV_PKG_K3') or d.getVar('TI_K3_SECDEV_INSTALL_DIR') }"
+
EXTRA_OEMAKE:append:k3 = "${@ ' K3_USART=' + d.getVar('TFA_K3_USART') if d.getVar('TFA_K3_USART') else ''}"
EXTRA_OEMAKE:append:k3 = "${@ ' K3_PM_SYSTEM_SUSPEND=' + d.getVar('TFA_K3_SYSTEM_SUSPEND') if d.getVar('TFA_K3_SYSTEM_SUSPEND') else ''}"
-# Signing procedure for K3 HS devices
-tfa_sign_k3hs() {
+# Signing procedure for K3 devices
+do_compile:append:k3() {
export TI_SECURE_DEV_PKG=${TI_SECURE_DEV_PKG}
- ( cd ${BUILD_DIR}; \
- mv bl31.bin bl31.bin.unsigned; \
- if [ -f ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh ]; then \
- ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh bl31.bin.unsigned bl31.bin; \
- else \
- echo "Warning: TI_SECURE_DEV_PKG not set, TF-A not signed."; \
- cp bl31.bin.unsigned bl31.bin; \
- fi; \
- )
-}
-
-do_compile:append:am65xx-hs-evm() {
- tfa_sign_k3hs
-}
-
-do_compile:append:am64xx-evm() {
- tfa_sign_k3hs
-}
-
-do_compile:append:j721e-hs-evm() {
- tfa_sign_k3hs
-}
-
-do_compile:append:j7200-hs-evm() {
- tfa_sign_k3hs
-}
-
-do_compile:append:j721s2-hs-evm() {
- tfa_sign_k3hs
+ mv ${BUILD_DIR}/bl31.bin ${BUILD_DIR}/bl31.bin.unsigned
+ ${TI_SECURE_DEV_PKG}/scripts/secure-binary-image.sh ${BUILD_DIR}/bl31.bin.unsigned ${BUILD_DIR}/bl31.bin
}
--
2.39.1
next reply other threads:[~2023-02-08 23:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-08 23:10 Andrew Davis [this message]
2023-02-08 23:10 ` [meta-ti][master/kirkstone][PATCH 2/4] optee-os: Use ti-k3-secdev if TI_SECURE_DEV_PKG_K3 is not defined Andrew Davis
2023-02-09 0:29 ` Ryan Eatmon
2023-02-10 18:53 ` Denys Dmytriyenko
2023-02-08 23:10 ` [meta-ti][master/kirkstone][PATCH 3/4] u-boot-ti: " Andrew Davis
2023-02-10 18:55 ` Denys Dmytriyenko
2023-02-08 23:10 ` [meta-ti][master/kirkstone][PATCH 4/4] conf: machine: k3: Remove unneeded TI_SECURE_DEV_PKG_K3 assignments Andrew Davis
2023-02-10 18:51 ` [meta-ti][master/kirkstone][PATCH 1/4] trusted-firmware-a: Use ti-k3-secdev if TI_SECURE_DEV_PKG_K3 is not defined Denys Dmytriyenko
2023-02-10 18:56 ` Andrew Davis
2023-02-10 19:05 ` Denys Dmytriyenko
2023-02-10 19:55 ` Andrew Davis
2023-02-10 21:58 ` Denys Dmytriyenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230208231031.16363-1-afd@ti.com \
--to=afd@ti.com \
--cc=denys@konsulko.com \
--cc=meta-ti@lists.yoctoproject.org \
--cc=reatmon@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.