All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: "Tian, Kevin" <kevin.tian@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
	Lu Baolu <baolu.lu@linux.intel.com>,
	Joerg Roedel <joro@8bytes.org>,
	David Woodhouse <dwmw2@infradead.org>,
	"Raj, Ashok" <ashok.raj@intel.com>,
	"Liu, Yi L" <yi.l.liu@intel.com>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Ghorai, Sukumar" <sukumar.ghorai@intel.com>,
	jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3] iommu/vt-d: Fix PASID directory pointer coherency
Date: Thu, 9 Feb 2023 09:06:03 -0800	[thread overview]
Message-ID: <20230209090603.37854cb9@jacob-builder> (raw)
In-Reply-To: <BN9PR11MB52760B2BBE25C23EE445B2C58CD99@BN9PR11MB5276.namprd11.prod.outlook.com>

Hi Kevin,

On Thu, 9 Feb 2023 02:08:23 +0000, "Tian, Kevin" <kevin.tian@intel.com>
wrote:

> > @@ -1976,6 +1976,8 @@ static int domain_context_mapping_one(struct
> > dmar_domain *domain,
> >  		pds = context_get_sm_pds(table);
> >  		context->lo = (u64)virt_to_phys(table->table) |
> >  				context_pdts(pds);
> > +		if (!ecap_coherent(iommu->ecap))
> > +			clflush_cache_range(table->table,
> > sizeof(u64));  
> 
> this is not required if cache is already flushed when the table is
> allocated.
yes you're right.

Thanks,

Jacob

  reply	other threads:[~2023-02-09 17:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08 17:19 [PATCH v3] iommu/vt-d: Fix PASID directory pointer coherency Jacob Pan
2023-02-09  2:08 ` Tian, Kevin
2023-02-09 17:06   ` Jacob Pan [this message]
  -- strict thread matches above, loose matches on Subject: below --
2023-04-05 15:44 Jacob Pan
2023-04-20  8:16 ` Tian, Kevin
2023-04-21  2:34   ` Baolu Lu
2023-04-21  2:39     ` Tian, Kevin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230209090603.37854cb9@jacob-builder \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=sukumar.ghorai@intel.com \
    --cc=yi.l.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.