From: Jakub Kicinski <kuba@kernel.org>
To: Shannon Nelson <shannon.nelson@amd.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, drivers@pensando.io
Subject: Re: [PATCH v3 net-next 3/3] ionic: add support for device Component Memory Buffers
Date: Thu, 9 Feb 2023 09:06:30 -0800 [thread overview]
Message-ID: <20230209090630.1d68d7f8@kernel.org> (raw)
In-Reply-To: <c2cde083-3d7a-5fda-5970-ebfc6413f43d@amd.com>
On Wed, 8 Feb 2023 22:52:59 -0800 Shannon Nelson wrote:
> > Oh, completely missed this when looking at previous version.
> > This is ETHTOOL_A_RINGS_TX_PUSH right?
> >
> > Could you take a look at what hns3 does to confirm?
>
> Hmmm... I hadn't seen that feature creep in. I guess I'll have to hunt
> down an up-to-date ethtool and experiment a bit.
Or use the yaml thing :)
https://www.kernel.org/doc/html/next/userspace-api/netlink/intro-specs.html
> Yes, on first glance this looks similar, except we do both TX and RX
> descriptors when CMB is enabled.
If Tx looks right we can add the same knob for Rx, FWIW.
prev parent reply other threads:[~2023-02-09 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-07 23:40 [PATCH v3 net-next 0/3] ionic: on-chip descriptors Shannon Nelson
2023-02-07 23:40 ` [PATCH v3 net-next 1/3] ionic: remove unnecessary indirection Shannon Nelson
2023-02-07 23:40 ` [PATCH v3 net-next 2/3] ionic: remove unnecessary void casts Shannon Nelson
2023-02-07 23:40 ` [PATCH v3 net-next 3/3] ionic: add support for device Component Memory Buffers Shannon Nelson
2023-02-09 5:50 ` Jakub Kicinski
2023-02-09 6:52 ` Shannon Nelson
2023-02-09 17:06 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230209090630.1d68d7f8@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=drivers@pensando.io \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.