diff for duplicates of <202302101023.ctlih5q0-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index eeb444e..67e8779 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,15 +1,6 @@ -BCC: lkp@intel.com -CC: oe-kbuild-all@lists.linux.dev -CC: linux-kernel@vger.kernel.org -TO: "Ping-Ke Shih" <pkshih@realtek.com> -CC: Kalle Valo <kvalo@kernel.org> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e544a07438522ab3688416e6e2e34bf0ee6d8755 commit: 7ba49f4c6896d83b3841c0b046a0a7b1e97cc0dd rtw89: 8852c: add 8852ce to Makefile and Kconfig -date: 9 months ago -:::::: branch date: 7 hours ago -:::::: commit date: 9 months ago config: parisc-randconfig-m031-20230209 (https://download.01.org/0day-ci/archive/20230210/202302101023.ctlih5q0-lkp@intel.com/config) compiler: hppa-linux-gcc (GCC) 12.1.0 @@ -23,7 +14,6 @@ drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu_status() warn: vim +/ret +3829 drivers/net/wireless/realtek/rtw89/mac.c -e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3817 e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3818 int rtw89_mac_cfg_ppdu_status(struct rtw89_dev *rtwdev, u8 mac_idx, bool enable) e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3819 { e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3820 u32 reg = rtw89_mac_reg_by_idx(R_AX_PPDU_STAT, mac_idx); @@ -36,6 +26,9 @@ e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3826 e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3827 if (!enable) { e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3828 rtw89_write32_clr(rtwdev, reg, B_AX_PPDU_STAT_RPT_EN); e3ec7017f6a20d Ping-Ke Shih 2021-10-11 @3829 return ret; + +The code is correct, but it would be more readable to return 0; + e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3830 } e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3831 e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3832 rtw89_write32(rtwdev, reg, B_AX_PPDU_STAT_RPT_EN | @@ -46,15 +39,10 @@ e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3836 rtw89_write32_mask(rtwdev, R_AX_ e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3837 RTW89_PRPT_DEST_HOST); e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3838 e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3839 return ret; -e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3840 } -861e58c8fc6be0 Zong-Zhe Yang 2021-12-21 3841 EXPORT_SYMBOL(rtw89_mac_cfg_ppdu_status); -e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3842 -:::::: The code at line 3829 was first introduced by commit -:::::: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver +Same here. -:::::: TO: Ping-Ke Shih <pkshih@realtek.com> -:::::: CC: Kalle Valo <kvalo@codeaurora.org> +e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3840 } -- 0-DAY CI Kernel Test Service diff --git a/a/content_digest b/N1/content_digest index 98b6ac8..479f7e0 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,23 +1,17 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <error27@gmail.com>\0" "Subject\0drivers/net/wireless/realtek/rtw89/mac.c:3829 rtw89_mac_cfg_ppdu_status() warn: missing error code? 'ret'\0" - "Date\0Fri, 10 Feb 2023 10:08:54 +0800\0" - "To\0oe-kbuild@lists.linux.dev\0" + "Date\0Fri, 10 Feb 2023 19:11:12 +0300\0" + "To\0oe-kbuild@lists.linux.dev" + " Ping-Ke Shih <pkshih@realtek.com>\0" "Cc\0lkp@intel.com" - " Dan Carpenter <error27@gmail.com>\0" + oe-kbuild-all@lists.linux.dev + linux-kernel@vger.kernel.org + " Kalle Valo <kvalo@kernel.org>\0" "\00:1\0" "b\0" - "BCC: lkp@intel.com\n" - "CC: oe-kbuild-all@lists.linux.dev\n" - "CC: linux-kernel@vger.kernel.org\n" - "TO: \"Ping-Ke Shih\" <pkshih@realtek.com>\n" - "CC: Kalle Valo <kvalo@kernel.org>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: e544a07438522ab3688416e6e2e34bf0ee6d8755\n" "commit: 7ba49f4c6896d83b3841c0b046a0a7b1e97cc0dd rtw89: 8852c: add 8852ce to Makefile and Kconfig\n" - "date: 9 months ago\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 9 months ago\n" "config: parisc-randconfig-m031-20230209 (https://download.01.org/0day-ci/archive/20230210/202302101023.ctlih5q0-lkp@intel.com/config)\n" "compiler: hppa-linux-gcc (GCC) 12.1.0\n" "\n" @@ -31,7 +25,6 @@ "\n" "vim +/ret +3829 drivers/net/wireless/realtek/rtw89/mac.c\n" "\n" - "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3817 \n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3818 int rtw89_mac_cfg_ppdu_status(struct rtw89_dev *rtwdev, u8 mac_idx, bool enable)\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3819 {\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3820 \tu32 reg = rtw89_mac_reg_by_idx(R_AX_PPDU_STAT, mac_idx);\n" @@ -44,6 +37,9 @@ "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3827 \tif (!enable) {\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3828 \t\trtw89_write32_clr(rtwdev, reg, B_AX_PPDU_STAT_RPT_EN);\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 @3829 \t\treturn ret;\n" + "\n" + "The code is correct, but it would be more readable to return 0;\n" + "\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3830 \t}\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3831 \n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3832 \trtw89_write32(rtwdev, reg, B_AX_PPDU_STAT_RPT_EN |\n" @@ -54,18 +50,13 @@ "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3837 \t\t\t RTW89_PRPT_DEST_HOST);\n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3838 \n" "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3839 \treturn ret;\n" - "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3840 }\n" - "861e58c8fc6be0 Zong-Zhe Yang 2021-12-21 3841 EXPORT_SYMBOL(rtw89_mac_cfg_ppdu_status);\n" - "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3842 \n" "\n" - ":::::: The code at line 3829 was first introduced by commit\n" - ":::::: e3ec7017f6a20d12ddd9fe23d345ebb7b8c104dd rtw89: add Realtek 802.11ax driver\n" + "Same here.\n" "\n" - ":::::: TO: Ping-Ke Shih <pkshih@realtek.com>\n" - ":::::: CC: Kalle Valo <kvalo@codeaurora.org>\n" + "e3ec7017f6a20d Ping-Ke Shih 2021-10-11 3840 }\n" "\n" "-- \n" "0-DAY CI Kernel Test Service\n" https://github.com/intel/lkp-tests -db7d77d81409adf20262c1f84f9f74adfd88dc9c62cd324e3c3af43256a6e451 +f338309fee7908404a31ba9eee050f89dc439c5106e17a2a289773c83b582b31
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.